diff mbox

drm/i915: VLV doesn't have LLC

Message ID 1366087683-27673-1-git-send-email-ben@bwidawsk.net (mailing list archive)
State New, archived
Headers show

Commit Message

Ben Widawsky April 16, 2013, 4:48 a.m. UTC
Caused by me with v2 of

commit 219f4fdbed5570f1d2e8da0af1c298dd3622060e
Author: Ben Widawsky <ben@bwidawsk.net>
Date:   Fri Mar 15 11:17:54 2013 -0700

    drm/i915: Introduce GEN7_FEATURES for device info

I don't have a VLV to test it with, Jesse, Ken, can one of you test?

Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Kenneth Graunke <kenneth@whitecape.org>
Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
---
 drivers/gpu/drm/i915/i915_drv.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Chris Wilson April 16, 2013, 7:52 a.m. UTC | #1
On Mon, Apr 15, 2013 at 09:48:03PM -0700, Ben Widawsky wrote:
> Caused by me with v2 of
> 
> commit 219f4fdbed5570f1d2e8da0af1c298dd3622060e
> Author: Ben Widawsky <ben@bwidawsk.net>
> Date:   Fri Mar 15 11:17:54 2013 -0700
> 
>     drm/i915: Introduce GEN7_FEATURES for device info
> 
> I don't have a VLV to test it with, Jesse, Ken, can one of you test?
> 
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> Cc: Kenneth Graunke <kenneth@whitecape.org>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>

Humble apologies for missing it earlier,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
Daniel Vetter April 16, 2013, 8:08 a.m. UTC | #2
On Tue, Apr 16, 2013 at 08:52:16AM +0100, Chris Wilson wrote:
> On Mon, Apr 15, 2013 at 09:48:03PM -0700, Ben Widawsky wrote:
> > Caused by me with v2 of
> > 
> > commit 219f4fdbed5570f1d2e8da0af1c298dd3622060e
> > Author: Ben Widawsky <ben@bwidawsk.net>
> > Date:   Fri Mar 15 11:17:54 2013 -0700
> > 
> >     drm/i915: Introduce GEN7_FEATURES for device info
> > 
> > I don't have a VLV to test it with, Jesse, Ken, can one of you test?
> > 
> > Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> > Cc: Kenneth Graunke <kenneth@whitecape.org>
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> 
> Humble apologies for missing it earlier,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Queued for -next, thanks for the patch.
-Daniel
Jesse Barnes April 16, 2013, 3:42 p.m. UTC | #3
On Mon, 15 Apr 2013 21:48:03 -0700
Ben Widawsky <ben@bwidawsk.net> wrote:

> Caused by me with v2 of
> 
> commit 219f4fdbed5570f1d2e8da0af1c298dd3622060e
> Author: Ben Widawsky <ben@bwidawsk.net>
> Date:   Fri Mar 15 11:17:54 2013 -0700
> 
>     drm/i915: Introduce GEN7_FEATURES for device info
> 
> I don't have a VLV to test it with, Jesse, Ken, can one of you test?
> 
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> Cc: Kenneth Graunke <kenneth@whitecape.org>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> ---
>  drivers/gpu/drm/i915/i915_drv.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index bddb9a5..c413aab 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -294,6 +294,7 @@ static const struct intel_device_info intel_valleyview_m_info = {
>  	.num_pipes = 2,
>  	.is_valleyview = 1,
>  	.display_mmio_offset = VLV_DISPLAY_BASE,
> +	.has_llc = 0, /* legal, last one wins */
>  };
>  
>  static const struct intel_device_info intel_valleyview_d_info = {
> @@ -301,6 +302,7 @@ static const struct intel_device_info intel_valleyview_d_info = {
>  	.num_pipes = 2,
>  	.is_valleyview = 1,
>  	.display_mmio_offset = VLV_DISPLAY_BASE,
> +	.has_llc = 0, /* legal, last one wins */
>  };
>  
>  static const struct intel_device_info intel_haswell_d_info = {

Oh this should help.

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index bddb9a5..c413aab 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -294,6 +294,7 @@  static const struct intel_device_info intel_valleyview_m_info = {
 	.num_pipes = 2,
 	.is_valleyview = 1,
 	.display_mmio_offset = VLV_DISPLAY_BASE,
+	.has_llc = 0, /* legal, last one wins */
 };
 
 static const struct intel_device_info intel_valleyview_d_info = {
@@ -301,6 +302,7 @@  static const struct intel_device_info intel_valleyview_d_info = {
 	.num_pipes = 2,
 	.is_valleyview = 1,
 	.display_mmio_offset = VLV_DISPLAY_BASE,
+	.has_llc = 0, /* legal, last one wins */
 };
 
 static const struct intel_device_info intel_haswell_d_info = {