| Message ID | 1366060483-20342-4-git-send-email-tomasz.figa@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Apr 15, 2013 at 11:14:40PM +0200, Tomasz Figa wrote: > { .compatible = "samsung,exynos4x12-pinctrl", }, > { .compatible = "samsung,exynos5250-pinctrl", }, > { .compatible = "samsung,exynos5440-pinctrl", }, > + { }, Strictly speaking this is a separate bug fix (though I see that's already in -next separately anyway so whatever).
On Tuesday 16 of April 2013 17:27:50 Mark Brown wrote: > On Mon, Apr 15, 2013 at 11:14:40PM +0200, Tomasz Figa wrote: > > { .compatible = "samsung,exynos4x12-pinctrl", }, > > { .compatible = "samsung,exynos5250-pinctrl", }, > > { .compatible = "samsung,exynos5440-pinctrl", }, > > > > + { }, > > Strictly speaking this is a separate bug fix (though I see that's > already in -next separately anyway so whatever). Right. But this fix is so small that I thought it would be a major waste of mail server processing power to send it as a separate patch. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Apr 17, 2013 at 12:35:58AM +0200, Tomasz Figa wrote: > On Tuesday 16 of April 2013 17:27:50 Mark Brown wrote: > > Strictly speaking this is a separate bug fix (though I see that's > > already in -next separately anyway so whatever). > Right. But this fix is so small that I thought it would be a major waste > of mail server processing power to send it as a separate patch. There's reviewer bandwidth too - one of the things people check for is that the change is doing what it's supposed to do, extra stuff in there is usually a red flag.
On 04/17/13 22:06, Mark Brown wrote: > On Wed, Apr 17, 2013 at 12:35:58AM +0200, Tomasz Figa wrote: >> On Tuesday 16 of April 2013 17:27:50 Mark Brown wrote: > >>> Strictly speaking this is a separate bug fix (though I see that's >>> already in -next separately anyway so whatever). > I agree with this. >> Right. But this fix is so small that I thought it would be a major waste >> of mail server processing power to send it as a separate patch. > But the fix would be value... > There's reviewer bandwidth too - one of the things people check for is > that the change is doing what it's supposed to do, extra stuff in there > is usually a red flag. Thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c index 99e0fa4..dc06a6f 100644 --- a/drivers/gpio/gpio-samsung.c +++ b/drivers/gpio/gpio-samsung.c @@ -3012,7 +3012,7 @@ static __init int samsung_gpiolib_init(void) int i, nr_chips; int group = 0; -#if defined(CONFIG_PINCTRL_EXYNOS) || defined(CONFIG_PINCTRL_EXYNOS5440) +#if defined(CONFIG_PINCTRL_SAMSUNG) || defined(CONFIG_PINCTRL_EXYNOS5440) /* * This gpio driver includes support for device tree support and there * are platforms using it. In order to maintain compatibility with those @@ -3026,10 +3026,12 @@ static __init int samsung_gpiolib_init(void) */ struct device_node *pctrl_np; static const struct of_device_id exynos_pinctrl_ids[] = { + { .compatible = "samsung,s3c64xx-pinctrl", }, { .compatible = "samsung,exynos4210-pinctrl", }, { .compatible = "samsung,exynos4x12-pinctrl", }, { .compatible = "samsung,exynos5250-pinctrl", }, { .compatible = "samsung,exynos5440-pinctrl", }, + { }, }; for_each_matching_node(pctrl_np, exynos_pinctrl_ids) if (pctrl_np && of_device_is_available(pctrl_np))
The new driver handles GPIO on DT-enabled platforms. Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com> --- drivers/gpio/gpio-samsung.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)