| Message ID | 1366198467-6757-3-git-send-email-sourav.poddar@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Apr 17, 2013 at 05:04:23PM +0530, Sourav Poddar wrote: > Since "uart_console" definition is now moved to serial core > haeder file . Serial drivers need not define them. > > Cc: Sylvain Munaut <tnt@246tNt.com> > Cc: Santosh Shilimkar <santosh.shilimkar@ti.com> > Cc: Felipe Balbi <balbi@ti.com> > Cc: Rajendra nayak <rnayak@ti.com> > Signed-off-by: Sourav Poddar <sourav.poddar@ti.com> looks like it should be merged with previous patch to avoid redefinition errors.
On Thursday 18 April 2013 09:26 AM, Felipe Balbi wrote: > On Wed, Apr 17, 2013 at 05:04:23PM +0530, Sourav Poddar wrote: >> Since "uart_console" definition is now moved to serial core >> haeder file . Serial drivers need not define them. >> >> Cc: Sylvain Munaut<tnt@246tNt.com> >> Cc: Santosh Shilimkar<santosh.shilimkar@ti.com> >> Cc: Felipe Balbi<balbi@ti.com> >> Cc: Rajendra nayak<rnayak@ti.com> >> Signed-off-by: Sourav Poddar<sourav.poddar@ti.com> > looks like it should be merged with previous patch to avoid redefinition > errors. > true..i can squash it with the previous patch. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Apr 17, 2013 at 05:04:23PM +0530, Sourav Poddar wrote: > Since "uart_console" definition is now moved to serial core > haeder file . Serial drivers need not define them. This needs to be part of patch 1. Having it separate may provoke compiler warnings. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Russell, On Thursday 18 April 2013 04:20 PM, Russell King - ARM Linux wrote: > On Wed, Apr 17, 2013 at 05:04:23PM +0530, Sourav Poddar wrote: >> Since "uart_console" definition is now moved to serial core >> haeder file . Serial drivers need not define them. > This needs to be part of patch 1. Having it separate may provoke compiler > warnings. Ok. I will fold it in the first patch in my next version. Thanks, Sourav -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/tty/serial/mpc52xx_uart.c b/drivers/tty/serial/mpc52xx_uart.c index 018bad9..d74ac06 100644 --- a/drivers/tty/serial/mpc52xx_uart.c +++ b/drivers/tty/serial/mpc52xx_uart.c @@ -84,16 +84,6 @@ static void mpc52xx_uart_of_enumerate(void); static irqreturn_t mpc52xx_uart_int(int irq, void *dev_id); static irqreturn_t mpc5xxx_uart_process_int(struct uart_port *port); - -/* Simple macro to test if a port is console or not. This one is taken - * for serial_core.c and maybe should be moved to serial_core.h ? */ -#ifdef CONFIG_SERIAL_CORE_CONSOLE -#define uart_console(port) \ - ((port)->cons && (port)->cons->index == (port)->line) -#else -#define uart_console(port) (0) -#endif - /* ======================================================================== */ /* PSC fifo operations for isolating differences between 52xx and 512x */ /* ======================================================================== */
Since "uart_console" definition is now moved to serial core haeder file . Serial drivers need not define them. Cc: Sylvain Munaut <tnt@246tNt.com> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com> Cc: Felipe Balbi <balbi@ti.com> Cc: Rajendra nayak <rnayak@ti.com> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com> --- drivers/tty/serial/mpc52xx_uart.c | 10 ---------- 1 files changed, 0 insertions(+), 10 deletions(-)