[v3,4/4] ARM: shmobile: BOCK-W: enable USB in defconfig

Message ID	201304170135.10251.sergei.shtylyov@cogentembedded.com (mailing list archive)
State	Superseded
Commit	4ce2a0e1122c07206e7fff2ef50c645684d81bfa
Headers	show Return-Path: <linux-sh-owner@vger.kernel.org> To: linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 4/4] ARM: shmobile: BOCK-W: enable USB in defconfig Cc: linux-sh@vger.kernel.org, linux-usb@vger.kernel.org From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Organization: Cogent Embedded Date: Wed, 17 Apr 2013 01:35:09 +0400 MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201304170135.10251.sergei.shtylyov@cogentembedded.com> Sender: linux-sh-owner@vger.kernel.org Precedence: bulk

Message ID

201304170135.10251.sergei.shtylyov@cogentembedded.com (mailing list archive)

State

Superseded

Commit

4ce2a0e1122c07206e7fff2ef50c645684d81bfa

Headers

To: linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/4] ARM: shmobile: BOCK-W: enable USB in defconfig
Cc: linux-sh@vger.kernel.org, linux-usb@vger.kernel.org
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Organization: Cogent Embedded
Date: Wed, 17 Apr 2013 01:35:09 +0400
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201304170135.10251.sergei.shtylyov@cogentembedded.com>
Sender: linux-sh-owner@vger.kernel.org
Precedence: bulk

Commit Message

Sergei Shtylyov April 16, 2013, 9:35 p.m. UTC

Enable USB platform EHCI/OHCI and common PHY drivers in 'bockw_defconfig'.
Enable USB storage driver and SCSI disk driver that it needs as well...

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 arch/arm/configs/bockw_defconfig |   11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Simon Horman April 18, 2013, 2:05 p.m. UTC | #1

On Wed, Apr 17, 2013 at 01:35:09AM +0400, Sergei Shtylyov wrote:
> Enable USB platform EHCI/OHCI and common PHY drivers in 'bockw_defconfig'.
> Enable USB storage driver and SCSI disk driver that it needs as well...
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

I realise that this is not going to be useful until the rest
of the series has been merged. But regardless I have pre-emptively
queued it up for v3.11 in the defconfig-bockw branch.
> 
> ---
>  arch/arm/configs/bockw_defconfig |   11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> Index: renesas/arch/arm/configs/bockw_defconfig
> ===================================================================
> --- renesas.orig/arch/arm/configs/bockw_defconfig
> +++ renesas/arch/arm/configs/bockw_defconfig
> @@ -48,6 +48,8 @@ CONFIG_DEVTMPFS_MOUNT=y
>  # CONFIG_STANDALONE is not set
>  # CONFIG_PREVENT_FIRMWARE_BUILD is not set
>  # CONFIG_FW_LOADER is not set
> +CONFIG_SCSI=y
> +CONFIG_BLK_DEV_SD=y
>  CONFIG_NETDEVICES=y
>  # CONFIG_NET_CADENCE is not set
>  # CONFIG_NET_VENDOR_BROADCOM is not set
> @@ -71,7 +73,14 @@ CONFIG_SERIAL_SH_SCI_NR_UARTS=6
>  CONFIG_SERIAL_SH_SCI_CONSOLE=y
>  # CONFIG_HW_RANDOM is not set
>  # CONFIG_HWMON is not set
> -# CONFIG_USB_SUPPORT is not set
> +CONFIG_USB=y
> +CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
> +CONFIG_USB_EHCI_HCD=y
> +CONFIG_USB_OHCI_HCD=y
> +CONFIG_USB_OHCI_HCD_PLATFORM=y
> +CONFIG_USB_EHCI_HCD_PLATFORM=y
> +CONFIG_USB_STORAGE=y
> +CONFIG_USB_RCAR_PHY=y
>  CONFIG_UIO=y
>  CONFIG_UIO_PDRV_GENIRQ=y
>  # CONFIG_IOMMU_SUPPORT is not set
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Sergei Shtylyov April 18, 2013, 10:50 p.m. UTC | #2

Hello.

On 04/18/2013 06:05 PM, Simon Horman wrote:

>
>> Enable USB platform EHCI/OHCI and common PHY drivers in 'bockw_defconfig'.
>> Enable USB storage driver and SCSI disk driver that it needs as well...
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> I realise that this is not going to be useful until the rest
> of the series has been merged. But regardless I have pre-emptively
> queued it up for v3.11 in the defconfig-bockw branch.
>> ---
>>   arch/arm/configs/bockw_defconfig |   11 ++++++++++-
>>   1 file changed, 10 insertions(+), 1 deletion(-)
>>
>> Index: renesas/arch/arm/configs/bockw_defconfig
>> ===================================================================
>> --- renesas.orig/arch/arm/configs/bockw_defconfig
>> +++ renesas/arch/arm/configs/bockw_defconfig
>> @@ -48,6 +48,8 @@ CONFIG_DEVTMPFS_MOUNT=y
>>   # CONFIG_STANDALONE is not set
>>   # CONFIG_PREVENT_FIRMWARE_BUILD is not set
>>   # CONFIG_FW_LOADER is not set
>> +CONFIG_SCSI=y
>> +CONFIG_BLK_DEV_SD=y
>>   CONFIG_NETDEVICES=y
>>   # CONFIG_NET_CADENCE is not set
>>   # CONFIG_NET_VENDOR_BROADCOM is not set
>> @@ -71,7 +73,14 @@ CONFIG_SERIAL_SH_SCI_NR_UARTS=6
>>   CONFIG_SERIAL_SH_SCI_CONSOLE=y
>>   # CONFIG_HW_RANDOM is not set
>>   # CONFIG_HWMON is not set
>> -# CONFIG_USB_SUPPORT is not set
>> +CONFIG_USB=y
>> +CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
>> +CONFIG_USB_EHCI_HCD=y
>> +CONFIG_USB_OHCI_HCD=y
>> +CONFIG_USB_OHCI_HCD_PLATFORM=y
>> +CONFIG_USB_EHCI_HCD_PLATFORM=y
>> +CONFIG_USB_STORAGE=y
>> +CONFIG_USB_RCAR_PHY=y
>>

    Unfortunately, you've made a mistake in this last line of the patch:
you've truncated it to just "CONFIG_USB_RCAR". :-(
    Will you correct it?

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Simon Horman April 19, 2013, 2:14 a.m. UTC | #3

On Fri, Apr 19, 2013 at 02:50:05AM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 04/18/2013 06:05 PM, Simon Horman wrote:
> 
> >
> >>Enable USB platform EHCI/OHCI and common PHY drivers in 'bockw_defconfig'.
> >>Enable USB storage driver and SCSI disk driver that it needs as well...
> >>
> >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >I realise that this is not going to be useful until the rest
> >of the series has been merged. But regardless I have pre-emptively
> >queued it up for v3.11 in the defconfig-bockw branch.
> >>---
> >>  arch/arm/configs/bockw_defconfig |   11 ++++++++++-
> >>  1 file changed, 10 insertions(+), 1 deletion(-)
> >>
> >>Index: renesas/arch/arm/configs/bockw_defconfig
> >>===================================================================
> >>--- renesas.orig/arch/arm/configs/bockw_defconfig
> >>+++ renesas/arch/arm/configs/bockw_defconfig
> >>@@ -48,6 +48,8 @@ CONFIG_DEVTMPFS_MOUNT=y
> >>  # CONFIG_STANDALONE is not set
> >>  # CONFIG_PREVENT_FIRMWARE_BUILD is not set
> >>  # CONFIG_FW_LOADER is not set
> >>+CONFIG_SCSI=y
> >>+CONFIG_BLK_DEV_SD=y
> >>  CONFIG_NETDEVICES=y
> >>  # CONFIG_NET_CADENCE is not set
> >>  # CONFIG_NET_VENDOR_BROADCOM is not set
> >>@@ -71,7 +73,14 @@ CONFIG_SERIAL_SH_SCI_NR_UARTS=6
> >>  CONFIG_SERIAL_SH_SCI_CONSOLE=y
> >>  # CONFIG_HW_RANDOM is not set
> >>  # CONFIG_HWMON is not set
> >>-# CONFIG_USB_SUPPORT is not set
> >>+CONFIG_USB=y
> >>+CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
> >>+CONFIG_USB_EHCI_HCD=y
> >>+CONFIG_USB_OHCI_HCD=y
> >>+CONFIG_USB_OHCI_HCD_PLATFORM=y
> >>+CONFIG_USB_EHCI_HCD_PLATFORM=y
> >>+CONFIG_USB_STORAGE=y
> >>+CONFIG_USB_RCAR_PHY=y
> >>
> 
>    Unfortunately, you've made a mistake in this last line of the patch:
> you've truncated it to just "CONFIG_USB_RCAR". :-(
>    Will you correct it?

Sorry about that, I will fix it.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Sergei Shtylyov April 19, 2013, 8:23 p.m. UTC | #4

On 04/19/2013 06:14 AM, Simon Horman wrote:
> On Fri, Apr 19, 2013 at 02:50:05AM +0400, Sergei Shtylyov wrote:
>> Hello.
>>
>> On 04/18/2013 06:05 PM, Simon Horman wrote:
>>
>>>> Enable USB platform EHCI/OHCI and common PHY drivers in 'bockw_defconfig'.
>>>> Enable USB storage driver and SCSI disk driver that it needs as well...
>>>>
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>> I realise that this is not going to be useful until the rest
>>> of the series has been merged. But regardless I have pre-emptively
>>> queued it up for v3.11 in the defconfig-bockw branch.
>>>> ---
>>>>   arch/arm/configs/bockw_defconfig |   11 ++++++++++-
>>>>   1 file changed, 10 insertions(+), 1 deletion(-)
>>>>
>>>> Index: renesas/arch/arm/configs/bockw_defconfig
>>>> ===================================================================
>>>> --- renesas.orig/arch/arm/configs/bockw_defconfig
>>>> +++ renesas/arch/arm/configs/bockw_defconfig
>>>> @@ -48,6 +48,8 @@ CONFIG_DEVTMPFS_MOUNT=y
>>>>   # CONFIG_STANDALONE is not set
>>>>   # CONFIG_PREVENT_FIRMWARE_BUILD is not set
>>>>   # CONFIG_FW_LOADER is not set
>>>> +CONFIG_SCSI=y
>>>> +CONFIG_BLK_DEV_SD=y
>>>>   CONFIG_NETDEVICES=y
>>>>   # CONFIG_NET_CADENCE is not set
>>>>   # CONFIG_NET_VENDOR_BROADCOM is not set
>>>> @@ -71,7 +73,14 @@ CONFIG_SERIAL_SH_SCI_NR_UARTS=6
>>>>   CONFIG_SERIAL_SH_SCI_CONSOLE=y
>>>>   # CONFIG_HW_RANDOM is not set
>>>>   # CONFIG_HWMON is not set
>>>> -# CONFIG_USB_SUPPORT is not set
>>>> +CONFIG_USB=y
>>>> +CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
>>>> +CONFIG_USB_EHCI_HCD=y
>>>> +CONFIG_USB_OHCI_HCD=y
>>>> +CONFIG_USB_OHCI_HCD_PLATFORM=y
>>>> +CONFIG_USB_EHCI_HCD_PLATFORM=y
>>>> +CONFIG_USB_STORAGE=y
>>>> +CONFIG_USB_RCAR_PHY=y
>>>>
>>     Unfortunately, you've made a mistake in this last line of the patch:
>> you've truncated it to just "CONFIG_USB_RCAR". :-(
>>     Will you correct it?
> Sorry about that, I will fix it.

     Sorry to say, but you fixed it the wrong way; now it's:

+CONFIG_USB_RCAR=y

instead of:

+CONFIG_USB_RCAR_PHY=y

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Index: renesas/arch/arm/configs/bockw_defconfig
===================================================================
--- renesas.orig/arch/arm/configs/bockw_defconfig
+++ renesas/arch/arm/configs/bockw_defconfig
@@ -48,6 +48,8 @@  CONFIG_DEVTMPFS_MOUNT=y
 # CONFIG_STANDALONE is not set
 # CONFIG_PREVENT_FIRMWARE_BUILD is not set
 # CONFIG_FW_LOADER is not set
+CONFIG_SCSI=y
+CONFIG_BLK_DEV_SD=y
 CONFIG_NETDEVICES=y
 # CONFIG_NET_CADENCE is not set
 # CONFIG_NET_VENDOR_BROADCOM is not set
@@ -71,7 +73,14 @@  CONFIG_SERIAL_SH_SCI_NR_UARTS=6
 CONFIG_SERIAL_SH_SCI_CONSOLE=y
 # CONFIG_HW_RANDOM is not set
 # CONFIG_HWMON is not set
-# CONFIG_USB_SUPPORT is not set
+CONFIG_USB=y
+CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_OHCI_HCD_PLATFORM=y
+CONFIG_USB_EHCI_HCD_PLATFORM=y
+CONFIG_USB_STORAGE=y
+CONFIG_USB_RCAR_PHY=y
 CONFIG_UIO=y
 CONFIG_UIO_PDRV_GENIRQ=y
 # CONFIG_IOMMU_SUPPORT is not set

[v3,4/4] ARM: shmobile: BOCK-W: enable USB in defconfig

Commit Message

Comments

Patch