diff mbox

ARM64: kernel: compiling issue, duplicate definition of early_console

Message ID 51712213.4060607@asianux.com (mailing list archive)
State New, archived
Headers show

Commit Message

Chen Gang April 19, 2013, 10:53 a.m. UTC
when compiling with allmodconfig.
    early_console is already defined as an extern global pointer.

  need let it point to the object which we intend to (like ARM32 done).


Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
 arch/arm64/kernel/early_printk.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

 	.flags =	CON_PRINTBUFFER | CON_BOOT,
@@ -145,7 +145,8 @@ static int __init setup_early_printk(char *buf)
 		early_base = early_io_map(paddr, EARLYCON_IOBASE);

 	printch = match->printch;
-	register_console(&early_console);
+	early_console = &early_console_dev;
+	register_console(&early_console_dev);

 	return 0;
 }

Comments

Arnd Bergmann April 19, 2013, 12:15 p.m. UTC | #1
On Friday 19 April 2013, Chen Gang wrote:
>   when compiling with allmodconfig.
>     early_console is already defined as an extern global pointer.
> 
>   need let it point to the object which we intend to (like ARM32 done).
> 
> 
> Signed-off-by: Chen Gang <gang.chen@asianux.com>

Acked-by: Arnd Bergmann <arnd@arndb.de>
Catalin Marinas April 19, 2013, 12:31 p.m. UTC | #2
On Fri, Apr 19, 2013 at 11:53:07AM +0100, Chen Gang wrote:
>   when compiling with allmodconfig.
>     early_console is already defined as an extern global pointer.
> 
>   need let it point to the object which we intend to (like ARM32 done).
> 
> 
> Signed-off-by: Chen Gang <gang.chen@asianux.com>

Thanks for the patch.
Chen Gang April 20, 2013, 1:54 a.m. UTC | #3
On 2013?04?19? 20:31, Catalin Marinas wrote:
> On Fri, Apr 19, 2013 at 11:53:07AM +0100, Chen Gang wrote:
>>   when compiling with allmodconfig.
>>     early_console is already defined as an extern global pointer.
>>
>>   need let it point to the object which we intend to (like ARM32 done).
>>
>>
>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> 
> Thanks for the patch.
> 

  :-)
Chen Gang April 20, 2013, 1:55 a.m. UTC | #4
On 2013?04?19? 20:15, Arnd Bergmann wrote:
> On Friday 19 April 2013, Chen Gang wrote:
>> >   when compiling with allmodconfig.
>> >     early_console is already defined as an extern global pointer.
>> > 
>> >   need let it point to the object which we intend to (like ARM32 done).
>> > 
>> > 
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> 
> 

  thanks
diff mbox

Patch

diff --git a/arch/arm64/kernel/early_printk.c
b/arch/arm64/kernel/early_printk.c
index ac974f4..fbb6e18 100644
--- a/arch/arm64/kernel/early_printk.c
+++ b/arch/arm64/kernel/early_printk.c
@@ -95,7 +95,7 @@  static void early_write(struct console *con, const
char *s, unsigned n)
 	}
 }

-static struct console early_console = {
+static struct console early_console_dev = {
 	.name =		"earlycon",
 	.write =	early_write,