| Message ID | 1366389493-8239-6-git-send-email-l.majewski@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 19 April 2013 22:08, Lukasz Majewski <l.majewski@samsung.com> wrote: > Enable TMU support for Exynos4412 based target with device tree. > > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > --- I have already submitted a similar patch for doing this: http://permalink.gmane.org/gmane.linux.power-management.general/33311
On Friday 19 of April 2013 23:41:29 Sachin Kamat wrote: > On 19 April 2013 22:08, Lukasz Majewski <l.majewski@samsung.com> wrote: > > Enable TMU support for Exynos4412 based target with device tree. > > > > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > --- > > I have already submitted a similar patch for doing this: > http://permalink.gmane.org/gmane.linux.power-management.general/33311 Hmm, looks like we missed this series indeed. You haven't CC'ed linux- samsung-soc mailing list, though. I guess this is the reason. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 19 April 2013 23:51, Tomasz Figa <tomasz.figa@gmail.com> wrote: > On Friday 19 of April 2013 23:41:29 Sachin Kamat wrote: >> On 19 April 2013 22:08, Lukasz Majewski <l.majewski@samsung.com> wrote: >> > Enable TMU support for Exynos4412 based target with device tree. >> > >> > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> >> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> >> > --- >> >> I have already submitted a similar patch for doing this: >> http://permalink.gmane.org/gmane.linux.power-management.general/33311 > > Hmm, looks like we missed this series indeed. You haven't CC'ed linux- > samsung-soc mailing list, though. I guess this is the reason. Indeed I missed CCing linux-samsung-soc mailing list; sorry about that.
Hi, I have one suggestion, On Fri, Apr 19, 2013 at 10:08 PM, Lukasz Majewski <l.majewski@samsung.com> wrote: > Enable TMU support for Exynos4412 based target with device tree. > > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > drivers/thermal/exynos_thermal.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/thermal/exynos_thermal.c b/drivers/thermal/exynos_thermal.c > index e922fa4..f54066d 100644 > --- a/drivers/thermal/exynos_thermal.c > +++ b/drivers/thermal/exynos_thermal.c > @@ -819,6 +819,10 @@ static const struct of_device_id exynos_tmu_match[] = { > .data = (void *)EXYNOS4210_TMU_DRV_DATA, > }, > { > + .compatible = "samsung,exynos4412-tmu", > + .data = (void *)EXYNOS_TMU_DRV_DATA, > + }, Instead of adding a new compatible string, "exynos5250-tmu" name can be re-used in the 4412 DT node file as 4412 and 5250 TMU controller are same. Thanks, Amit Daniel > + { > .compatible = "samsung,exynos5250-tmu", > .data = (void *)EXYNOS_TMU_DRV_DATA, > }, > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi amit, > Hi, > > I have one suggestion, > > On Fri, Apr 19, 2013 at 10:08 PM, Lukasz Majewski > <l.majewski@samsung.com> wrote: > > Enable TMU support for Exynos4412 based target with device tree. > > > > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > --- > > drivers/thermal/exynos_thermal.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/thermal/exynos_thermal.c > > b/drivers/thermal/exynos_thermal.c index e922fa4..f54066d 100644 > > --- a/drivers/thermal/exynos_thermal.c > > +++ b/drivers/thermal/exynos_thermal.c > > @@ -819,6 +819,10 @@ static const struct of_device_id > > exynos_tmu_match[] = { .data = (void *)EXYNOS4210_TMU_DRV_DATA, > > }, > > { > > + .compatible = "samsung,exynos4412-tmu", > > + .data = (void *)EXYNOS_TMU_DRV_DATA, > > + }, > Instead of adding a new compatible string, "exynos5250-tmu" name can > be re-used in the 4412 DT node file as 4412 and 5250 TMU controller > are same. Good point. > > Thanks, > Amit Daniel > > + { > > .compatible = "samsung,exynos5250-tmu", > > .data = (void *)EXYNOS_TMU_DRV_DATA, > > }, > > -- > > 1.7.10.4 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe > > linux-samsung-soc" in the body of a message to > > majordomo@vger.kernel.org More majordomo info at > > http://vger.kernel.org/majordomo-info.html
On 22 April 2013 11:55, amit kachhap <amit.kachhap@gmail.com> wrote: > Hi, > > I have one suggestion, > > On Fri, Apr 19, 2013 at 10:08 PM, Lukasz Majewski > <l.majewski@samsung.com> wrote: >> Enable TMU support for Exynos4412 based target with device tree. >> >> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> >> --- >> drivers/thermal/exynos_thermal.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/thermal/exynos_thermal.c b/drivers/thermal/exynos_thermal.c >> index e922fa4..f54066d 100644 >> --- a/drivers/thermal/exynos_thermal.c >> +++ b/drivers/thermal/exynos_thermal.c >> @@ -819,6 +819,10 @@ static const struct of_device_id exynos_tmu_match[] = { >> .data = (void *)EXYNOS4210_TMU_DRV_DATA, >> }, >> { >> + .compatible = "samsung,exynos4412-tmu", >> + .data = (void *)EXYNOS_TMU_DRV_DATA, >> + }, > Instead of adding a new compatible string, "exynos5250-tmu" name can > be re-used in the 4412 DT node file as 4412 and 5250 TMU controller > are same. In cases where they are the same, it was generally the previous version of SoC that was added to the compatible list and re-used in the higher ones. IIRC, in cases where exynos5 based string was already defined a separate compatible string was added for exynos4 too (even if they used same driver data).
diff --git a/drivers/thermal/exynos_thermal.c b/drivers/thermal/exynos_thermal.c index e922fa4..f54066d 100644 --- a/drivers/thermal/exynos_thermal.c +++ b/drivers/thermal/exynos_thermal.c @@ -819,6 +819,10 @@ static const struct of_device_id exynos_tmu_match[] = { .data = (void *)EXYNOS4210_TMU_DRV_DATA, }, { + .compatible = "samsung,exynos4412-tmu", + .data = (void *)EXYNOS_TMU_DRV_DATA, + }, + { .compatible = "samsung,exynos5250-tmu", .data = (void *)EXYNOS_TMU_DRV_DATA, },