diff mbox

kvm tools: remove arbitrary minimum RAM limitation

Message ID 1366729054-5524-1-git-send-email-sasha.levin@oracle.com (mailing list archive)
State New, archived
Headers show

Commit Message

Sasha Levin April 23, 2013, 2:57 p.m. UTC
We don't really need 64MB of RAM to boot, it's a nice default if we don't
have anything else - but it's not actually required for anything:

sh-4.2# free -h
             total       used       free     shared    buffers     cached
Mem:           20M        15M       4.2M         0B         0B       4.2M
-/+ buffers/cache:        11M       8.3M
Swap:           0B         0B         0B

Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
---
 tools/kvm/builtin-run.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Will Deacon April 23, 2013, 3:04 p.m. UTC | #1
On Tue, Apr 23, 2013 at 03:57:34PM +0100, Sasha Levin wrote:
> We don't really need 64MB of RAM to boot, it's a nice default if we don't
> have anything else - but it's not actually required for anything:
> 
> sh-4.2# free -h
>              total       used       free     shared    buffers     cached
> Mem:           20M        15M       4.2M         0B         0B       4.2M
> -/+ buffers/cache:        11M       8.3M
> Swap:           0B         0B         0B
> 
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

The smaller the better!

  Acked-by: Will Deacon <will.deacon@arm.com>

Will
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Pekka Enberg April 24, 2013, 7:32 a.m. UTC | #2
On 04/23/2013 05:57 PM, Sasha Levin wrote:
> We don't really need 64MB of RAM to boot, it's a nice default if we don't
> have anything else - but it's not actually required for anything:
>
> sh-4.2# free -h
>               total       used       free     shared    buffers     cached
> Mem:           20M        15M       4.2M         0B         0B       4.2M
> -/+ buffers/cache:        11M       8.3M
> Swap:           0B         0B         0B
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

Applied, thanks!

			Pekka

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Michael Ellerman April 24, 2013, 8:25 a.m. UTC | #3
On Tue, 2013-04-23 at 10:57 -0400, Sasha Levin wrote:
> We don't really need 64MB of RAM to boot, it's a nice default if we don't
> have anything else - but it's not actually required for anything:

Nice, I am carrying something similar locally so I can boot in 4K :)

cheers

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Asias He April 24, 2013, 9:18 a.m. UTC | #4
On Wed, Apr 24, 2013 at 06:25:30PM +1000, Michael Ellerman wrote:
> On Tue, 2013-04-23 at 10:57 -0400, Sasha Levin wrote:
> > We don't really need 64MB of RAM to boot, it's a nice default if we don't
> > have anything else - but it's not actually required for anything:
> 
> Nice, I am carrying something similar locally so I can boot in 4K :)

Show me your $free ;-)

> cheers
>
Sasha Levin April 24, 2013, 5:50 p.m. UTC | #5
On 04/24/2013 04:25 AM, Michael Ellerman wrote:
> On Tue, 2013-04-23 at 10:57 -0400, Sasha Levin wrote:
>> We don't really need 64MB of RAM to boot, it's a nice default if we don't
>> have anything else - but it's not actually required for anything:
> 
> Nice, I am carrying something similar locally so I can boot in 4K :)

Feel free to send stuff you carry locally over! :)


Thanks,
Sasha

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/tools/kvm/builtin-run.c b/tools/kvm/builtin-run.c
index c6f5862..4d7fbf9d 100644
--- a/tools/kvm/builtin-run.c
+++ b/tools/kvm/builtin-run.c
@@ -563,9 +563,6 @@  static struct kvm *kvm_cmd_run_init(int argc, const char **argv)
 	if (!kvm->cfg.ram_size)
 		kvm->cfg.ram_size = get_ram_size(kvm->cfg.nrcpus);
 
-	if (kvm->cfg.ram_size < MIN_RAM_SIZE_MB)
-		die("Not enough memory specified: %lluMB (min %lluMB)", kvm->cfg.ram_size, MIN_RAM_SIZE_MB);
-
 	if (kvm->cfg.ram_size > host_ram_size())
 		pr_warning("Guest memory size %lluMB exceeds host physical RAM size %lluMB", kvm->cfg.ram_size, host_ram_size());