| Message ID | 5177B1F0.10106@asianux.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Apr 24, 2013 at 11:20:32AM +0100, Chen Gang wrote: > > For compiling with allmodconfig, need vga.h file, so generate it which > just only include the asm-generic one. > > It is firstly used by drivers/gpu/drm/drm_irq.c. > > The related error: > include/video/vga.h:22:21: fatal error: asm/vga.h: No such file or directory > > Signed-off-by: Chen Gang <gang.chen@asianux.com> > --- > arch/arm64/include/asm/vga.h | 21 +++++++++++++++++++++ > 1 files changed, 21 insertions(+), 0 deletions(-) > create mode 100644 arch/arm64/include/asm/vga.h > > diff --git a/arch/arm64/include/asm/vga.h b/arch/arm64/include/asm/vga.h > new file mode 100644 > index 0000000..1c49d51 > --- /dev/null > +++ b/arch/arm64/include/asm/vga.h > @@ -0,0 +1,21 @@ > +/* > + * Copyright (C) 2012 ARM Ltd. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program. If not, see <http://www.gnu.org/licenses/>. > + */ > +#ifndef ASMARM_VGA_H > +#define ASMARM_VGA_H > + > +#include <asm-generic/vga.h> > + > +#endif /* ASMARM_VGA_H */ Can't you just add this as a generic-y entry in asm/Kbuild? Will
On Wed, Apr 24, 2013 at 11:20:32AM +0100, Chen Gang wrote: > For compiling with allmodconfig, need vga.h file, so generate it which > just only include the asm-generic one. > > It is firstly used by drivers/gpu/drm/drm_irq.c. > > The related error: > include/video/vga.h:22:21: fatal error: asm/vga.h: No such file or directory > > Signed-off-by: Chen Gang <gang.chen@asianux.com> > --- > arch/arm64/include/asm/vga.h | 21 +++++++++++++++++++++ > 1 files changed, 21 insertions(+), 0 deletions(-) > create mode 100644 arch/arm64/include/asm/vga.h As Will said, please use asm/Kbuild. > diff --git a/arch/arm64/include/asm/vga.h b/arch/arm64/include/asm/vga.h > new file mode 100644 > index 0000000..1c49d51 > --- /dev/null > +++ b/arch/arm64/include/asm/vga.h > @@ -0,0 +1,21 @@ > +/* > + * Copyright (C) 2012 ARM Ltd. ARM copyright? You either work for ARM or there is a copyright assignment between you and ARM ;)
On 2013?04?24? 18:23, Will Deacon wrote: > On Wed, Apr 24, 2013 at 11:20:32AM +0100, Chen Gang wrote: >> > >> > For compiling with allmodconfig, need vga.h file, so generate it which >> > just only include the asm-generic one. >> > >> > It is firstly used by drivers/gpu/drm/drm_irq.c. >> > >> > The related error: >> > include/video/vga.h:22:21: fatal error: asm/vga.h: No such file or directory >> > >> > Signed-off-by: Chen Gang <gang.chen@asianux.com> >> > --- >> > arch/arm64/include/asm/vga.h | 21 +++++++++++++++++++++ >> > 1 files changed, 21 insertions(+), 0 deletions(-) >> > create mode 100644 arch/arm64/include/asm/vga.h >> > >> > diff --git a/arch/arm64/include/asm/vga.h b/arch/arm64/include/asm/vga.h >> > new file mode 100644 >> > index 0000000..1c49d51 >> > --- /dev/null >> > +++ b/arch/arm64/include/asm/vga.h >> > @@ -0,0 +1,21 @@ >> > +/* >> > + * Copyright (C) 2012 ARM Ltd. >> > + * >> > + * This program is free software; you can redistribute it and/or modify >> > + * it under the terms of the GNU General Public License version 2 as >> > + * published by the Free Software Foundation. >> > + * >> > + * This program is distributed in the hope that it will be useful, >> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> > + * GNU General Public License for more details. >> > + * >> > + * You should have received a copy of the GNU General Public License >> > + * along with this program. If not, see <http://www.gnu.org/licenses/>. >> > + */ >> > +#ifndef ASMARM_VGA_H >> > +#define ASMARM_VGA_H >> > + >> > +#include <asm-generic/vga.h> >> > + >> > +#endif /* ASMARM_VGA_H */ > Can't you just add this as a generic-y entry in asm/Kbuild? OK, thanks, I need send patch v3.
On 2013?04?24? 18:42, Catalin Marinas wrote: > On Wed, Apr 24, 2013 at 11:20:32AM +0100, Chen Gang wrote: >> For compiling with allmodconfig, need vga.h file, so generate it which >> just only include the asm-generic one. >> >> It is firstly used by drivers/gpu/drm/drm_irq.c. >> >> The related error: >> include/video/vga.h:22:21: fatal error: asm/vga.h: No such file or directory >> >> Signed-off-by: Chen Gang <gang.chen@asianux.com> >> --- >> arch/arm64/include/asm/vga.h | 21 +++++++++++++++++++++ >> 1 files changed, 21 insertions(+), 0 deletions(-) >> create mode 100644 arch/arm64/include/asm/vga.h > > As Will said, please use asm/Kbuild. > OK, I will send. >> diff --git a/arch/arm64/include/asm/vga.h b/arch/arm64/include/asm/vga.h >> new file mode 100644 >> index 0000000..1c49d51 >> --- /dev/null >> +++ b/arch/arm64/include/asm/vga.h >> @@ -0,0 +1,21 @@ >> +/* >> + * Copyright (C) 2012 ARM Ltd. > > ARM copyright? You either work for ARM or there is a copyright > assignment between you and ARM ;) > :-)
diff --git a/arch/arm64/include/asm/vga.h b/arch/arm64/include/asm/vga.h new file mode 100644 index 0000000..1c49d51 --- /dev/null +++ b/arch/arm64/include/asm/vga.h @@ -0,0 +1,21 @@ +/* + * Copyright (C) 2012 ARM Ltd. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + */ +#ifndef ASMARM_VGA_H +#define ASMARM_VGA_H + +#include <asm-generic/vga.h> + +#endif /* ASMARM_VGA_H */
For compiling with allmodconfig, need vga.h file, so generate it which just only include the asm-generic one. It is firstly used by drivers/gpu/drm/drm_irq.c. The related error: include/video/vga.h:22:21: fatal error: asm/vga.h: No such file or directory Signed-off-by: Chen Gang <gang.chen@asianux.com> --- arch/arm64/include/asm/vga.h | 21 +++++++++++++++++++++ 1 files changed, 21 insertions(+), 0 deletions(-) create mode 100644 arch/arm64/include/asm/vga.h