| Message ID | 1364724561-18045-1-git-send-email-pali.rohar@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sunday 31 March 2013 12:52:23 Sebastian Reichel wrote: > On Sun, Mar 31, 2013 at 12:09:21PM +0200, Pali Rohár wrote: > > From: Joni Lapilainen <joni.lapilainen@gmail.com> > > > > Without this patch LCD panel on Nokia RX-51 is still black > > > > Signed-off-by: Joni Lapilainen <joni.lapilainen@gmail.com> > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> > > Tested-by: Sebastian Reichel <sre@debian.org> > > Please note, that this patch has actually been proposed by > Aaro Koskinen <aaro.koskinen@iki.fi> quite some time ago [0]. > > [0] > http://permalink.gmane.org/gmane.linux.ports.arm.omap/81729 > > -- Sebastian CCing Aaro.
* Pali Rohár <pali.rohar@gmail.com> [130331 04:23]: > On Sunday 31 March 2013 12:52:23 Sebastian Reichel wrote: > > On Sun, Mar 31, 2013 at 12:09:21PM +0200, Pali Rohár wrote: > > > From: Joni Lapilainen <joni.lapilainen@gmail.com> > > > > > > Without this patch LCD panel on Nokia RX-51 is still black > > > > > > Signed-off-by: Joni Lapilainen <joni.lapilainen@gmail.com> > > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> > > > > Tested-by: Sebastian Reichel <sre@debian.org> > > > > Please note, that this patch has actually been proposed by > > Aaro Koskinen <aaro.koskinen@iki.fi> quite some time ago [0]. > > > > [0] > > http://permalink.gmane.org/gmane.linux.ports.arm.omap/81729 > > > > -- Sebastian > > CCing Aaro. Any ideas why this is happening? Is the touch screen controller somehow pulling one of the SPI lines before it's reset? I don't think there's any other connection between the LCD and touch controller besides the SPI lines? In any case there should be something in the description why this is needed.. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday 02 April 2013 18:31:38 Tony Lindgren wrote: > * Pali Rohár <pali.rohar@gmail.com> [130331 04:23]: > > On Sunday 31 March 2013 12:52:23 Sebastian Reichel wrote: > > > On Sun, Mar 31, 2013 at 12:09:21PM +0200, Pali Rohár wrote: > > > > From: Joni Lapilainen <joni.lapilainen@gmail.com> > > > > > > > > Without this patch LCD panel on Nokia RX-51 is still > > > > black > > > > > > > > Signed-off-by: Joni Lapilainen > > > > <joni.lapilainen@gmail.com> Signed-off-by: Pali Rohár > > > > <pali.rohar@gmail.com> > > > > > > Tested-by: Sebastian Reichel <sre@debian.org> > > > > > > Please note, that this patch has actually been proposed by > > > Aaro Koskinen <aaro.koskinen@iki.fi> quite some time ago > > > [0]. > > > > > > [0] > > > http://permalink.gmane.org/gmane.linux.ports.arm.omap/8172 > > > 9 > > > > > > -- Sebastian > > > > CCing Aaro. > > Any ideas why this is happening? > > Is the touch screen controller somehow pulling one of the SPI > lines before it's reset? I don't think there's any other > connection between the LCD and touch controller besides the > SPI lines? > > In any case there should be something in the description why > this is needed.. > > Regards, > > Tony Hi Tony, look at this Aaro's email: http://permalink.gmane.org/gmane.linux.ports.arm.omap/81729
* Pali Rohár <pali.rohar@gmail.com> [130410 07:20]: > On Tuesday 02 April 2013 18:31:38 Tony Lindgren wrote: > > * Pali Rohár <pali.rohar@gmail.com> [130331 04:23]: > > > On Sunday 31 March 2013 12:52:23 Sebastian Reichel wrote: > > > > On Sun, Mar 31, 2013 at 12:09:21PM +0200, Pali Rohár wrote: > > > > > From: Joni Lapilainen <joni.lapilainen@gmail.com> > > > > > > > > > > Without this patch LCD panel on Nokia RX-51 is still > > > > > black > > > > > > > > > > Signed-off-by: Joni Lapilainen > > > > > <joni.lapilainen@gmail.com> Signed-off-by: Pali Rohár > > > > > <pali.rohar@gmail.com> > > > > > > > > Tested-by: Sebastian Reichel <sre@debian.org> > > > > > > > > Please note, that this patch has actually been proposed by > > > > Aaro Koskinen <aaro.koskinen@iki.fi> quite some time ago > > > > [0]. > > > > > > > > [0] > > > > http://permalink.gmane.org/gmane.linux.ports.arm.omap/8172 > > > > 9 > > > > > > > > -- Sebastian > > > > > > CCing Aaro. > > > > Any ideas why this is happening? > > > > Is the touch screen controller somehow pulling one of the SPI > > lines before it's reset? I don't think there's any other > > connection between the LCD and touch controller besides the > > SPI lines? > > > > In any case there should be something in the description why > > this is needed.. > > > > Regards, > > > > Tony > > Hi Tony, look at this Aaro's email: > http://permalink.gmane.org/gmane.linux.ports.arm.omap/81729 OK can we have that summarized in the patch description please? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wednesday 10 April 2013 19:00:05 Tony Lindgren wrote: > * Pali Rohár <pali.rohar@gmail.com> [130410 07:20]: > > On Tuesday 02 April 2013 18:31:38 Tony Lindgren wrote: > > > * Pali Rohár <pali.rohar@gmail.com> [130331 04:23]: > > > > On Sunday 31 March 2013 12:52:23 Sebastian Reichel wrote: > > > > > On Sun, Mar 31, 2013 at 12:09:21PM +0200, Pali Rohár wrote: > > > > > > From: Joni Lapilainen <joni.lapilainen@gmail.com> > > > > > > > > > > > > Without this patch LCD panel on Nokia RX-51 is still > > > > > > black > > > > > > > > > > > > Signed-off-by: Joni Lapilainen > > > > > > <joni.lapilainen@gmail.com> Signed-off-by: Pali > > > > > > Rohár <pali.rohar@gmail.com> > > > > > > > > > > Tested-by: Sebastian Reichel <sre@debian.org> > > > > > > > > > > Please note, that this patch has actually been > > > > > proposed by Aaro Koskinen <aaro.koskinen@iki.fi> > > > > > quite some time ago [0]. > > > > > > > > > > [0] > > > > > http://permalink.gmane.org/gmane.linux.ports.arm.omap/ > > > > > 8172 9 > > > > > > > > > > -- Sebastian > > > > > > > > CCing Aaro. > > > > > > Any ideas why this is happening? > > > > > > Is the touch screen controller somehow pulling one of the > > > SPI lines before it's reset? I don't think there's any > > > other connection between the LCD and touch controller > > > besides the SPI lines? > > > > > > In any case there should be something in the description > > > why this is needed.. > > > > > > Regards, > > > > > > Tony > > > > Hi Tony, look at this Aaro's email: > > http://permalink.gmane.org/gmane.linux.ports.arm.omap/81729 > > OK can we have that summarized in the patch description > please? > > Regards, > > Tony Aaro, this patch is yours, can you resend it with description?
diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c index b09b5da..03290b9 100644 --- a/arch/arm/mach-omap2/board-rx51-peripherals.c +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c @@ -91,8 +91,8 @@ /* list all spi devices here */ enum { RX51_SPI_WL1251, - RX51_SPI_MIPID, /* LCD panel */ RX51_SPI_TSC2005, /* Touch Controller */ + RX51_SPI_MIPID, /* LCD panel */ }; static struct wl12xx_platform_data wl1251_pdata;