| Message ID | 1367366284-28304-2-git-send-email-soren.brinkmann@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Apr 30, 2013 at 04:57:58PM -0700, Soren Brinkmann wrote: > Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com> > CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > CC: Jiri Slaby <jslaby@suse.cz> > CC: linux-serial@vger.kernel.org Why would you need/want to do this? greg k-h
On Tue, Apr 30, 2013 at 05:00:48PM -0700, Greg Kroah-Hartman wrote: > On Tue, Apr 30, 2013 at 04:57:58PM -0700, Soren Brinkmann wrote: > > Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com> > > CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > CC: Jiri Slaby <jslaby@suse.cz> > > CC: linux-serial@vger.kernel.org > > Why would you need/want to do this? I often come across duplicated includes. Having some kind of order helps avoiding that, imho. Sören
On Tue, Apr 30, 2013 at 05:05:40PM -0700, Sören Brinkmann wrote: > On Tue, Apr 30, 2013 at 05:00:48PM -0700, Greg Kroah-Hartman wrote: > > On Tue, Apr 30, 2013 at 04:57:58PM -0700, Soren Brinkmann wrote: > > > Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com> > > > CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > CC: Jiri Slaby <jslaby@suse.cz> > > > CC: linux-serial@vger.kernel.org > > > > Why would you need/want to do this? > I often come across duplicated includes. Having some kind of order helps > avoiding that, imho. We have a tool to handle duplicated includes, no need to put them in sorted order for them to be detected. thanks, greg k-h
On 05/01/2013 02:23 AM, Greg Kroah-Hartman wrote: > On Tue, Apr 30, 2013 at 05:05:40PM -0700, Sören Brinkmann wrote: >> On Tue, Apr 30, 2013 at 05:00:48PM -0700, Greg Kroah-Hartman wrote: >>> On Tue, Apr 30, 2013 at 04:57:58PM -0700, Soren Brinkmann wrote: >>>> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com> >>>> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >>>> CC: Jiri Slaby <jslaby@suse.cz> >>>> CC: linux-serial@vger.kernel.org >>> >>> Why would you need/want to do this? >> I often come across duplicated includes. Having some kind of order helps >> avoiding that, imho. > > We have a tool to handle duplicated includes, no need to put them in > sorted order for them to be detected. What's the name of tool which does that? I have seen results from it but have never tried to find it out name and how to use it. Thanks, Michal
On Wed, May 01, 2013 at 08:50:09AM +0200, Michal Simek wrote: > On 05/01/2013 02:23 AM, Greg Kroah-Hartman wrote: > > On Tue, Apr 30, 2013 at 05:05:40PM -0700, Sören Brinkmann wrote: > >> On Tue, Apr 30, 2013 at 05:00:48PM -0700, Greg Kroah-Hartman wrote: > >>> On Tue, Apr 30, 2013 at 04:57:58PM -0700, Soren Brinkmann wrote: > >>>> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com> > >>>> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > >>>> CC: Jiri Slaby <jslaby@suse.cz> > >>>> CC: linux-serial@vger.kernel.org > >>> > >>> Why would you need/want to do this? > >> I often come across duplicated includes. Having some kind of order helps > >> avoiding that, imho. > > > > We have a tool to handle duplicated includes, no need to put them in > > sorted order for them to be detected. > > What's the name of tool which does that? > I have seen results from it but have never tried to find it out name and > how to use it. scripts/checkincludes.pl
On Tue, Apr 30, 2013 at 05:23:21PM -0700, Greg Kroah-Hartman wrote: > On Tue, Apr 30, 2013 at 05:05:40PM -0700, Sören Brinkmann wrote: > > On Tue, Apr 30, 2013 at 05:00:48PM -0700, Greg Kroah-Hartman wrote: > > > On Tue, Apr 30, 2013 at 04:57:58PM -0700, Soren Brinkmann wrote: > > > > Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com> > > > > CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > CC: Jiri Slaby <jslaby@suse.cz> > > > > CC: linux-serial@vger.kernel.org > > > > > > Why would you need/want to do this? > > I often come across duplicated includes. Having some kind of order helps > > avoiding that, imho. > > We have a tool to handle duplicated includes, no need to put them in > sorted order for them to be detected. During conflict resolution, I find it easier when there is some order. Anyway, consider it dropped. Sören
diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 4e5c778..773732b 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -11,17 +11,17 @@ * */ +#include <linux/clk.h> +#include <linux/console.h> +#include <linux/io.h> +#include <linux/irq.h> +#include <linux/module.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/serial.h> #include <linux/serial_core.h> #include <linux/tty.h> #include <linux/tty_flip.h> -#include <linux/console.h> -#include <linux/clk.h> -#include <linux/irq.h> -#include <linux/io.h> -#include <linux/of.h> -#include <linux/module.h> #define XUARTPS_TTY_NAME "ttyPS" #define XUARTPS_NAME "xuartps"
Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> CC: Jiri Slaby <jslaby@suse.cz> CC: linux-serial@vger.kernel.org --- drivers/tty/serial/xilinx_uartps.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)