| Message ID | 1367507786-505303-23-git-send-email-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Arnd, On Thu, May 2, 2013 at 11:16 AM, Arnd Bergmann <arnd@arndb.de> wrote: > It is not possible to select SND_SOC_SI476X if we have not also > enabled SND_SOC. > > warning: (RADIO_SI476X) selects SND_SOC_SI476X which has unmet > direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC) > > Cc: Hans Verkuil <hverkuil@xs4all.nl> > Cc: linux-media@vger.kernel.org > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- Note on your patch title, this change is against si476X, not on *si4713*. > drivers/media/radio/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig > index c0beee2..d529ba7 100644 > --- a/drivers/media/radio/Kconfig > +++ b/drivers/media/radio/Kconfig > @@ -22,6 +22,7 @@ config RADIO_SI476X > tristate "Silicon Laboratories Si476x I2C FM Radio" > depends on I2C && VIDEO_V4L2 > depends on MFD_SI476X_CORE > + depends on SND_SOC > select SND_SOC_SI476X > ---help--- > Choose Y here if you have this FM radio chip. > -- > 1.8.1.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday 02 May 2013, edubezval@gmail.com wrote: > On Thu, May 2, 2013 at 11:16 AM, Arnd Bergmann <arnd@arndb.de> wrote: > > It is not possible to select SND_SOC_SI476X if we have not also > > enabled SND_SOC. > > > > warning: (RADIO_SI476X) selects SND_SOC_SI476X which has unmet > > direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC) > > > > Cc: Hans Verkuil <hverkuil@xs4all.nl> > > Cc: linux-media@vger.kernel.org > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > --- > > Note on your patch title, this change is against si476X, not on *si4713*. > Sorry about that, I must have copied the wrong prefix from an older patch then. I'll fix it up locally in case I need to resend. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Em 02-05-2013 12:16, Arnd Bergmann escreveu: > It is not possible to select SND_SOC_SI476X if we have not also > enabled SND_SOC. > > warning: (RADIO_SI476X) selects SND_SOC_SI476X which has unmet > direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC) > > Cc: Hans Verkuil <hverkuil@xs4all.nl> > Cc: linux-media@vger.kernel.org > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/media/radio/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig > index c0beee2..d529ba7 100644 > --- a/drivers/media/radio/Kconfig > +++ b/drivers/media/radio/Kconfig > @@ -22,6 +22,7 @@ config RADIO_SI476X > tristate "Silicon Laboratories Si476x I2C FM Radio" > depends on I2C && VIDEO_V4L2 > depends on MFD_SI476X_CORE > + depends on SND_SOC > select SND_SOC_SI476X > ---help--- > Choose Y here if you have this FM radio chip. > Do you prefer to send it via your tree or via mine? Either way works for me. If you're willing to send it via your tree: Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday 02 May 2013, Mauro Carvalho Chehab wrote: > Do you prefer to send it via your tree or via mine? Either way works for me. > > If you're willing to send it via your tree: > > Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com> I'd prefer your tree, because the patch does not apply on 3.9. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig index c0beee2..d529ba7 100644 --- a/drivers/media/radio/Kconfig +++ b/drivers/media/radio/Kconfig @@ -22,6 +22,7 @@ config RADIO_SI476X tristate "Silicon Laboratories Si476x I2C FM Radio" depends on I2C && VIDEO_V4L2 depends on MFD_SI476X_CORE + depends on SND_SOC select SND_SOC_SI476X ---help--- Choose Y here if you have this FM radio chip.
It is not possible to select SND_SOC_SI476X if we have not also enabled SND_SOC. warning: (RADIO_SI476X) selects SND_SOC_SI476X which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC) Cc: Hans Verkuil <hverkuil@xs4all.nl> Cc: linux-media@vger.kernel.org Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/media/radio/Kconfig | 1 + 1 file changed, 1 insertion(+)