diff mbox

[3/9] Input: gpio_tilt_polled - Remove redundant platform_set_drvdata()

Message ID 1367679118-2980-3-git-send-email-sachin.kamat@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Sachin Kamat May 4, 2013, 2:51 p.m. UTC
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Heiko Stuebner <heiko@sntech.de>
---
 drivers/input/misc/gpio_tilt_polled.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

Comments

Heiko Stübner May 4, 2013, 7:44 p.m. UTC | #1
Am Samstag, 4. Mai 2013, 16:51:52 schrieb Sachin Kamat:
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Heiko Stuebner <heiko@sntech.de>

not sure, if it's needed for such a small change, but nevertheless
Acked-by: Heiko Stuebner <heiko@sntech.de>

> ---
>  drivers/input/misc/gpio_tilt_polled.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/misc/gpio_tilt_polled.c
> b/drivers/input/misc/gpio_tilt_polled.c index da05cca..714c683 100644
> --- a/drivers/input/misc/gpio_tilt_polled.c
> +++ b/drivers/input/misc/gpio_tilt_polled.c
> @@ -184,8 +184,6 @@ static int gpio_tilt_polled_remove(struct
> platform_device *pdev) struct gpio_tilt_polled_dev *tdev =
> platform_get_drvdata(pdev);
>  	const struct gpio_tilt_platform_data *pdata = tdev->pdata;
> 
> -	platform_set_drvdata(pdev, NULL);
> -
>  	input_unregister_polled_device(tdev->poll_dev);
>  	input_free_polled_device(tdev->poll_dev);

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/input/misc/gpio_tilt_polled.c b/drivers/input/misc/gpio_tilt_polled.c
index da05cca..714c683 100644
--- a/drivers/input/misc/gpio_tilt_polled.c
+++ b/drivers/input/misc/gpio_tilt_polled.c
@@ -184,8 +184,6 @@  static int gpio_tilt_polled_remove(struct platform_device *pdev)
 	struct gpio_tilt_polled_dev *tdev = platform_get_drvdata(pdev);
 	const struct gpio_tilt_platform_data *pdata = tdev->pdata;
 
-	platform_set_drvdata(pdev, NULL);
-
 	input_unregister_polled_device(tdev->poll_dev);
 	input_free_polled_device(tdev->poll_dev);