| Message ID | 1368577100-3530-10-git-send-email-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Laurent On Wed, 15 May 2013, Laurent Pinchart wrote: > Add GPIO controller nodes to the r8a7790 core device tree. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > arch/arm/boot/dts/r8a7790.dtsi | 54 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi > index ee21061..b5fe51da 100644 > --- a/arch/arm/boot/dts/r8a7790.dtsi > +++ b/arch/arm/boot/dts/r8a7790.dtsi > @@ -44,6 +44,60 @@ > }; > }; > > + gpio0: gpio@ffc40000 { > + compatible = "renesas,gpio-r8a7790", "renesas,gpio-rcar"; > + reg = <0xffc40000 0x2c>; > + interrupt-parent = <&gic>; > + interrupts = <0 4 0x4>; > + #gpio-cells = <2>; > + gpio-controller; > + }; I'm testing your patches on Lager and GPIOs don't seem to get registered: / # ls /sys/class/gpio/ export unexport / # And this is easy to trace back: sh_pfc_probe() calls sh_pfc_register_gpiochip(), where a check if (pfc->info->data_regs == NULL) return 0; successfully fails GPIO initialisation :) Is this known and there are still some pieces missing, or you weren't aware of this? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/
Hi Guennadi, On Thursday 16 May 2013 09:57:20 Guennadi Liakhovetski wrote: > On Wed, 15 May 2013, Laurent Pinchart wrote: > > Add GPIO controller nodes to the r8a7790 core device tree. > > > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+renesas@ideasonboard.com> > > --- > > > > arch/arm/boot/dts/r8a7790.dtsi | 54 +++++++++++++++++++++++++++++++++++++ > > 1 file changed, 54 insertions(+) > > > > diff --git a/arch/arm/boot/dts/r8a7790.dtsi > > b/arch/arm/boot/dts/r8a7790.dtsi index ee21061..b5fe51da 100644 > > --- a/arch/arm/boot/dts/r8a7790.dtsi > > +++ b/arch/arm/boot/dts/r8a7790.dtsi > > @@ -44,6 +44,60 @@ > > }; > > }; > > > > + gpio0: gpio@ffc40000 { > > + compatible = "renesas,gpio-r8a7790", "renesas,gpio-rcar"; > > + reg = <0xffc40000 0x2c>; > > + interrupt-parent = <&gic>; > > + interrupts = <0 4 0x4>; > > + #gpio-cells = <2>; > > + gpio-controller; > > + }; > > I'm testing your patches on Lager and GPIOs don't seem to get registered: > > / # ls /sys/class/gpio/ > export unexport > / # > > And this is easy to trace back: sh_pfc_probe() calls > sh_pfc_register_gpiochip(), where a check > > if (pfc->info->data_regs == NULL) > return 0; > > successfully fails GPIO initialisation :) Is this known and there are > still some pieces missing, or you weren't aware of this? GPIOs are handled by the gpio-rcar driver on R8A7790, not by the sh-pfc driver.
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi index ee21061..b5fe51da 100644 --- a/arch/arm/boot/dts/r8a7790.dtsi +++ b/arch/arm/boot/dts/r8a7790.dtsi @@ -44,6 +44,60 @@ }; }; + gpio0: gpio@ffc40000 { + compatible = "renesas,gpio-r8a7790", "renesas,gpio-rcar"; + reg = <0xffc40000 0x2c>; + interrupt-parent = <&gic>; + interrupts = <0 4 0x4>; + #gpio-cells = <2>; + gpio-controller; + }; + + gpio1: gpio@ffc41000 { + compatible = "renesas,gpio-r8a7790", "renesas,gpio-rcar"; + reg = <0xffc41000 0x2c>; + interrupt-parent = <&gic>; + interrupts = <0 5 0x4>; + #gpio-cells = <2>; + gpio-controller; + }; + + gpio2: gpio@ffc42000 { + compatible = "renesas,gpio-r8a7790", "renesas,gpio-rcar"; + reg = <0xffc42000 0x2c>; + interrupt-parent = <&gic>; + interrupts = <0 6 0x4>; + #gpio-cells = <2>; + gpio-controller; + }; + + gpio3: gpio@ffc43000 { + compatible = "renesas,gpio-r8a7790", "renesas,gpio-rcar"; + reg = <0xffc43000 0x2c>; + interrupt-parent = <&gic>; + interrupts = <0 7 0x4>; + #gpio-cells = <2>; + gpio-controller; + }; + + gpio4: gpio@ffc44000 { + compatible = "renesas,gpio-r8a7790", "renesas,gpio-rcar"; + reg = <0xffc44000 0x2c>; + interrupt-parent = <&gic>; + interrupts = <0 8 0x4>; + #gpio-cells = <2>; + gpio-controller; + }; + + gpio5: gpio@ffc45000 { + compatible = "renesas,gpio-r8a7790", "renesas,gpio-rcar"; + reg = <0xffc45000 0x2c>; + interrupt-parent = <&gic>; + interrupts = <0 9 0x4>; + #gpio-cells = <2>; + gpio-controller; + }; + timer { compatible = "arm,armv7-timer"; interrupts = <1 13 0xf08>,
Add GPIO controller nodes to the r8a7790 core device tree. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- arch/arm/boot/dts/r8a7790.dtsi | 54 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+)