| Message ID | 4A0A4829.8080709@jp.fujitsu.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com> Date: Wed, 13 May 2009 13:10:17 +0900 > Could you review & test following patch for your issue? I cannot test until Saturday as I am on a cruise. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index 6f2e629..b680a5b 100644 --- a/drivers/pci/msi.c +++ b/drivers/pci/msi.c @@ -455,9 +455,7 @@ static int msix_capability_init(struct pci_dev *dev, entry->msi_attrib.default_irq = dev->irq; entry->msi_attrib.pos = pos; entry->mask_base = base; - entry->masked = readl(base + j * PCI_MSIX_ENTRY_SIZE + - PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET); - msix_mask_irq(entry, 1); + entry->masked = 1; list_add_tail(&entry->list, &dev->msi_list); }
Hi David, Could you review & test following patch for your issue? Thanks, H.Seto The NIU device refuses to allow accesses to MSI-X registers before MSI-X is enabled. This patch fixes the problem by removing the read & write of the mask register in msix_capability_init(). It will be safe since PCI spac says the maskbit's state after reset is always 1 (= masked). Reported-by: David S. Miller <davem@davemloft.net> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com> --- drivers/pci/msi.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)