| Message ID | 1368467199-8702-2-git-send-email-soren.brinkmann@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Greg, can you please add this patch to your tree? It is unrelated to clk changes which Soren sent. Thanks, Michal On 05/13/2013 07:46 PM, Soren Brinkmann wrote: > Currently Zynq does not support suspend/resume. > The driver callbacks are never used or tested, broken and using the old > PM interface. > > Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Jiri Slaby <jslaby@suse.cz> > Cc: linux-serial@vger.kernel.org > --- > drivers/tty/serial/xilinx_uartps.c | 30 ------------------------------ > 1 file changed, 30 deletions(-) > > diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c > index 4e5c778..b5f655d 100644 > --- a/drivers/tty/serial/xilinx_uartps.c > +++ b/drivers/tty/serial/xilinx_uartps.c > @@ -1006,34 +1006,6 @@ static int xuartps_remove(struct platform_device *pdev) > return rc; > } > > -/** > - * xuartps_suspend - suspend event > - * @pdev: Pointer to the platform device structure > - * @state: State of the device > - * > - * Returns 0 > - **/ > -static int xuartps_suspend(struct platform_device *pdev, pm_message_t state) > -{ > - /* Call the API provided in serial_core.c file which handles > - * the suspend. > - */ > - uart_suspend_port(&xuartps_uart_driver, &xuartps_port[pdev->id]); > - return 0; > -} > - > -/** > - * xuartps_resume - Resume after a previous suspend > - * @pdev: Pointer to the platform device structure > - * > - * Returns 0 > - **/ > -static int xuartps_resume(struct platform_device *pdev) > -{ > - uart_resume_port(&xuartps_uart_driver, &xuartps_port[pdev->id]); > - return 0; > -} > - > /* Match table for of_platform binding */ > static struct of_device_id xuartps_of_match[] = { > { .compatible = "xlnx,xuartps", }, > @@ -1044,8 +1016,6 @@ MODULE_DEVICE_TABLE(of, xuartps_of_match); > static struct platform_driver xuartps_platform_driver = { > .probe = xuartps_probe, /* Probe method */ > .remove = xuartps_remove, /* Detach method */ > - .suspend = xuartps_suspend, /* Suspend */ > - .resume = xuartps_resume, /* Resume after a suspend */ > .driver = { > .owner = THIS_MODULE, > .name = XUARTPS_NAME, /* Driver name */ >
On Fri, May 17, 2013 at 02:09:38PM +0200, Michal Simek wrote: > Hi Greg, > > can you please add this patch to your tree? > It is unrelated to clk changes which Soren sent. Ok, will do. greg k-h
diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 4e5c778..b5f655d 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1006,34 +1006,6 @@ static int xuartps_remove(struct platform_device *pdev) return rc; } -/** - * xuartps_suspend - suspend event - * @pdev: Pointer to the platform device structure - * @state: State of the device - * - * Returns 0 - **/ -static int xuartps_suspend(struct platform_device *pdev, pm_message_t state) -{ - /* Call the API provided in serial_core.c file which handles - * the suspend. - */ - uart_suspend_port(&xuartps_uart_driver, &xuartps_port[pdev->id]); - return 0; -} - -/** - * xuartps_resume - Resume after a previous suspend - * @pdev: Pointer to the platform device structure - * - * Returns 0 - **/ -static int xuartps_resume(struct platform_device *pdev) -{ - uart_resume_port(&xuartps_uart_driver, &xuartps_port[pdev->id]); - return 0; -} - /* Match table for of_platform binding */ static struct of_device_id xuartps_of_match[] = { { .compatible = "xlnx,xuartps", }, @@ -1044,8 +1016,6 @@ MODULE_DEVICE_TABLE(of, xuartps_of_match); static struct platform_driver xuartps_platform_driver = { .probe = xuartps_probe, /* Probe method */ .remove = xuartps_remove, /* Detach method */ - .suspend = xuartps_suspend, /* Suspend */ - .resume = xuartps_resume, /* Resume after a suspend */ .driver = { .owner = THIS_MODULE, .name = XUARTPS_NAME, /* Driver name */
Currently Zynq does not support suspend/resume. The driver callbacks are never used or tested, broken and using the old PM interface. Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Jiri Slaby <jslaby@suse.cz> Cc: linux-serial@vger.kernel.org --- drivers/tty/serial/xilinx_uartps.c | 30 ------------------------------ 1 file changed, 30 deletions(-)