| Message ID | 1369057116-31423-1-git-send-email-hvaibhav@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 20 May 2013, Vaibhav Hiremath wrote: > GFX has a reset status register (PRM_GFX.RM_GFX_RSTST), > so update the GFX hwmod data with .rstst_off and .st_shift > information. > > Although it doesn't have impact on kernel boot, but this is > regression fix from original hwmod commit. > Did it ever work? If not, then it's not a regression, right? - Paul
> -----Original Message----- > From: Paul Walmsley [mailto:paul@pwsan.com] > Sent: Monday, May 20, 2013 8:09 PM > To: Hiremath, Vaibhav > Cc: linux-omap@vger.kernel.org; tony@atomide.com; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH-V2] ARM: OMAP2+: AM33xx: Fix missing reset status > data to GFX hwmod > > On Mon, 20 May 2013, Vaibhav Hiremath wrote: > > > GFX has a reset status register (PRM_GFX.RM_GFX_RSTST), > > so update the GFX hwmod data with .rstst_off and .st_shift > > information. > > > > Although it doesn't have impact on kernel boot, but this is > > regression fix from original hwmod commit. > > > > Did it ever work? If not, then it's not a regression, right? > As we know none of the GFX sw is available in the mainline, so never got exercised so far; but kernel boots up fine without any issues. I was also confused a bit on this, but then thought, this could be regression As it is fixing wrong/missing data without which GFX will not work. May be I was wrong. Thanks, Vaibhav
diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c index d1cf3ab..38c7b04 100644 --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c @@ -329,7 +329,7 @@ static struct omap_hwmod_class am33xx_gfx_hwmod_class = { }; static struct omap_hwmod_rst_info am33xx_gfx_resets[] = { - { .name = "gfx", .rst_shift = 0 }, + { .name = "gfx", .rst_shift = 0, .st_shift = 0}, }; static struct omap_hwmod_irq_info am33xx_gfx_irqs[] = { @@ -347,6 +347,7 @@ static struct omap_hwmod am33xx_gfx_hwmod = { .omap4 = { .clkctrl_offs = AM33XX_CM_GFX_GFX_CLKCTRL_OFFSET, .rstctrl_offs = AM33XX_RM_GFX_RSTCTRL_OFFSET, + .rstst_offs = AM33XX_RM_GFX_RSTST_OFFSET, .modulemode = MODULEMODE_SWCTRL, }, },
GFX has a reset status register (PRM_GFX.RM_GFX_RSTST), so update the GFX hwmod data with .rstst_off and .st_shift information. Although it doesn't have impact on kernel boot, but this is regression fix from original hwmod commit. Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com> Cc: Paul Walmsley <paul@pwsan.com> Cc: Tony Lindgren <tony@atomide.com> --- Changes from V1 (No code change): - Updated commit description to mention its regression from original commit. arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) -- 1.7.0.4