| Message ID | 5199E4AF.7040607@asianux.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Maintainers: Please help check this patch whether OK, when you have time. Thanks. On 05/20/2013 04:54 PM, Chen Gang wrote: > > When randconfig with MMU for arm s5pv210 (and select all cpu type), > need let S5P_SLEEP depend on ARM_CPU_SUSPEND, or will cause issue below: > > arch/arm/plat-samsung/built-in.o: In function `s3c_cpu_resume': > arch/arm/plat-samsung/s5p-sleep.S:83: undefined reference to `cpu_resume' > > > Signed-off-by: Chen Gang <gang.chen@asianux.com> > --- > arch/arm/plat-samsung/Kconfig | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig > index f8ed2de..1d38541 100644 > --- a/arch/arm/plat-samsung/Kconfig > +++ b/arch/arm/plat-samsung/Kconfig > @@ -483,6 +483,7 @@ config S5P_PM > > config S5P_SLEEP > bool > + select ARM_CPU_SUSPEND > help > Internal config node to apply common S5P sleep management code. > Can be selected by S5P and newer SoCs with similar sleep procedure. >
Chen Gang wrote: > > Hello Maintainers: > Hi, > Please help check this patch whether OK, when you have time. > > > Thanks. > > On 05/20/2013 04:54 PM, Chen Gang wrote: > > > > When randconfig with MMU for arm s5pv210 (and select all cpu type), > > need let S5P_SLEEP depend on ARM_CPU_SUSPEND, or will cause issue below: > > > > arch/arm/plat-samsung/built-in.o: In function `s3c_cpu_resume': > > arch/arm/plat-samsung/s5p-sleep.S:83: undefined reference to > `cpu_resume' > > > > > > Signed-off-by: Chen Gang <gang.chen@asianux.com> > > --- > > arch/arm/plat-samsung/Kconfig | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat- > samsung/Kconfig > > index f8ed2de..1d38541 100644 > > --- a/arch/arm/plat-samsung/Kconfig > > +++ b/arch/arm/plat-samsung/Kconfig > > @@ -483,6 +483,7 @@ config S5P_PM > > > > config S5P_SLEEP > > bool > > + select ARM_CPU_SUSPEND Probably, + select ARM_CPU_SUSPEND if PM ? selecting the S5P_SLEEP depends on PM though... - Kukjin
On 05/27/2013 06:12 PM, Kukjin Kim wrote: >>> config S5P_SLEEP >>> > > bool >>> > > + select ARM_CPU_SUSPEND > Probably, > > + select ARM_CPU_SUSPEND if PM ? > > selecting the S5P_SLEEP depends on PM though... After reference another platform, they are really all "select ARM_CPU_SUSPEND if PM", we'd really better to follow by to let readers easy understanding. I will send patch v2. Thanks.
diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig index f8ed2de..1d38541 100644 --- a/arch/arm/plat-samsung/Kconfig +++ b/arch/arm/plat-samsung/Kconfig @@ -483,6 +483,7 @@ config S5P_PM config S5P_SLEEP bool + select ARM_CPU_SUSPEND help Internal config node to apply common S5P sleep management code. Can be selected by S5P and newer SoCs with similar sleep procedure.
When randconfig with MMU for arm s5pv210 (and select all cpu type), need let S5P_SLEEP depend on ARM_CPU_SUSPEND, or will cause issue below: arch/arm/plat-samsung/built-in.o: In function `s3c_cpu_resume': arch/arm/plat-samsung/s5p-sleep.S:83: undefined reference to `cpu_resume' Signed-off-by: Chen Gang <gang.chen@asianux.com> --- arch/arm/plat-samsung/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)