diff mbox

kvm: discard masking checking when initial MSI-X entries

Message ID 1241494915-14517-1-git-send-email-sheng@linux.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Sheng Yang May 5, 2009, 3:41 a.m. UTC 
This meant to be with commit: adcf3594f9580bdf9b5e71f271b6088b185e017e,
otherwise QEmu only counts the MSI-X entries, but won't fill it...

Signed-off-by: Sheng Yang <sheng@linux.intel.com>
---
 hw/device-assignment.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

Comments

Sheng Yang May 15, 2009, 1:59 a.m. UTC | #1 
On Tuesday 05 May 2009 11:41:55 Sheng Yang wrote:
> This meant to be with commit: adcf3594f9580bdf9b5e71f271b6088b185e017e,
> otherwise QEmu only counts the MSI-X entries, but won't fill it...
>
> Signed-off-by: Sheng Yang <sheng@linux.intel.com>
> ---
>  hw/device-assignment.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/hw/device-assignment.c b/hw/device-assignment.c
> index 0a5f850..bee0bd8 100644
> --- a/hw/device-assignment.c
> +++ b/hw/device-assignment.c
> @@ -858,8 +858,6 @@ static int assigned_dev_update_msix_mmio(PCIDevice
> *pci_dev) if (entries_nr >= msix_nr.entry_nr)
>              break;
>          memcpy(&msg_ctrl, va + i * 16 + 12, 4);
> -        if (msg_ctrl & 0x1)
> -            continue;
>          memcpy(&msg_data, va + i * 16 + 8, 4);
>          if (msg_data == 0)
>              continue;

Avi?
Avi Kivity May 18, 2009, 8:27 a.m. UTC | #2 
Sheng Yang wrote:
> This meant to be with commit: adcf3594f9580bdf9b5e71f271b6088b185e017e,
> otherwise QEmu only counts the MSI-X entries, but won't fill it...
>   

Applied, thanks.
diff mbox

Patch

diff --git a/hw/device-assignment.c b/hw/device-assignment.c
index 0a5f850..bee0bd8 100644
--- a/hw/device-assignment.c
+++ b/hw/device-assignment.c
@@ -858,8 +858,6 @@  static int assigned_dev_update_msix_mmio(PCIDevice *pci_dev)
         if (entries_nr >= msix_nr.entry_nr)
             break;
         memcpy(&msg_ctrl, va + i * 16 + 12, 4);
-        if (msg_ctrl & 0x1)
-            continue;
         memcpy(&msg_data, va + i * 16 + 8, 4);
         if (msg_data == 0)
             continue;