| Message ID | 51A66A3F.4040707@inktank.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Alex Elder <elder@inktank.com> wrote: >If an osd client response message arrives that has a front section >that's too big for the buffer set aside to receive it, a warning >gets reported and a new buffer is allocated. > >The warning says nothing about which connection had the problem. >Add the peer type and number to what gets reported, to be a bit more >informative. > >Signed-off-by: Alex Elder <elder@inktank.com> >--- > net/ceph/osd_client.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c >index e0abb83..61147fe 100644 >--- a/net/ceph/osd_client.c >+++ b/net/ceph/osd_client.c >@@ -2454,8 +2454,10 @@ static struct ceph_msg *get_reply(struct >ceph_connection *con, > ceph_msg_revoke_incoming(req->r_reply); > > if (front > req->r_reply->front.iov_len) { >- pr_warning("get_reply front %d > preallocated %d\n", >- front, (int)req->r_reply->front.iov_len); >+ pr_warning("get_reply front %d > preallocated %d (%u#%llu)\n", >+ front, (int)req->r_reply->front.iov_len, >+ (unsigned int)con->peer_name.type, >+ le64_to_cpu(con->peer_name.num)); > m = ceph_msg_new(CEPH_MSG_OSD_OPREPLY, front, GFP_NOFS, false); > if (!m) > goto out; Reviewed-by: Josh Durgin <josh.durgin@inktank.com> -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c index e0abb83..61147fe 100644 --- a/net/ceph/osd_client.c +++ b/net/ceph/osd_client.c @@ -2454,8 +2454,10 @@ static struct ceph_msg *get_reply(struct ceph_connection *con, ceph_msg_revoke_incoming(req->r_reply); if (front > req->r_reply->front.iov_len) { - pr_warning("get_reply front %d > preallocated %d\n", - front, (int)req->r_reply->front.iov_len); + pr_warning("get_reply front %d > preallocated %d (%u#%llu)\n", + front, (int)req->r_reply->front.iov_len, + (unsigned int)con->peer_name.type, + le64_to_cpu(con->peer_name.num)); m = ceph_msg_new(CEPH_MSG_OSD_OPREPLY, front, GFP_NOFS, false); if (!m)
If an osd client response message arrives that has a front section that's too big for the buffer set aside to receive it, a warning gets reported and a new buffer is allocated. The warning says nothing about which connection had the problem. Add the peer type and number to what gets reported, to be a bit more informative. Signed-off-by: Alex Elder <elder@inktank.com> --- net/ceph/osd_client.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) goto out;