| Message ID | 1367788390-29835-2-git-send-email-dh.herrmann@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
On Sun, 5 May 2013, David Herrmann wrote: > The hid-wiimote driver supports more than the Wii Remote. Nintendo > produced many devices based on the Wii Remote, which have extension > devices built-in. It is not clear to many users, that these devices have > anything in common with the Wii Remote, so fix the driver description. > > This also updates the copyright information for the coming hotplugging > rework. I have now applied the whole patchset, with these two exceptions: 1) [RFC 24/26] HID: wiimote: support Nintendo Wii U Pro Controller - It's not completely clear to me whether you have reached conclusion with Todd on this one or not 2) [RFC 26/26] HID/ALSA: wiimote: add speaker support - It'd be nice to get Ack from sound people on this one. Thanks a lot, David. Good work.
Hi Jiri On Mon, Jun 3, 2013 at 11:19 AM, Jiri Kosina <jkosina@suse.cz> wrote: > On Sun, 5 May 2013, David Herrmann wrote: > >> The hid-wiimote driver supports more than the Wii Remote. Nintendo >> produced many devices based on the Wii Remote, which have extension >> devices built-in. It is not clear to many users, that these devices have >> anything in common with the Wii Remote, so fix the driver description. >> >> This also updates the copyright information for the coming hotplugging >> rework. > > I have now applied the whole patchset, with these two exceptions: > > 1) [RFC 24/26] HID: wiimote: support Nintendo Wii U Pro Controller > > - It's not completely clear to me whether you have reached conclusion > with Todd on this one or not No, I am still working on this. I will resend the patch plus some Documentation when I'm done. > 2) [RFC 26/26] HID/ALSA: wiimote: add speaker support > > - It'd be nice to get Ack from sound people on this one. Yeah, sure. That one is still under construction. I got ADPCM working now and will try to get some review from alsa-devel. > Thanks a lot, David. Good work. Thanks for reviewing! I checked your tree and all patches (including the fixups) are applied as required. Thanks! Cheers David -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 613083a..e05dda3 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -696,13 +696,29 @@ config HID_WACOM Support for Wacom Graphire Bluetooth and Intuos4 WL tablets. config HID_WIIMOTE - tristate "Nintendo Wii Remote support" + tristate "Nintendo Wii / Wii U peripherals" depends on HID depends on LEDS_CLASS select POWER_SUPPLY select INPUT_FF_MEMLESS ---help--- - Support for the Nintendo Wii Remote bluetooth device. + Support for Nintendo Wii and Wii U Bluetooth peripherals. Supported + devices are the Wii Remote and its extension devices, but also devices + based on the Wii Remote like the Wii U Pro Controller or the + Wii Balance Board. + + Support for all official Nintendo extensions is available, however, 3rd + party extensions might not be supported. Please report these devices to: + http://github.com/dvdhrm/xwiimote/issues + + Other Nintendo Wii U peripherals that are IEEE 802.11 based (including + the Wii U Gamepad) might be supported in the future. But currently + support is limited to Bluetooth based devices. + + If unsure, say N. + + To compile this driver as a module, choose M here: the + module will be called hid-wiimote. config HID_WIIMOTE_EXT bool "Nintendo Wii Remote Extension support" diff --git a/drivers/hid/hid-wiimote-core.c b/drivers/hid/hid-wiimote-core.c index e5ee1f2..119dc56 100644 --- a/drivers/hid/hid-wiimote-core.c +++ b/drivers/hid/hid-wiimote-core.c @@ -1,6 +1,6 @@ /* - * HID driver for Nintendo Wiimote devices - * Copyright (c) 2011 David Herrmann + * HID driver for Nintendo Wii / Wii U peripherals + * Copyright (c) 2011-2013 David Herrmann <dh.herrmann@gmail.com> */ /* @@ -1331,4 +1331,4 @@ module_hid_driver(wiimote_hid_driver); MODULE_LICENSE("GPL"); MODULE_AUTHOR("David Herrmann <dh.herrmann@gmail.com>"); -MODULE_DESCRIPTION(WIIMOTE_NAME " Device Driver"); +MODULE_DESCRIPTION("Driver for Nintendo Wii / Wii U peripherals"); diff --git a/drivers/hid/hid-wiimote-debug.c b/drivers/hid/hid-wiimote-debug.c index 90124ff..fdd30dd 100644 --- a/drivers/hid/hid-wiimote-debug.c +++ b/drivers/hid/hid-wiimote-debug.c @@ -1,6 +1,6 @@ /* - * Debug support for HID Nintendo Wiimote devices - * Copyright (c) 2011 David Herrmann + * Debug support for HID Nintendo Wii / Wii U peripherals + * Copyright (c) 2011-2013 David Herrmann <dh.herrmann@gmail.com> */ /* diff --git a/drivers/hid/hid-wiimote-ext.c b/drivers/hid/hid-wiimote-ext.c index 0472191..1c104fc 100644 --- a/drivers/hid/hid-wiimote-ext.c +++ b/drivers/hid/hid-wiimote-ext.c @@ -1,6 +1,6 @@ /* - * HID driver for Nintendo Wiimote extension devices - * Copyright (c) 2011 David Herrmann + * HID driver for Nintendo Wii / Wii U peripheral extensions + * Copyright (c) 2011-2013 David Herrmann <dh.herrmann@gmail.com> */ /* diff --git a/drivers/hid/hid-wiimote.h b/drivers/hid/hid-wiimote.h index c81dbeb..a2629ed 100644 --- a/drivers/hid/hid-wiimote.h +++ b/drivers/hid/hid-wiimote.h @@ -2,8 +2,8 @@ #define __HID_WIIMOTE_H /* - * HID driver for Nintendo Wiimote devices - * Copyright (c) 2011 David Herrmann + * HID driver for Nintendo Wii / Wii U peripherals + * Copyright (c) 2011-2013 David Herrmann <dh.herrmann@gmail.com> */ /*
The hid-wiimote driver supports more than the Wii Remote. Nintendo produced many devices based on the Wii Remote, which have extension devices built-in. It is not clear to many users, that these devices have anything in common with the Wii Remote, so fix the driver description. This also updates the copyright information for the coming hotplugging rework. Signed-off-by: David Herrmann <dh.herrmann@gmail.com> --- drivers/hid/Kconfig | 20 ++++++++++++++++++-- drivers/hid/hid-wiimote-core.c | 6 +++--- drivers/hid/hid-wiimote-debug.c | 4 ++-- drivers/hid/hid-wiimote-ext.c | 4 ++-- drivers/hid/hid-wiimote.h | 4 ++-- 5 files changed, 27 insertions(+), 11 deletions(-)