diff mbox

[2/2] xen: remove bm_rld_set of xen_processor_flags

Message ID 1370333128-11412-2-git-send-email-lig.fnst@cn.fujitsu.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

li guang June 4, 2013, 8:05 a.m. UTC
bm_rld_set seems obsolete now

Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
---
 include/xen/interface/platform.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Comments

Jan Beulich June 4, 2013, 8:13 a.m. UTC | #1
>>> On 04.06.13 at 10:05, liguang <lig.fnst@cn.fujitsu.com> wrote:
> bm_rld_set seems obsolete now
> 
> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> ---
>  include/xen/interface/platform.h |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/include/xen/interface/platform.h 
> b/include/xen/interface/platform.h
> index c57d5f6..7ffff33 100644
> --- a/include/xen/interface/platform.h
> +++ b/include/xen/interface/platform.h
> @@ -240,7 +240,6 @@ struct xen_processor_flags {
>  	uint32_t bm_check:1;
>  	uint32_t has_cst:1;
>  	uint32_t power_setup_done:1;
> -	uint32_t bm_rld_set:1;
>  };
>  
>  struct xen_processor_power {

Any such patch would need to be submitted against the master copy
of the header (in the Xen repo), and by recognizing that you'd also
notice that this is part of a public ABI, and hence can't be removed,
but at best can be documented as obsolete. Of course you'd first
need to check whether the hypervisor makes any use of that bit
when passed down from Dom0.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
li guang June 4, 2013, 8:19 a.m. UTC | #2
? 2013-06-04?? 09:13 +0100?Jan Beulich???
> >>> On 04.06.13 at 10:05, liguang <lig.fnst@cn.fujitsu.com> wrote:
> > bm_rld_set seems obsolete now
> > 
> > Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
> > ---
> >  include/xen/interface/platform.h |    1 -
> >  1 files changed, 0 insertions(+), 1 deletions(-)
> > 
> > diff --git a/include/xen/interface/platform.h 
> > b/include/xen/interface/platform.h
> > index c57d5f6..7ffff33 100644
> > --- a/include/xen/interface/platform.h
> > +++ b/include/xen/interface/platform.h
> > @@ -240,7 +240,6 @@ struct xen_processor_flags {
> >  	uint32_t bm_check:1;
> >  	uint32_t has_cst:1;
> >  	uint32_t power_setup_done:1;
> > -	uint32_t bm_rld_set:1;
> >  };
> >  
> >  struct xen_processor_power {
> 
> Any such patch would need to be submitted against the master copy
> of the header (in the Xen repo), and by recognizing that you'd also
> notice that this is part of a public ABI, and hence can't be removed,
> but at best can be documented as obsolete. Of course you'd first
> need to check whether the hypervisor makes any use of that bit
> when passed down from Dom0.
> 

Right, this patch mostly likes a reminder,
hoping someone will try it and verify it's fail or OK,
since I can't test this for now.

Sorry and Thanks!


--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/xen/interface/platform.h b/include/xen/interface/platform.h
index c57d5f6..7ffff33 100644
--- a/include/xen/interface/platform.h
+++ b/include/xen/interface/platform.h
@@ -240,7 +240,6 @@  struct xen_processor_flags {
 	uint32_t bm_check:1;
 	uint32_t has_cst:1;
 	uint32_t power_setup_done:1;
-	uint32_t bm_rld_set:1;
 };
 
 struct xen_processor_power {