| Message ID | 1369394707-13049-1-git-send-email-sachin.kamat@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 24 May 2013 16:55, Sachin Kamat <sachin.kamat@linaro.org> wrote: > After the switch to devm_* functions, the 'remove' function does > not do anything. Delete it. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > Cc: Kuninori Morimoto <morimoto.kuninori@renesas.com> > --- > drivers/media/i2c/soc_camera/mt9t112.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/media/i2c/soc_camera/mt9t112.c b/drivers/media/i2c/soc_camera/mt9t112.c > index a7256b7..0af29a4 100644 > --- a/drivers/media/i2c/soc_camera/mt9t112.c > +++ b/drivers/media/i2c/soc_camera/mt9t112.c > @@ -1118,11 +1118,6 @@ static int mt9t112_probe(struct i2c_client *client, > return ret; > } > > -static int mt9t112_remove(struct i2c_client *client) > -{ > - return 0; > -} > - > static const struct i2c_device_id mt9t112_id[] = { > { "mt9t112", 0 }, > { } > @@ -1134,7 +1129,6 @@ static struct i2c_driver mt9t112_i2c_driver = { > .name = "mt9t112", > }, > .probe = mt9t112_probe, > - .remove = mt9t112_remove, > .id_table = mt9t112_id, > }; > > -- > 1.7.9.5 > Gentle ping on this series :)
Hi Sachin On Tue, 4 Jun 2013, Sachin Kamat wrote: > On 24 May 2013 16:55, Sachin Kamat <sachin.kamat@linaro.org> wrote: > > After the switch to devm_* functions, the 'remove' function does > > not do anything. Delete it. > > > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > > Cc: Kuninori Morimoto <morimoto.kuninori@renesas.com> > > --- > > drivers/media/i2c/soc_camera/mt9t112.c | 6 ------ > > 1 file changed, 6 deletions(-) [snip] > Gentle ping on this series :) Both these patches are in my queue for 3.11. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 5 June 2013 15:32, Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote: > Hi Sachin > > On Tue, 4 Jun 2013, Sachin Kamat wrote: > >> On 24 May 2013 16:55, Sachin Kamat <sachin.kamat@linaro.org> wrote: >> > After the switch to devm_* functions, the 'remove' function does >> > not do anything. Delete it. >> > >> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >> > Cc: Kuninori Morimoto <morimoto.kuninori@renesas.com> >> > --- >> > drivers/media/i2c/soc_camera/mt9t112.c | 6 ------ >> > 1 file changed, 6 deletions(-) > > [snip] > >> Gentle ping on this series :) > > Both these patches are in my queue for 3.11. Thanks Guennadi.
diff --git a/drivers/media/i2c/soc_camera/mt9t112.c b/drivers/media/i2c/soc_camera/mt9t112.c index a7256b7..0af29a4 100644 --- a/drivers/media/i2c/soc_camera/mt9t112.c +++ b/drivers/media/i2c/soc_camera/mt9t112.c @@ -1118,11 +1118,6 @@ static int mt9t112_probe(struct i2c_client *client, return ret; } -static int mt9t112_remove(struct i2c_client *client) -{ - return 0; -} - static const struct i2c_device_id mt9t112_id[] = { { "mt9t112", 0 }, { } @@ -1134,7 +1129,6 @@ static struct i2c_driver mt9t112_i2c_driver = { .name = "mt9t112", }, .probe = mt9t112_probe, - .remove = mt9t112_remove, .id_table = mt9t112_id, };
After the switch to devm_* functions, the 'remove' function does not do anything. Delete it. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Cc: Kuninori Morimoto <morimoto.kuninori@renesas.com> --- drivers/media/i2c/soc_camera/mt9t112.c | 6 ------ 1 file changed, 6 deletions(-)