diff mbox

[06/13] serial: samsung: add support for Exynos5420

Message ID 1370516488-25860-6-git-send-email-chander.kashyap@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Chander Kashyap June 6, 2013, 11:01 a.m. UTC
The serial port used in Exynos5420 is similar to the serial ports used
in the other Exynos SoC. Hence, extend the serial driver support for
Exynos5420.

Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
---
 drivers/tty/serial/samsung.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

girishks2000@gmail.com June 6, 2013, 11:35 a.m. UTC | #1
On Thu, Jun 6, 2013 at 4:31 PM, Chander Kashyap
<chander.kashyap@linaro.org> wrote:
> The serial port used in Exynos5420 is similar to the serial ports used
> in the other Exynos SoC. Hence, extend the serial driver support for
> Exynos5420.
>
> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
> ---
>  drivers/tty/serial/samsung.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> index 3cda4ed..841221c 100644
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -1716,7 +1716,7 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = {
>
>  #if defined(CONFIG_CPU_EXYNOS4210) || defined(CONFIG_SOC_EXYNOS4212) || \
>         defined(CONFIG_SOC_EXYNOS4412) || defined(CONFIG_SOC_EXYNOS5250) || \
> -       defined(CONFIG_SOC_EXYNOS5440)
> +       defined(CONFIG_SOC_EXYNOS5420) || defined(CONFIG_SOC_EXYNOS5440)

Instead of comparing all CONFIGS of the SOC of exynos series, it can
be optimized with #if defined(CONFIG_ARCH_EXYNOS)
Make sure to test on all the boards for functionality.

>  static struct s3c24xx_serial_drv_data exynos4210_serial_drv_data = {
>         .info = &(struct s3c24xx_uart_info) {
>                 .name           = "Samsung Exynos4 UART",
> --
> 1.7.9.5
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Chander Kashyap June 10, 2013, 9:05 a.m. UTC | #2
Hi,

On 6 June 2013 17:05, Girish KS <girishks2000@gmail.com> wrote:
> On Thu, Jun 6, 2013 at 4:31 PM, Chander Kashyap
> <chander.kashyap@linaro.org> wrote:
>> The serial port used in Exynos5420 is similar to the serial ports used
>> in the other Exynos SoC. Hence, extend the serial driver support for
>> Exynos5420.
>>
>> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
>> ---
>>  drivers/tty/serial/samsung.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
>> index 3cda4ed..841221c 100644
>> --- a/drivers/tty/serial/samsung.c
>> +++ b/drivers/tty/serial/samsung.c
>> @@ -1716,7 +1716,7 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = {
>>
>>  #if defined(CONFIG_CPU_EXYNOS4210) || defined(CONFIG_SOC_EXYNOS4212) || \
>>         defined(CONFIG_SOC_EXYNOS4412) || defined(CONFIG_SOC_EXYNOS5250) || \
>> -       defined(CONFIG_SOC_EXYNOS5440)
>> +       defined(CONFIG_SOC_EXYNOS5420) || defined(CONFIG_SOC_EXYNOS5440)
>
> Instead of comparing all CONFIGS of the SOC of exynos series, it can
> be optimized with #if defined(CONFIG_ARCH_EXYNOS)
> Make sure to test on all the boards for functionality.

Yes all belongs to Exynos family. Will change that and test.
>
>>  static struct s3c24xx_serial_drv_data exynos4210_serial_drv_data = {
>>         .info = &(struct s3c24xx_uart_info) {
>>                 .name           = "Samsung Exynos4 UART",
>> --
>> 1.7.9.5
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



--
with warm regards,
Chander Kashyap
diff mbox

Patch

diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
index 3cda4ed..841221c 100644
--- a/drivers/tty/serial/samsung.c
+++ b/drivers/tty/serial/samsung.c
@@ -1716,7 +1716,7 @@  static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = {
 
 #if defined(CONFIG_CPU_EXYNOS4210) || defined(CONFIG_SOC_EXYNOS4212) || \
 	defined(CONFIG_SOC_EXYNOS4412) || defined(CONFIG_SOC_EXYNOS5250) || \
-	defined(CONFIG_SOC_EXYNOS5440)
+	defined(CONFIG_SOC_EXYNOS5420) || defined(CONFIG_SOC_EXYNOS5440)
 static struct s3c24xx_serial_drv_data exynos4210_serial_drv_data = {
 	.info = &(struct s3c24xx_uart_info) {
 		.name		= "Samsung Exynos4 UART",