| Message ID | 1371536962-13322-5-git-send-email-chander.kashyap@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jun 18, 2013 at 11:59 AM, Chander Kashyap <chander.kashyap@linaro.org> wrote: > All Exynos4/5 SoCs share a common driver data in the samsung serial > driver. Hence, let the driver data inclusion be based on ARCH_EXYNOS > instead of SOC specific definition. > > Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org> > Reviewed-by: Tomasz Figa <t.figa@samsung.com> > --- > drivers/tty/serial/samsung.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c > index 2552c7f..e70d19a 100644 > --- a/drivers/tty/serial/samsung.c > +++ b/drivers/tty/serial/samsung.c > @@ -1703,9 +1703,7 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = { > #define S5PV210_SERIAL_DRV_DATA (kernel_ulong_t)NULL > #endif > > -#if defined(CONFIG_CPU_EXYNOS4210) || defined(CONFIG_SOC_EXYNOS4212) || \ > - defined(CONFIG_SOC_EXYNOS4412) || defined(CONFIG_SOC_EXYNOS5250) || \ > - defined(CONFIG_SOC_EXYNOS5440) > +#if defined(CONFIG_ARCH_EXYNOS) > static struct s3c24xx_serial_drv_data exynos4210_serial_drv_data = { > .info = &(struct s3c24xx_uart_info) { > .name = "Samsung Exynos4 UART", Looks good to me Reviewed by: Girish K S <ks.giri@samsung.com> > -- > 1.7.9.5 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On 18 June 2013 12:20, Girish KS <girishks2000@gmail.com> wrote: > On Tue, Jun 18, 2013 at 11:59 AM, Chander Kashyap > <chander.kashyap@linaro.org> wrote: >> All Exynos4/5 SoCs share a common driver data in the samsung serial >> driver. Hence, let the driver data inclusion be based on ARCH_EXYNOS >> instead of SOC specific definition. >> >> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org> >> Reviewed-by: Tomasz Figa <t.figa@samsung.com> >> --- >> drivers/tty/serial/samsung.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c >> index 2552c7f..e70d19a 100644 >> --- a/drivers/tty/serial/samsung.c >> +++ b/drivers/tty/serial/samsung.c >> @@ -1703,9 +1703,7 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = { >> #define S5PV210_SERIAL_DRV_DATA (kernel_ulong_t)NULL >> #endif >> >> -#if defined(CONFIG_CPU_EXYNOS4210) || defined(CONFIG_SOC_EXYNOS4212) || \ >> - defined(CONFIG_SOC_EXYNOS4412) || defined(CONFIG_SOC_EXYNOS5250) || \ >> - defined(CONFIG_SOC_EXYNOS5440) >> +#if defined(CONFIG_ARCH_EXYNOS) >> static struct s3c24xx_serial_drv_data exynos4210_serial_drv_data = { >> .info = &(struct s3c24xx_uart_info) { >> .name = "Samsung Exynos4 UART", > Looks good to me > Reviewed by: Girish K S <ks.giri@samsung.com> Thanks Girish >> -- >> 1.7.9.5 >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- with warm regards, Chander Kashyap
diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c index 2552c7f..e70d19a 100644 --- a/drivers/tty/serial/samsung.c +++ b/drivers/tty/serial/samsung.c @@ -1703,9 +1703,7 @@ static struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = { #define S5PV210_SERIAL_DRV_DATA (kernel_ulong_t)NULL #endif -#if defined(CONFIG_CPU_EXYNOS4210) || defined(CONFIG_SOC_EXYNOS4212) || \ - defined(CONFIG_SOC_EXYNOS4412) || defined(CONFIG_SOC_EXYNOS5250) || \ - defined(CONFIG_SOC_EXYNOS5440) +#if defined(CONFIG_ARCH_EXYNOS) static struct s3c24xx_serial_drv_data exynos4210_serial_drv_data = { .info = &(struct s3c24xx_uart_info) { .name = "Samsung Exynos4 UART",