| Message ID | 1371631969-10076-2-git-send-email-arun.kk@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 19 June 2013 14:22, Arun Kumar K <arun.kk@samsung.com> wrote: > The patch adds MFC nodes for exynos 5420 and for > smdk 5420 board. > > Signed-off-by: Arun Kumar K <arun.kk@samsung.com> > --- > arch/arm/boot/dts/exynos5420-smdk5420.dts | 5 +++++ > arch/arm/boot/dts/exynos5420.dtsi | 8 ++++++++ > 2 files changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts > index 08607df..682532c 100644 > --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts > +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts > @@ -30,4 +30,9 @@ > clock-frequency = <24000000>; > }; > }; > + > + codec@11000000 { > + samsung,mfc-r = <0x43000000 0x800000>; > + samsung,mfc-l = <0x51000000 0x800000>; > + }; > }; > diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi > index 8474d63..cb74356 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -100,4 +100,12 @@ > clocks = <&clock 260>, <&clock 131>; > clock-names = "uart", "clk_uart_baud0"; > }; > + > + codec@11000000 { > + compatible = "samsung,mfc-v7"; > + reg = <0x11000000 0x10000>; > + interrupts = <0 96 0>; > + clocks = <&clock 401>; > + clock-names = "mfc"; > + }; I think it is better if we disable the IPs in dtsi file and enbale them in respective board files as was followed for Exynos4.
Hi Arun, Sachin, On Wednesday 19 of June 2013 14:54:01 Sachin Kamat wrote: > On 19 June 2013 14:22, Arun Kumar K <arun.kk@samsung.com> wrote: > > The patch adds MFC nodes for exynos 5420 and for > > smdk 5420 board. > > > > Signed-off-by: Arun Kumar K <arun.kk@samsung.com> > > --- > > > > arch/arm/boot/dts/exynos5420-smdk5420.dts | 5 +++++ > > arch/arm/boot/dts/exynos5420.dtsi | 8 ++++++++ > > 2 files changed, 13 insertions(+) > > > > diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts > > b/arch/arm/boot/dts/exynos5420-smdk5420.dts index 08607df..682532c 100644 > > --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts > > +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts > > @@ -30,4 +30,9 @@ > > > > clock-frequency = <24000000>; > > > > }; > > > > }; > > > > + > > + codec@11000000 { > > + samsung,mfc-r = <0x43000000 0x800000>; > > + samsung,mfc-l = <0x51000000 0x800000>; > > + }; > > > > }; > > > > diff --git a/arch/arm/boot/dts/exynos5420.dtsi > > b/arch/arm/boot/dts/exynos5420.dtsi index 8474d63..cb74356 100644 > > --- a/arch/arm/boot/dts/exynos5420.dtsi > > +++ b/arch/arm/boot/dts/exynos5420.dtsi > > @@ -100,4 +100,12 @@ > > > > clocks = <&clock 260>, <&clock 131>; > > clock-names = "uart", "clk_uart_baud0"; > > > > }; > > > > + > > + codec@11000000 { > > + compatible = "samsung,mfc-v7"; > > + reg = <0x11000000 0x10000>; > > + interrupts = <0 96 0>; > > + clocks = <&clock 401>; > > + clock-names = "mfc"; > > + }; > > I think it is better if we disable the IPs in dtsi file and enbale > them in respective board files as was followed for Exynos4. +1 Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Sachin, On Wed, Jun 19, 2013 at 2:54 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote: > On 19 June 2013 14:22, Arun Kumar K <arun.kk@samsung.com> wrote: >> The patch adds MFC nodes for exynos 5420 and for >> smdk 5420 board. >> >> Signed-off-by: Arun Kumar K <arun.kk@samsung.com> >> --- >> arch/arm/boot/dts/exynos5420-smdk5420.dts | 5 +++++ >> arch/arm/boot/dts/exynos5420.dtsi | 8 ++++++++ >> 2 files changed, 13 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts >> index 08607df..682532c 100644 >> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts >> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts >> @@ -30,4 +30,9 @@ >> clock-frequency = <24000000>; >> }; >> }; >> + >> + codec@11000000 { >> + samsung,mfc-r = <0x43000000 0x800000>; >> + samsung,mfc-l = <0x51000000 0x800000>; >> + }; >> }; >> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi >> index 8474d63..cb74356 100644 >> --- a/arch/arm/boot/dts/exynos5420.dtsi >> +++ b/arch/arm/boot/dts/exynos5420.dtsi >> @@ -100,4 +100,12 @@ >> clocks = <&clock 260>, <&clock 131>; >> clock-names = "uart", "clk_uart_baud0"; >> }; >> + >> + codec@11000000 { >> + compatible = "samsung,mfc-v7"; >> + reg = <0x11000000 0x10000>; >> + interrupts = <0 96 0>; >> + clocks = <&clock 401>; >> + clock-names = "mfc"; >> + }; > > I think it is better if we disable the IPs in dtsi file and enbale > them in respective board files as was followed for Exynos4. > Right. Will change it. Regards Arun -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 19 June 2013 14:22, Arun Kumar K <arun.kk@samsung.com> wrote: > The patch adds MFC nodes for exynos 5420 and for > smdk 5420 board. > > Signed-off-by: Arun Kumar K <arun.kk@samsung.com> > --- > arch/arm/boot/dts/exynos5420-smdk5420.dts | 5 +++++ > arch/arm/boot/dts/exynos5420.dtsi | 8 ++++++++ > 2 files changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts > index 08607df..682532c 100644 > --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts > +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts > @@ -30,4 +30,9 @@ > clock-frequency = <24000000>; > }; > }; > + > + codec@11000000 { > + samsung,mfc-r = <0x43000000 0x800000>; > + samsung,mfc-l = <0x51000000 0x800000>; > + }; > }; > diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi > index 8474d63..cb74356 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -100,4 +100,12 @@ > clocks = <&clock 260>, <&clock 131>; > clock-names = "uart", "clk_uart_baud0"; > }; > + > + codec@11000000 { > + compatible = "samsung,mfc-v7"; > + reg = <0x11000000 0x10000>; > + interrupts = <0 96 0>; > + clocks = <&clock 401>; > + clock-names = "mfc"; > + }; Is it not possible to move the common part of this node to common exynos5.dtsi? As exynos5250 is using same property values. > }; > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- with warm regards, Chander Kashyap -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Chander, On Wed, Jun 19, 2013 at 5:34 PM, Chander Kashyap <chander.kashyap@linaro.org> wrote: > On 19 June 2013 14:22, Arun Kumar K <arun.kk@samsung.com> wrote: >> The patch adds MFC nodes for exynos 5420 and for >> smdk 5420 board. >> >> Signed-off-by: Arun Kumar K <arun.kk@samsung.com> >> --- >> arch/arm/boot/dts/exynos5420-smdk5420.dts | 5 +++++ >> arch/arm/boot/dts/exynos5420.dtsi | 8 ++++++++ >> 2 files changed, 13 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts >> index 08607df..682532c 100644 >> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts >> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts >> @@ -30,4 +30,9 @@ >> clock-frequency = <24000000>; >> }; >> }; >> + >> + codec@11000000 { >> + samsung,mfc-r = <0x43000000 0x800000>; >> + samsung,mfc-l = <0x51000000 0x800000>; >> + }; >> }; >> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi >> index 8474d63..cb74356 100644 >> --- a/arch/arm/boot/dts/exynos5420.dtsi >> +++ b/arch/arm/boot/dts/exynos5420.dtsi >> @@ -100,4 +100,12 @@ >> clocks = <&clock 260>, <&clock 131>; >> clock-names = "uart", "clk_uart_baud0"; >> }; >> + >> + codec@11000000 { >> + compatible = "samsung,mfc-v7"; >> + reg = <0x11000000 0x10000>; >> + interrupts = <0 96 0>; >> + clocks = <&clock 401>; >> + clock-names = "mfc"; >> + }; > Is it not possible to move the common part of this node to common > exynos5.dtsi? As exynos5250 is using same property values. Yes that can be done. I have kept it separate as the IP is different and compatible is also changing. But the reg and interrupt remains same and hopefully that can be moved to common exynos5.dtsi. Regards Arun -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts index 08607df..682532c 100644 --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts @@ -30,4 +30,9 @@ clock-frequency = <24000000>; }; }; + + codec@11000000 { + samsung,mfc-r = <0x43000000 0x800000>; + samsung,mfc-l = <0x51000000 0x800000>; + }; }; diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index 8474d63..cb74356 100644 --- a/arch/arm/boot/dts/exynos5420.dtsi +++ b/arch/arm/boot/dts/exynos5420.dtsi @@ -100,4 +100,12 @@ clocks = <&clock 260>, <&clock 131>; clock-names = "uart", "clk_uart_baud0"; }; + + codec@11000000 { + compatible = "samsung,mfc-v7"; + reg = <0x11000000 0x10000>; + interrupts = <0 96 0>; + clocks = <&clock 401>; + clock-names = "mfc"; + }; };
The patch adds MFC nodes for exynos 5420 and for smdk 5420 board. Signed-off-by: Arun Kumar K <arun.kk@samsung.com> --- arch/arm/boot/dts/exynos5420-smdk5420.dts | 5 +++++ arch/arm/boot/dts/exynos5420.dtsi | 8 ++++++++ 2 files changed, 13 insertions(+)