diff mbox

[1/1] mmc: sdhci-sirf: Fix build breakage

Message ID 1371545694-31877-1-git-send-email-sachin.kamat@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Sachin Kamat June 18, 2013, 8:54 a.m. UTC
Commit 0e74823429 ("mmc: sdhci: Add size for caller in init+register")
introduced size parameter to sdhci_pltfm_init(). This driver probably
got left out during the conversion. Passing in zero as done for other
drivers to avoid the following build error:

drivers/mmc/host/sdhci-sirf.c: In function ‘sdhci_sirf_probe’:
drivers/mmc/host/sdhci-sirf.c:78:2: error: too few arguments to function
‘sdhci_pltfm_init’
  host = sdhci_pltfm_init(pdev, &sdhci_sirf_pdata);

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Christian Daudt <csd@broadcom.com>
Cc: Barry Song <Baohua.Song@csr.com>
---
Compile tested on linux-next (20130618)
---
 drivers/mmc/host/sdhci-sirf.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christian Daudt June 21, 2013, 3:46 p.m. UTC | #1
On 13-06-18 01:54 AM, Sachin Kamat wrote:
> Commit 0e74823429 ("mmc: sdhci: Add size for caller in init+register")
> introduced size parameter to sdhci_pltfm_init(). This driver probably
> got left out during the conversion. Passing in zero as done for other
> drivers to avoid the following build error:
>
> drivers/mmc/host/sdhci-sirf.c: In function ‘sdhci_sirf_probe’:
> drivers/mmc/host/sdhci-sirf.c:78:2: error: too few arguments to function
> ‘sdhci_pltfm_init’
>    host = sdhci_pltfm_init(pdev, &sdhci_sirf_pdata);
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Christian Daudt <csd@broadcom.com>
> Cc: Barry Song <Baohua.Song@csr.com>
> ---
> Compile tested on linux-next (20130618)
> ---
>   drivers/mmc/host/sdhci-sirf.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-sirf.c b/drivers/mmc/host/sdhci-sirf.c
> index 09805af..1a149eb 100644
> --- a/drivers/mmc/host/sdhci-sirf.c
> +++ b/drivers/mmc/host/sdhci-sirf.c
> @@ -75,7 +75,7 @@ static int sdhci_sirf_probe(struct platform_device *pdev)
>   		priv->gpio_cd = -EINVAL;
>   	}
>   
> -	host = sdhci_pltfm_init(pdev, &sdhci_sirf_pdata);
> +	host = sdhci_pltfm_init(pdev, &sdhci_sirf_pdata, 0);
>   	if (IS_ERR(host)) {
>   		ret = PTR_ERR(host);
>   		goto err_sdhci_pltfm_init;
Acked-by: Christian Daudt <csd@broadcom.com>

  Thanks,
    csd


--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mmc/host/sdhci-sirf.c b/drivers/mmc/host/sdhci-sirf.c
index 09805af..1a149eb 100644
--- a/drivers/mmc/host/sdhci-sirf.c
+++ b/drivers/mmc/host/sdhci-sirf.c
@@ -75,7 +75,7 @@  static int sdhci_sirf_probe(struct platform_device *pdev)
 		priv->gpio_cd = -EINVAL;
 	}
 
-	host = sdhci_pltfm_init(pdev, &sdhci_sirf_pdata);
+	host = sdhci_pltfm_init(pdev, &sdhci_sirf_pdata, 0);
 	if (IS_ERR(host)) {
 		ret = PTR_ERR(host);
 		goto err_sdhci_pltfm_init;