| Message ID | 1372412109-986-5-git-send-email-gururaja.hebbar@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Changing to Benoit's gmail id since he apparently wont access TI mail anymore. On 6/28/2013 3:05 PM, Hebbar Gururaja wrote: > Since AM33xx RTC IP has RTC_IRQWAKEEN to support Alarm Wake-up. > > Update the rtc compatible property to "ti,am3352-rtc" to enable handling > of this feature inside rtc-omap driver. > > Signed-off-by: Hebbar Gururaja <gururaja.hebbar@ti.com> > Cc: Tony Lindgren <tony@atomide.com> > Cc: Sekhar Nori <nsekhar@ti.com> > Cc: Kevin Hilman <khilman@linaro.org> > Cc: b-cousson@ti.com > --- > :100644 100644 77aa1b0... dde180a... M arch/arm/boot/dts/am33xx.dtsi > arch/arm/boot/dts/am33xx.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index 77aa1b0..dde180a 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -297,7 +297,7 @@ > }; > > rtc@44e3e000 { > - compatible = "ti,da830-rtc"; > + compatible = "ti,am3352-rtc"; compatible is a list so you can instead do: compatible = "ti,am3352-rtc", "ti,da830-rtc"; That way the dts works irrespective of driver updates. When driver supports enhanced features of hardware, they are available to the user else the basic functionality still works. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
T24gVHVlLCBKdWwgMDIsIDIwMTMgYXQgMTE6NDI6NDksIE5vcmksIFNla2hhciB3cm90ZToNCj4g Q2hhbmdpbmcgdG8gQmVub2l0J3MgZ21haWwgaWQgc2luY2UgaGUgYXBwYXJlbnRseSB3b250IGFj Y2VzcyBUSSBtYWlsDQo+IGFueW1vcmUuDQo+IA0KPiBPbiA2LzI4LzIwMTMgMzowNSBQTSwgSGVi YmFyIEd1cnVyYWphIHdyb3RlOg0KPiA+IFNpbmNlIEFNMzN4eCAgUlRDIElQIGhhcyBSVENfSVJR V0FLRUVOIHRvIHN1cHBvcnQgQWxhcm0gV2FrZS11cC4NCj4gPiANCj4gPiBVcGRhdGUgdGhlIHJ0 YyBjb21wYXRpYmxlIHByb3BlcnR5IHRvICJ0aSxhbTMzNTItcnRjIiB0byBlbmFibGUgaGFuZGxp bmcNCj4gPiBvZiB0aGlzIGZlYXR1cmUgaW5zaWRlIHJ0Yy1vbWFwIGRyaXZlci4NCj4gPiANCj4g PiBTaWduZWQtb2ZmLWJ5OiBIZWJiYXIgR3VydXJhamEgPGd1cnVyYWphLmhlYmJhckB0aS5jb20+ DQo+ID4gQ2M6IFRvbnkgTGluZGdyZW4gPHRvbnlAYXRvbWlkZS5jb20+DQo+ID4gQ2M6IFNla2hh ciBOb3JpIDxuc2VraGFyQHRpLmNvbT4NCj4gPiBDYzogS2V2aW4gSGlsbWFuIDxraGlsbWFuQGxp bmFyby5vcmc+DQo+ID4gQ2M6IGItY291c3NvbkB0aS5jb20NCj4gPiAtLS0NCj4gPiA6MTAwNjQ0 IDEwMDY0NCA3N2FhMWIwLi4uIGRkZTE4MGEuLi4gTQlhcmNoL2FybS9ib290L2R0cy9hbTMzeHgu ZHRzaQ0KPiA+ICBhcmNoL2FybS9ib290L2R0cy9hbTMzeHguZHRzaSB8ICAgIDIgKy0NCj4gPiAg MSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pDQo+ID4gDQo+ID4g ZGlmZiAtLWdpdCBhL2FyY2gvYXJtL2Jvb3QvZHRzL2FtMzN4eC5kdHNpIGIvYXJjaC9hcm0vYm9v dC9kdHMvYW0zM3h4LmR0c2kNCj4gPiBpbmRleCA3N2FhMWIwLi5kZGUxODBhIDEwMDY0NA0KPiA+ IC0tLSBhL2FyY2gvYXJtL2Jvb3QvZHRzL2FtMzN4eC5kdHNpDQo+ID4gKysrIGIvYXJjaC9hcm0v Ym9vdC9kdHMvYW0zM3h4LmR0c2kNCj4gPiBAQCAtMjk3LDcgKzI5Nyw3IEBADQo+ID4gIAkJfTsN Cj4gPiAgDQo+ID4gIAkJcnRjQDQ0ZTNlMDAwIHsNCj4gPiAtCQkJY29tcGF0aWJsZSA9ICJ0aSxk YTgzMC1ydGMiOw0KPiA+ICsJCQljb21wYXRpYmxlID0gInRpLGFtMzM1Mi1ydGMiOw0KPiANCj4g Y29tcGF0aWJsZSBpcyBhIGxpc3Qgc28geW91IGNhbiBpbnN0ZWFkIGRvOg0KPiAJDQo+IAljb21w YXRpYmxlID0gInRpLGFtMzM1Mi1ydGMiLCAidGksZGE4MzAtcnRjIjsNCj4gDQo+IFRoYXQgd2F5 IHRoZSBkdHMgd29ya3MgaXJyZXNwZWN0aXZlIG9mIGRyaXZlciB1cGRhdGVzLiBXaGVuIGRyaXZl cg0KPiBzdXBwb3J0cyBlbmhhbmNlZCBmZWF0dXJlcyBvZiBoYXJkd2FyZSwgdGhleSBhcmUgYXZh aWxhYmxlIHRvIHRoZSB1c2VyDQo+IGVsc2UgdGhlIGJhc2ljIGZ1bmN0aW9uYWxpdHkgc3RpbGwg d29ya3MuDQoNCk9rLiBJIHdpbGwgdXBkYXRlIHRoZSBzYW1lIG5vdyBpbiB2Mi4NCg0KPiANCj4g VGhhbmtzLA0KPiBTZWtoYXINCj4gDQoNCg0KUmVnYXJkcywgDQpHdXJ1cmFqYQ0K -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jul 02, 2013 at 11:42:49, Nori, Sekhar wrote: > Changing to Benoit's gmail id since he apparently wont access TI mail > anymore. > > On 6/28/2013 3:05 PM, Hebbar Gururaja wrote: > > Since AM33xx RTC IP has RTC_IRQWAKEEN to support Alarm Wake-up. > > > > Update the rtc compatible property to "ti,am3352-rtc" to enable handling > > of this feature inside rtc-omap driver. > > > > Signed-off-by: Hebbar Gururaja <gururaja.hebbar@ti.com> > > Cc: Tony Lindgren <tony@atomide.com> > > Cc: Sekhar Nori <nsekhar@ti.com> > > Cc: Kevin Hilman <khilman@linaro.org> > > Cc: b-cousson@ti.com > > --- > > :100644 100644 77aa1b0... dde180a... M arch/arm/boot/dts/am33xx.dtsi > > arch/arm/boot/dts/am33xx.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > > index 77aa1b0..dde180a 100644 > > --- a/arch/arm/boot/dts/am33xx.dtsi > > +++ b/arch/arm/boot/dts/am33xx.dtsi > > @@ -297,7 +297,7 @@ > > }; > > > > rtc@44e3e000 { > > - compatible = "ti,da830-rtc"; > > + compatible = "ti,am3352-rtc"; > > compatible is a list so you can instead do: > > compatible = "ti,am3352-rtc", "ti,da830-rtc"; I believe the order is not important here. I mean, below is also fine. Right? compatible = "ti,da830-rtc", "ti,am3352-rtc"; > > That way the dts works irrespective of driver updates. When driver > supports enhanced features of hardware, they are available to the user > else the basic functionality still works. > > Thanks, > Sekhar > Regards, Gururaja
Gururaja, On 7/2/2013 11:42 AM, Sekhar Nori wrote: > Changing to Benoit's gmail id since he apparently wont access TI mail > anymore. > > On 6/28/2013 3:05 PM, Hebbar Gururaja wrote: >> Since AM33xx RTC IP has RTC_IRQWAKEEN to support Alarm Wake-up. >> >> Update the rtc compatible property to "ti,am3352-rtc" to enable handling >> of this feature inside rtc-omap driver. >> >> Signed-off-by: Hebbar Gururaja <gururaja.hebbar@ti.com> >> Cc: Tony Lindgren <tony@atomide.com> >> Cc: Sekhar Nori <nsekhar@ti.com> >> Cc: Kevin Hilman <khilman@linaro.org> >> Cc: b-cousson@ti.com >> --- >> :100644 100644 77aa1b0... dde180a... M arch/arm/boot/dts/am33xx.dtsi >> arch/arm/boot/dts/am33xx.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi >> index 77aa1b0..dde180a 100644 >> --- a/arch/arm/boot/dts/am33xx.dtsi >> +++ b/arch/arm/boot/dts/am33xx.dtsi >> @@ -297,7 +297,7 @@ >> }; >> >> rtc@44e3e000 { >> - compatible = "ti,da830-rtc"; >> + compatible = "ti,am3352-rtc"; > > compatible is a list so you can instead do: > > compatible = "ti,am3352-rtc", "ti,da830-rtc"; > > That way the dts works irrespective of driver updates. When driver > supports enhanced features of hardware, they are available to the user > else the basic functionality still works. On doing some experiments myself, the of_device_id which gets selected during probe depends on the order in which its entry appears in the match table inside the driver rather than how the compatible string is written. I think this puts undue dependency on how the driver is written, so I am okay with providing a single compatible value like the way you have done ATM. I do think the string appearing first in the compatible list is what should be selected if a match is available but I am not sure if there are other considerations due to which of_match_device() is written the way it is written. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index 77aa1b0..dde180a 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -297,7 +297,7 @@ }; rtc@44e3e000 { - compatible = "ti,da830-rtc"; + compatible = "ti,am3352-rtc"; reg = <0x44e3e000 0x1000>; interrupts = <75 76>;
Since AM33xx RTC IP has RTC_IRQWAKEEN to support Alarm Wake-up. Update the rtc compatible property to "ti,am3352-rtc" to enable handling of this feature inside rtc-omap driver. Signed-off-by: Hebbar Gururaja <gururaja.hebbar@ti.com> Cc: Tony Lindgren <tony@atomide.com> Cc: Sekhar Nori <nsekhar@ti.com> Cc: Kevin Hilman <khilman@linaro.org> Cc: b-cousson@ti.com --- :100644 100644 77aa1b0... dde180a... M arch/arm/boot/dts/am33xx.dtsi arch/arm/boot/dts/am33xx.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)