| Message ID | 1373461739-10168-1-git-send-email-pali.rohar@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Wednesday 10 July 2013 06:38 PM, Pali Rohár wrote: > * On RX-51 probing for acx565akm driver is later then for omapfb which cause that omapfb probe fail and framebuffer is not working > * EPROBE_DEFER causing that kernel try to probe for omapfb later again which fixing this problem > > * Without this patch display on Nokia RX-51 (N900) phone not working > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> > --- > drivers/video/omap2/omapfb/omapfb-main.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c > index 856917b..93e7c84 100644 > --- a/drivers/video/omap2/omapfb/omapfb-main.c > +++ b/drivers/video/omap2/omapfb/omapfb-main.c > @@ -2419,6 +2419,15 @@ static int omapfb_probe(struct platform_device *pdev) > if (omapdss_is_initialized() == false) > return -EPROBE_DEFER; > > + dssdev = NULL; > + for_each_dss_dev(dssdev) { > + if (!dssdev->driver) { > + dev_warn(&pdev->dev, "no driver for display: %s\n", > + dssdev->name); > + return -EPROBE_DEFER; This will make omapfb probe defer till the time every panel has a driver. It's possible that all the panel driver modules are never interested by userspace. This will lead to the panels having drivers also not work. I think Tomi was working on this, it was something like making omapfb defer only if the default display doesn't have a driver. We can wait for his comment. Archit > + } > + } > + > if (pdev->num_resources != 0) { > dev_err(&pdev->dev, "probed for an unknown device\n"); > r = -ENODEV; > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed 2013-07-10 15:08:59, Pali Rohár wrote: > * On RX-51 probing for acx565akm driver is later then for omapfb which cause that omapfb probe fail and framebuffer is not working > * EPROBE_DEFER causing that kernel try to probe for omapfb later again which fixing this problem > > * Without this patch display on Nokia RX-51 (N900) phone not working > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> Tested-by: Pavel Machek <pavel@ucw.cz> (Actually, do we know which commit broke the ordering? We may want to simply revert that one...) BTW I'm currently trying to set-up automated scripts for n900/qemu testing. I guess I'll try to run them on mainline kernel to catch such stuff earlier. One thing I'd like to know: how do you configure kernel to get output on qemu? I was doing CONFIG_DEBUG_LL with specific uart, but that needed patching the kernel, you apparently have something more clever. I tried doing: # CONFIG_DEBUG_LL is not set CONFIG_DEBUG_LL_INCLUDE="mach/debug-macro.S" CONFIG_UNCOMPRESS_INCLUDE="debug/uncompress.h" but no output on console... Thanks, Pavel
Hi! > One thing I'd like to know: how do you configure kernel to get output > on qemu? I was doing CONFIG_DEBUG_LL with specific uart, but that > needed patching the kernel, you apparently have something more > clever. Aha, normal console=ttyO2 option. Got it now :-). Pavel
diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c index 856917b..93e7c84 100644 --- a/drivers/video/omap2/omapfb/omapfb-main.c +++ b/drivers/video/omap2/omapfb/omapfb-main.c @@ -2419,6 +2419,15 @@ static int omapfb_probe(struct platform_device *pdev) if (omapdss_is_initialized() == false) return -EPROBE_DEFER; + dssdev = NULL; + for_each_dss_dev(dssdev) { + if (!dssdev->driver) { + dev_warn(&pdev->dev, "no driver for display: %s\n", + dssdev->name); + return -EPROBE_DEFER; + } + } + if (pdev->num_resources != 0) { dev_err(&pdev->dev, "probed for an unknown device\n"); r = -ENODEV;
* On RX-51 probing for acx565akm driver is later then for omapfb which cause that omapfb probe fail and framebuffer is not working * EPROBE_DEFER causing that kernel try to probe for omapfb later again which fixing this problem * Without this patch display on Nokia RX-51 (N900) phone not working Signed-off-by: Pali Rohár <pali.rohar@gmail.com> --- drivers/video/omap2/omapfb/omapfb-main.c | 9 +++++++++ 1 file changed, 9 insertions(+)