| Message ID | 1373913629-32179-5-git-send-email-swarren@wwwdotorg.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/15/2013 01:40 PM, Stephen Warren wrote: > From: Stephen Warren <swarren@nvidia.com> > > This property is no longer required by the GPIO binding. Remove it. Won't this break compatibility with older kernel? It is one thing to deprecate, but removal is another. If the relevant maintainers don't care, then I guess it is fine. > Signed-off-by: Stephen Warren <swarren@nvidia.com> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > This should presumably be applied along with the previous changes The rest looks fine to me. I can take this series, but would actually prefer that this patch go separately to arm-soc. Rob > > v2: Squash spear and mxc changes into a single patch; there's no > need to keep vf610.dtsi separate now that this series will go into > v3.12 or later, and that file is part of v3.11-rc1. > --- > arch/arm/boot/dts/spear1310.dtsi | 1 - > arch/arm/boot/dts/spear1340.dtsi | 1 - > arch/arm/boot/dts/spear310.dtsi | 1 - > arch/arm/boot/dts/spear320.dtsi | 2 -- > arch/arm/boot/dts/vf610.dtsi | 1 - > 5 files changed, 6 deletions(-) > > diff --git a/arch/arm/boot/dts/spear1310.dtsi b/arch/arm/boot/dts/spear1310.dtsi > index 122ae94..90e99b5 100644 > --- a/arch/arm/boot/dts/spear1310.dtsi > +++ b/arch/arm/boot/dts/spear1310.dtsi > @@ -89,7 +89,6 @@ > pinmux: pinmux@e0700000 { > compatible = "st,spear1310-pinmux"; > reg = <0xe0700000 0x1000>; > - #gpio-range-cells = <3>; > }; > > apb { > diff --git a/arch/arm/boot/dts/spear1340.dtsi b/arch/arm/boot/dts/spear1340.dtsi > index 54d128d..5003013 100644 > --- a/arch/arm/boot/dts/spear1340.dtsi > +++ b/arch/arm/boot/dts/spear1340.dtsi > @@ -63,7 +63,6 @@ > pinmux: pinmux@e0700000 { > compatible = "st,spear1340-pinmux"; > reg = <0xe0700000 0x1000>; > - #gpio-range-cells = <3>; > }; > > pwm: pwm@e0180000 { > diff --git a/arch/arm/boot/dts/spear310.dtsi b/arch/arm/boot/dts/spear310.dtsi > index 9537208..1e1318e 100644 > --- a/arch/arm/boot/dts/spear310.dtsi > +++ b/arch/arm/boot/dts/spear310.dtsi > @@ -25,7 +25,6 @@ > pinmux: pinmux@b4000000 { > compatible = "st,spear310-pinmux"; > reg = <0xb4000000 0x1000>; > - #gpio-range-cells = <3>; > }; > > fsmc: flash@44000000 { > diff --git a/arch/arm/boot/dts/spear320.dtsi b/arch/arm/boot/dts/spear320.dtsi > index ffea342..f630d0c 100644 > --- a/arch/arm/boot/dts/spear320.dtsi > +++ b/arch/arm/boot/dts/spear320.dtsi > @@ -1,4 +1,3 @@ > -/* > * DTS file for SPEAr320 SoC > * > * Copyright 2012 Viresh Kumar <viresh.linux@gmail.com> > @@ -24,7 +23,6 @@ > pinmux: pinmux@b3000000 { > compatible = "st,spear320-pinmux"; > reg = <0xb3000000 0x1000>; > - #gpio-range-cells = <3>; > }; > > clcd@90000000 { > diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi > index e1eb7da..8577780 100644 > --- a/arch/arm/boot/dts/vf610.dtsi > +++ b/arch/arm/boot/dts/vf610.dtsi > @@ -162,7 +162,6 @@ > iomuxc: iomuxc@40048000 { > compatible = "fsl,vf610-iomuxc"; > reg = <0x40048000 0x1000>; > - #gpio-range-cells = <3>; > > /* functions and groups pins */ > >
On 07/15/2013 01:34 PM, Rob Herring wrote: > On 07/15/2013 01:40 PM, Stephen Warren wrote: >> From: Stephen Warren <swarren@nvidia.com> >> >> This property is no longer required by the GPIO binding. Remove it. > > Won't this break compatibility with older kernel? It is one thing to > deprecate, but removal is another. If the relevant maintainers don't > care, then I guess it is fine. Yes. I had originally hoped this could sneak in late for 3.11, but I suppose it's too late now. vf610.dtsi is a new file in 3.11 so has no legacy to protect. Admittedly, the #gpio-cells property was added into the SPEAr files in 3.10.
On 07/15/2013 05:02 PM, Stephen Warren wrote: > On 07/15/2013 01:34 PM, Rob Herring wrote: >> On 07/15/2013 01:40 PM, Stephen Warren wrote: >>> From: Stephen Warren <swarren@nvidia.com> >>> >>> This property is no longer required by the GPIO binding. Remove it. >> >> Won't this break compatibility with older kernel? It is one thing to >> deprecate, but removal is another. If the relevant maintainers don't >> care, then I guess it is fine. > > Yes. > > I had originally hoped this could sneak in late for 3.11, but I suppose > it's too late now. vf610.dtsi is a new file in 3.11 so has no legacy to > protect. > > Admittedly, the #gpio-cells property was added into the SPEAr files in 3.10. One more thought here: I know DT bindings are supposed to evolve so that a new kernel will support arbitrary old DTs. I'll call that backwards-compatibility for the DT parsing code. However, this situation is the reverse; this patch would prevent a new DT running on an older kernel. I'll call that forwards-compatibility. I'm not sure if the intent is to support this or not? It's certainly the first I explicitly thought about compatibility in this direction...
On Tue, Jul 16, 2013 at 6:30 PM, Stephen Warren <swarren@wwwdotorg.org> wrote: > On 07/15/2013 05:02 PM, Stephen Warren wrote: >> On 07/15/2013 01:34 PM, Rob Herring wrote: >>> On 07/15/2013 01:40 PM, Stephen Warren wrote: >>>> From: Stephen Warren <swarren@nvidia.com> >>>> >>>> This property is no longer required by the GPIO binding. Remove it. >>> >>> Won't this break compatibility with older kernel? It is one thing to >>> deprecate, but removal is another. If the relevant maintainers don't >>> care, then I guess it is fine. >> >> Yes. >> >> I had originally hoped this could sneak in late for 3.11, but I suppose >> it's too late now. vf610.dtsi is a new file in 3.11 so has no legacy to >> protect. >> >> Admittedly, the #gpio-cells property was added into the SPEAr files in 3.10. > > One more thought here: > > I know DT bindings are supposed to evolve so that a new kernel will > support arbitrary old DTs. I'll call that backwards-compatibility for > the DT parsing code. That is the more common case. > However, this situation is the reverse; this patch would prevent a new > DT running on an older kernel. I'll call that forwards-compatibility. > I'm not sure if the intent is to support this or not? It's certainly the > first I explicitly thought about compatibility in this direction... So you would be okay if your computer stopped booting a kernel after a BIOS update? It's the same deal. It's both forwards and backwards compatibility that is needed. Rob
On 07/16/2013 07:50 PM, Rob Herring wrote: > On Tue, Jul 16, 2013 at 6:30 PM, Stephen Warren <swarren@wwwdotorg.org> wrote: >> On 07/15/2013 05:02 PM, Stephen Warren wrote: >>> On 07/15/2013 01:34 PM, Rob Herring wrote: >>>> On 07/15/2013 01:40 PM, Stephen Warren wrote: >>>>> From: Stephen Warren <swarren@nvidia.com> >>>>> >>>>> This property is no longer required by the GPIO binding. Remove it. >>>> >>>> Won't this break compatibility with older kernel? It is one thing to >>>> deprecate, but removal is another. If the relevant maintainers don't >>>> care, then I guess it is fine. >>> >>> Yes. >>> >>> I had originally hoped this could sneak in late for 3.11, but I suppose >>> it's too late now. vf610.dtsi is a new file in 3.11 so has no legacy to >>> protect. >>> >>> Admittedly, the #gpio-cells property was added into the SPEAr files in 3.10. >> >> One more thought here: >> >> I know DT bindings are supposed to evolve so that a new kernel will >> support arbitrary old DTs. I'll call that backwards-compatibility for >> the DT parsing code. > > That is the more common case. > >> However, this situation is the reverse; this patch would prevent a new >> DT running on an older kernel. I'll call that forwards-compatibility. >> I'm not sure if the intent is to support this or not? It's certainly the >> first I explicitly thought about compatibility in this direction... > > So you would be okay if your computer stopped booting a kernel after a > BIOS update? It's the same deal. It's both forwards and backwards > compatibility that is needed. I would strongly hope the BIOS/bootloader/... would have nothing to do with the DT content. There's a reason that Grant asserted early on that DTBs shouldn't be part of the BIOS/bootloader, but rather stored separately, so the DTB could be updated without updating firmware, just like the kernel. And I see no real problem with a new DTB requiring a new kernel or even vice-versa to be honest.
Hi Stephen, On Monday 15 July 2013 12:40:29 Stephen Warren wrote: > From: Stephen Warren <swarren@nvidia.com> > > This property is no longer required by the GPIO binding. Remove it. > > Signed-off-by: Stephen Warren <swarren@nvidia.com> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > This should presumably be applied along with the previous changes The mach-shmobile tree includes patches for v3.12 that will add the #gpio- ranges-cells to several .dtsi files. I can get that fixed locally (most probably through a rebase), could you please ping me when this series will be accepted for upstream merge ? > v2: Squash spear and mxc changes into a single patch; there's no > need to keep vf610.dtsi separate now that this series will go into > v3.12 or later, and that file is part of v3.11-rc1. > --- > arch/arm/boot/dts/spear1310.dtsi | 1 - > arch/arm/boot/dts/spear1340.dtsi | 1 - > arch/arm/boot/dts/spear310.dtsi | 1 - > arch/arm/boot/dts/spear320.dtsi | 2 -- > arch/arm/boot/dts/vf610.dtsi | 1 - > 5 files changed, 6 deletions(-) > > diff --git a/arch/arm/boot/dts/spear1310.dtsi > b/arch/arm/boot/dts/spear1310.dtsi index 122ae94..90e99b5 100644 > --- a/arch/arm/boot/dts/spear1310.dtsi > +++ b/arch/arm/boot/dts/spear1310.dtsi > @@ -89,7 +89,6 @@ > pinmux: pinmux@e0700000 { > compatible = "st,spear1310-pinmux"; > reg = <0xe0700000 0x1000>; > - #gpio-range-cells = <3>; > }; > > apb { > diff --git a/arch/arm/boot/dts/spear1340.dtsi > b/arch/arm/boot/dts/spear1340.dtsi index 54d128d..5003013 100644 > --- a/arch/arm/boot/dts/spear1340.dtsi > +++ b/arch/arm/boot/dts/spear1340.dtsi > @@ -63,7 +63,6 @@ > pinmux: pinmux@e0700000 { > compatible = "st,spear1340-pinmux"; > reg = <0xe0700000 0x1000>; > - #gpio-range-cells = <3>; > }; > > pwm: pwm@e0180000 { > diff --git a/arch/arm/boot/dts/spear310.dtsi > b/arch/arm/boot/dts/spear310.dtsi index 9537208..1e1318e 100644 > --- a/arch/arm/boot/dts/spear310.dtsi > +++ b/arch/arm/boot/dts/spear310.dtsi > @@ -25,7 +25,6 @@ > pinmux: pinmux@b4000000 { > compatible = "st,spear310-pinmux"; > reg = <0xb4000000 0x1000>; > - #gpio-range-cells = <3>; > }; > > fsmc: flash@44000000 { > diff --git a/arch/arm/boot/dts/spear320.dtsi > b/arch/arm/boot/dts/spear320.dtsi index ffea342..f630d0c 100644 > --- a/arch/arm/boot/dts/spear320.dtsi > +++ b/arch/arm/boot/dts/spear320.dtsi > @@ -1,4 +1,3 @@ > -/* > * DTS file for SPEAr320 SoC > * > * Copyright 2012 Viresh Kumar <viresh.linux@gmail.com> > @@ -24,7 +23,6 @@ > pinmux: pinmux@b3000000 { > compatible = "st,spear320-pinmux"; > reg = <0xb3000000 0x1000>; > - #gpio-range-cells = <3>; > }; > > clcd@90000000 { > diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi > index e1eb7da..8577780 100644 > --- a/arch/arm/boot/dts/vf610.dtsi > +++ b/arch/arm/boot/dts/vf610.dtsi > @@ -162,7 +162,6 @@ > iomuxc: iomuxc@40048000 { > compatible = "fsl,vf610-iomuxc"; > reg = <0x40048000 0x1000>; > - #gpio-range-cells = <3>; > > /* functions and groups pins */
diff --git a/arch/arm/boot/dts/spear1310.dtsi b/arch/arm/boot/dts/spear1310.dtsi index 122ae94..90e99b5 100644 --- a/arch/arm/boot/dts/spear1310.dtsi +++ b/arch/arm/boot/dts/spear1310.dtsi @@ -89,7 +89,6 @@ pinmux: pinmux@e0700000 { compatible = "st,spear1310-pinmux"; reg = <0xe0700000 0x1000>; - #gpio-range-cells = <3>; }; apb { diff --git a/arch/arm/boot/dts/spear1340.dtsi b/arch/arm/boot/dts/spear1340.dtsi index 54d128d..5003013 100644 --- a/arch/arm/boot/dts/spear1340.dtsi +++ b/arch/arm/boot/dts/spear1340.dtsi @@ -63,7 +63,6 @@ pinmux: pinmux@e0700000 { compatible = "st,spear1340-pinmux"; reg = <0xe0700000 0x1000>; - #gpio-range-cells = <3>; }; pwm: pwm@e0180000 { diff --git a/arch/arm/boot/dts/spear310.dtsi b/arch/arm/boot/dts/spear310.dtsi index 9537208..1e1318e 100644 --- a/arch/arm/boot/dts/spear310.dtsi +++ b/arch/arm/boot/dts/spear310.dtsi @@ -25,7 +25,6 @@ pinmux: pinmux@b4000000 { compatible = "st,spear310-pinmux"; reg = <0xb4000000 0x1000>; - #gpio-range-cells = <3>; }; fsmc: flash@44000000 { diff --git a/arch/arm/boot/dts/spear320.dtsi b/arch/arm/boot/dts/spear320.dtsi index ffea342..f630d0c 100644 --- a/arch/arm/boot/dts/spear320.dtsi +++ b/arch/arm/boot/dts/spear320.dtsi @@ -1,4 +1,3 @@ -/* * DTS file for SPEAr320 SoC * * Copyright 2012 Viresh Kumar <viresh.linux@gmail.com> @@ -24,7 +23,6 @@ pinmux: pinmux@b3000000 { compatible = "st,spear320-pinmux"; reg = <0xb3000000 0x1000>; - #gpio-range-cells = <3>; }; clcd@90000000 { diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi index e1eb7da..8577780 100644 --- a/arch/arm/boot/dts/vf610.dtsi +++ b/arch/arm/boot/dts/vf610.dtsi @@ -162,7 +162,6 @@ iomuxc: iomuxc@40048000 { compatible = "fsl,vf610-iomuxc"; reg = <0x40048000 0x1000>; - #gpio-range-cells = <3>; /* functions and groups pins */