| Message ID | 20130214205304.923585891@linutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Feb 14, 2013 at 08:53:52PM +0000, Thomas Gleixner wrote: > PMU interrupts must not be threaded. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > --- > arch/arm/kernel/perf_event_cpu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > Index: linux-2.6/arch/arm/kernel/perf_event_cpu.c > =================================================================== > --- linux-2.6.orig/arch/arm/kernel/perf_event_cpu.c > +++ linux-2.6/arch/arm/kernel/perf_event_cpu.c > @@ -118,7 +118,8 @@ static int cpu_pmu_request_irq(struct ar > continue; > } > > - err = request_irq(irq, handler, IRQF_NOBALANCING, "arm-pmu", > + err = request_irq(irq, handler, > + IRQF_NOBALANCING | IRQF_NO_THREAD, "arm-pmu", > cpu_pmu); > if (err) { > pr_err("unable to request IRQ%d for ARM PMU counters\n", > > Yup, we certainly don't want these to be threaded! Cheers, I'll add this to my perf queue. Will
On Fri, Feb 15, 2013 at 09:51:53AM +0000, Will Deacon wrote: > Yup, we certainly don't want these to be threaded! Cheers, I'll add this to > my perf queue. I don't see this in v3.10. Is there a problem with this patch? > Will Sebastian
On Mon, Aug 12, 2013 at 08:52:55PM +0100, Sebastian Andrzej Siewior wrote: > On Fri, Feb 15, 2013 at 09:51:53AM +0000, Will Deacon wrote: > > Yup, we certainly don't want these to be threaded! Cheers, I'll add this to > > my perf queue. > > I don't see this in v3.10. Is there a problem with this patch? Nope, I was just waiting for the discussion to die down around the kconfig change in the second patch. Probably best to submit both to Russell's patch system[1], with my ack on this one: Acked-by: Will Deacon <will.deacon@arm.com> Will [1] Add a "KernelVersion: 3.11-rc5" line to the patch, then git send-email it to patches@arm.linux.org.uk.
On Tue, Aug 13, 2013 at 12:11:17PM +0100, Will Deacon wrote: > Probably best to submit both to Russell's patch system[1], with my ack on > this one: Okay, will do. Thanks. > > Will Sebastian
Index: linux-2.6/arch/arm/kernel/perf_event_cpu.c =================================================================== --- linux-2.6.orig/arch/arm/kernel/perf_event_cpu.c +++ linux-2.6/arch/arm/kernel/perf_event_cpu.c @@ -118,7 +118,8 @@ static int cpu_pmu_request_irq(struct ar continue; } - err = request_irq(irq, handler, IRQF_NOBALANCING, "arm-pmu", + err = request_irq(irq, handler, + IRQF_NOBALANCING | IRQF_NO_THREAD, "arm-pmu", cpu_pmu); if (err) { pr_err("unable to request IRQ%d for ARM PMU counters\n",
PMU interrupts must not be threaded. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> --- arch/arm/kernel/perf_event_cpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)