| Message ID | 20090526115252.3362.58985.stgit@mchn012c.ww002.siemens.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Jan, On Tue, 2009-05-26 at 13:52 +0200, Jan Kiszka wrote: > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > --- > > x86/external-module-compat.h | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/x86/external-module-compat.h b/x86/external-module-compat.h > index 3e6fc11..c33eb2e 100644 > --- a/x86/external-module-compat.h > +++ b/x86/external-module-compat.h > @@ -497,6 +497,10 @@ struct kvm_desc_ptr { > #define FEATURE_CONTROL_VMXON_ENABLED (1<<2) > #endif > > +#ifndef MSR_IA32_TSC > +#define MSR_IA32_TSC 0x00000010 > +#endif > + AFAIK, MSR_IA32_TSC is defined in include/asm/msr-index.h which is available for kernel as well as user space and it is available from long time. Can you please point me in which case MSR_IA32_TSC is not visible. Thanks, -- JSR -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Jaswinder Singh Rajput wrote: > Hello Jan, > > On Tue, 2009-05-26 at 13:52 +0200, Jan Kiszka wrote: >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> >> --- >> >> x86/external-module-compat.h | 4 ++++ >> 1 files changed, 4 insertions(+), 0 deletions(-) >> >> diff --git a/x86/external-module-compat.h b/x86/external-module-compat.h >> index 3e6fc11..c33eb2e 100644 >> --- a/x86/external-module-compat.h >> +++ b/x86/external-module-compat.h >> @@ -497,6 +497,10 @@ struct kvm_desc_ptr { >> #define FEATURE_CONTROL_VMXON_ENABLED (1<<2) >> #endif >> >> +#ifndef MSR_IA32_TSC >> +#define MSR_IA32_TSC 0x00000010 >> +#endif >> + > > AFAIK, MSR_IA32_TSC is defined in include/asm/msr-index.h which is > available for kernel as well as user space and it is available from long > time. msr-index.h is "fairly" new (keep in mind all the x86 unifications and renaming of msr.h to msr-index.h). > > Can you please point me in which case MSR_IA32_TSC is not visible. I'm about to loose overview of all those issues I ran into with older kernels (still more to fix, sigh), but I think to remember this was a 2.6.18 x86_32 problem. Wait... yes, 2.6.18 asm-i386 does not include this. Jan
Jan Kiszka wrote: > I'm about to loose overview of all those issues I ran into with older > kernels (still more to fix, sigh), but I think to remember this was a > 2.6.18 x86_32 problem. Wait... yes, 2.6.18 asm-i386 does not include this. > I have the same problem. I'll look at setting up automated build-testing of kvm-kmod.git+kvm.git for versions in range(16, 30) for arch in ['i386', 'x86_64'].
On Tue, 2009-05-26 at 14:36 +0200, Jan Kiszka wrote: > Jaswinder Singh Rajput wrote: > > Hello Jan, > > > > On Tue, 2009-05-26 at 13:52 +0200, Jan Kiszka wrote: > >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > >> --- > >> > >> x86/external-module-compat.h | 4 ++++ > >> 1 files changed, 4 insertions(+), 0 deletions(-) > >> > >> diff --git a/x86/external-module-compat.h b/x86/external-module-compat.h > >> index 3e6fc11..c33eb2e 100644 > >> --- a/x86/external-module-compat.h > >> +++ b/x86/external-module-compat.h > >> @@ -497,6 +497,10 @@ struct kvm_desc_ptr { > >> #define FEATURE_CONTROL_VMXON_ENABLED (1<<2) > >> #endif > >> > >> +#ifndef MSR_IA32_TSC > >> +#define MSR_IA32_TSC 0x00000010 > >> +#endif > >> + > > > > AFAIK, MSR_IA32_TSC is defined in include/asm/msr-index.h which is > > available for kernel as well as user space and it is available from long > > time. > > msr-index.h is "fairly" new (keep in mind all the x86 unifications and > renaming of msr.h to msr-index.h). > > > > > Can you please point me in which case MSR_IA32_TSC is not visible. > > I'm about to loose overview of all those issues I ran into with older > kernels (still more to fix, sigh), but I think to remember this was a > 2.6.18 x86_32 problem. Wait... yes, 2.6.18 asm-i386 does not include this. > Ahh, for ancient kernels. Ok :-) -- JSR -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Avi Kivity wrote: > Jan Kiszka wrote: >> I'm about to loose overview of all those issues I ran into with older >> kernels (still more to fix, sigh), but I think to remember this was a >> 2.6.18 x86_32 problem. Wait... yes, 2.6.18 asm-i386 does not include >> this. >> > > I have the same problem. I'll look at setting up automated > build-testing of kvm-kmod.git+kvm.git for versions in range(16, 30) for > arch in ['i386', 'x86_64']. Applause in advance! Jan
Jan Kiszka wrote: > Avi Kivity wrote: > >> Jan Kiszka wrote: >> >>> I'm about to loose overview of all those issues I ran into with older >>> kernels (still more to fix, sigh), but I think to remember this was a >>> 2.6.18 x86_32 problem. Wait... yes, 2.6.18 asm-i386 does not include >>> this. >>> >>> >> I have the same problem. I'll look at setting up automated >> build-testing of kvm-kmod.git+kvm.git for versions in range(16, 30) for >> arch in ['i386', 'x86_64']. >> > > Applause in advance! > Be careful, I might auto-mail you the results.
diff --git a/x86/external-module-compat.h b/x86/external-module-compat.h index 3e6fc11..c33eb2e 100644 --- a/x86/external-module-compat.h +++ b/x86/external-module-compat.h @@ -497,6 +497,10 @@ struct kvm_desc_ptr { #define FEATURE_CONTROL_VMXON_ENABLED (1<<2) #endif +#ifndef MSR_IA32_TSC +#define MSR_IA32_TSC 0x00000010 +#endif + #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,25) && defined(__x86_64__) #undef set_debugreg
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> --- x86/external-module-compat.h | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html