diff mbox

[Resend,1/3] PSCI: add missing dependency on CONFIG_OF for PSCI.

Message ID 1376500987-12797-2-git-send-email-jonathan.austin@arm.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jonathan Austin Aug. 14, 2013, 5:23 p.m. UTC
The PSCI initialisation depends on data found in the DT. Without this the
including PSCI support makes little sense, and furthermore the of_* stub
functions aren't broad enough to ensure that this builds without CONFIG_OF.

As there is little enthusiasm for extending these stubs without useful use-cases
(of which this is *not* an example) this patch prevents building of PSCI
without CONFIG_OF.

Signed-off-by: Jonathan Austin <jonathan.austin@arm.com>
---
 arch/arm/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Comments

Sergei Shtylyov Aug. 14, 2013, 7:54 p.m. UTC | #1
Hello.

On 08/14/2013 09:23 PM, Jonathan Austin wrote:

> The PSCI initialisation depends on data found in the DT. Without this the
> including PSCI support makes little sense, and furthermore the of_* stub
> functions aren't broad enough to ensure that this builds without CONFIG_OF.

> As there is little enthusiasm for extending these stubs without useful use-cases
> (of which this is *not* an example) this patch prevents building of PSCI
> without CONFIG_OF.

> Signed-off-by: Jonathan Austin <jonathan.austin@arm.com>
> ---
>   arch/arm/Kconfig |    1 +
>   1 file changed, 1 insertion(+)

> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index ba412e0..972ec25 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1577,6 +1577,7 @@ config HOTPLUG_CPU
>   config ARM_PSCI
>   	bool "Support for the ARM Power State Coordination Interface (PSCI)"
>   	depends on CPU_V7
> +	depends on CONFIG_OF

    I think you meant just OF. :-)

WBR, Sergei
Jonathan Austin Aug. 15, 2013, 1:51 p.m. UTC | #2
Hi Sergei,

On 14/08/13 20:54, Sergei Shtylyov wrote:
> Hello.
>
> On 08/14/2013 09:23 PM, Jonathan Austin wrote:
>
>> The PSCI initialisation depends on data found in the DT. Without this the
>> including PSCI support makes little sense, and furthermore the of_* stub
>> functions aren't broad enough to ensure that this builds without CONFIG_OF.
>
>> As there is little enthusiasm for extending these stubs without useful use-cases
>> (of which this is *not* an example) this patch prevents building of PSCI
>> without CONFIG_OF.
>
>> Signed-off-by: Jonathan Austin <jonathan.austin@arm.com>
>> ---
>>    arch/arm/Kconfig |    1 +
>>    1 file changed, 1 insertion(+)
>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index ba412e0..972ec25 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -1577,6 +1577,7 @@ config HOTPLUG_CPU
>>    config ARM_PSCI
>>    	bool "Support for the ARM Power State Coordination Interface (PSCI)"
>>    	depends on CPU_V7
>> +	depends on CONFIG_OF
>
>      I think you meant just OF. :-)
>

Yikes, sure did.

Thanks.
Jonny

> WBR, Sergei
>
>
diff mbox

Patch

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index ba412e0..972ec25 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1577,6 +1577,7 @@  config HOTPLUG_CPU
 config ARM_PSCI
 	bool "Support for the ARM Power State Coordination Interface (PSCI)"
 	depends on CPU_V7
+	depends on CONFIG_OF
 	help
 	  Say Y here if you want Linux to communicate with system firmware
 	  implementing the PSCI specification for CPU-centric power