| Message ID | 1376702795-25912-1-git-send-email-jerry.snitselaar@oracle.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote: > Without MODULE_LICENSE set, I get the following with modprobe: > > acpi_i2c: module license 'unspecified' taints kernel. > acpi_i2c: Unknown symbol i2c_new_device (err 0) > acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0) > acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0) > acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0) > > Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com> Looks good to me. Acked-by: Mika Westerbeg <mika.westerberg@linux.intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote: > On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote: > > Without MODULE_LICENSE set, I get the following with modprobe: > > > > acpi_i2c: module license 'unspecified' taints kernel. > > acpi_i2c: Unknown symbol i2c_new_device (err 0) > > acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0) > > acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0) > > acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0) > > > > Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com> > > Looks good to me. > > Acked-by: Mika Westerbeg <mika.westerberg@linux.intel.com> Well, OK, but do we need to be able to build that as a module? Maybe it should just be yes or no? Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue Aug 20 13, Rafael J. Wysocki wrote: > On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote: > > On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote: > > > Without MODULE_LICENSE set, I get the following with modprobe: > > > > > > acpi_i2c: module license 'unspecified' taints kernel. > > > acpi_i2c: Unknown symbol i2c_new_device (err 0) > > > acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0) > > > acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0) > > > acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0) > > > > > > Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com> > > > > Looks good to me. > > > > Acked-by: Mika Westerbeg <mika.westerberg@linux.intel.com> > > Well, OK, but do we need to be able to build that as a module? > > Maybe it should just be yes or no? > > Rafael > Perhaps have depends on I2C=y and be a bool instead of tristate? -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Monday, August 19, 2013 04:35:29 PM Jerry Snitselaar wrote: > On Tue Aug 20 13, Rafael J. Wysocki wrote: > > On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote: > > > On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote: > > > > Without MODULE_LICENSE set, I get the following with modprobe: > > > > > > > > acpi_i2c: module license 'unspecified' taints kernel. > > > > acpi_i2c: Unknown symbol i2c_new_device (err 0) > > > > acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0) > > > > acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0) > > > > acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0) > > > > > > > > Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com> > > > > > > Looks good to me. > > > > > > Acked-by: Mika Westerbeg <mika.westerberg@linux.intel.com> > > > > Well, OK, but do we need to be able to build that as a module? > > > > Maybe it should just be yes or no? > > > > Rafael > > > > Perhaps have depends on I2C=y and be a bool instead of tristate? Yes, that's the idea. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/acpi_i2c.c b/drivers/acpi/acpi_i2c.c index 82045e3..2c5c65d 100644 --- a/drivers/acpi/acpi_i2c.c +++ b/drivers/acpi/acpi_i2c.c @@ -14,9 +14,14 @@ #include <linux/export.h> #include <linux/i2c.h> #include <linux/ioport.h> +#include <linux/module.h> ACPI_MODULE_NAME("i2c"); +MODULE_DESCRIPTION("ACPI I2C enumeration support"); +MODULE_AUTHOR("Mika Westerberg"); +MODULE_LICENSE("GPL"); + static int acpi_i2c_add_resource(struct acpi_resource *ares, void *data) { struct i2c_board_info *info = data;
Without MODULE_LICENSE set, I get the following with modprobe: acpi_i2c: module license 'unspecified' taints kernel. acpi_i2c: Unknown symbol i2c_new_device (err 0) acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0) acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0) acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0) Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com> --- drivers/acpi/acpi_i2c.c | 5 +++++ 1 file changed, 5 insertions(+)