| Message ID | 1376467631-20857-1-git-send-email-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
On Wed, 2013-08-14 at 11:07 +0300, Andy Shevchenko wrote: > This patch fixes the style of the comments to be like following > /* The commentary */ > > There is no functional change. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Jiri, Srinivas, any comments on this? > --- > drivers/hid/hid-sensor-hub.c | 2 +- > include/linux/hid-sensor-hub.h | 2 +- > include/linux/hid-sensor-ids.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c > index ca749810..ffc80cf 100644 > --- a/drivers/hid/hid-sensor-hub.c > +++ b/drivers/hid/hid-sensor-hub.c > @@ -416,7 +416,7 @@ static int sensor_hub_raw_event(struct hid_device *hdev, > return 1; > > ptr = raw_data; > - ptr++; /*Skip report id*/ > + ptr++; /* Skip report id */ > > spin_lock_irqsave(&pdata->lock, flags); > > diff --git a/include/linux/hid-sensor-hub.h b/include/linux/hid-sensor-hub.h > index ecefb73..32ba451 100644 > --- a/include/linux/hid-sensor-hub.h > +++ b/include/linux/hid-sensor-hub.h > @@ -172,7 +172,7 @@ struct hid_sensor_common { > struct hid_sensor_hub_attribute_info sensitivity; > }; > > -/*Convert from hid unit expo to regular exponent*/ > +/* Convert from hid unit expo to regular exponent */ > static inline int hid_sensor_convert_exponent(int unit_expo) > { > if (unit_expo < 0x08) > diff --git a/include/linux/hid-sensor-ids.h b/include/linux/hid-sensor-ids.h > index 6f24446..4f945d3 100644 > --- a/include/linux/hid-sensor-ids.h > +++ b/include/linux/hid-sensor-ids.h > @@ -37,7 +37,7 @@ > #define HID_USAGE_SENSOR_ANGL_VELOCITY_Y_AXIS 0x200458 > #define HID_USAGE_SENSOR_ANGL_VELOCITY_Z_AXIS 0x200459 > > -/*ORIENTATION: Compass 3D: (200083) */ > +/* ORIENTATION: Compass 3D: (200083) */ > #define HID_USAGE_SENSOR_COMPASS_3D 0x200083 > #define HID_USAGE_SENSOR_ORIENT_MAGN_HEADING 0x200471 > #define HID_USAGE_SENSOR_ORIENT_MAGN_HEADING_X 0x200472
On 08/19/2013 01:48 AM, Andy Shevchenko wrote: > On Wed, 2013-08-14 at 11:07 +0300, Andy Shevchenko wrote: >> This patch fixes the style of the comments to be like following >> /* The commentary */ >> >> There is no functional change. >> >> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Jiri, Srinivas, any comments on this? Agreed. >> --- >> drivers/hid/hid-sensor-hub.c | 2 +- >> include/linux/hid-sensor-hub.h | 2 +- >> include/linux/hid-sensor-ids.h | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c >> index ca749810..ffc80cf 100644 >> --- a/drivers/hid/hid-sensor-hub.c >> +++ b/drivers/hid/hid-sensor-hub.c >> @@ -416,7 +416,7 @@ static int sensor_hub_raw_event(struct hid_device *hdev, >> return 1; >> >> ptr = raw_data; >> - ptr++; /*Skip report id*/ >> + ptr++; /* Skip report id */ >> >> spin_lock_irqsave(&pdata->lock, flags); >> >> diff --git a/include/linux/hid-sensor-hub.h b/include/linux/hid-sensor-hub.h >> index ecefb73..32ba451 100644 >> --- a/include/linux/hid-sensor-hub.h >> +++ b/include/linux/hid-sensor-hub.h >> @@ -172,7 +172,7 @@ struct hid_sensor_common { >> struct hid_sensor_hub_attribute_info sensitivity; >> }; >> >> -/*Convert from hid unit expo to regular exponent*/ >> +/* Convert from hid unit expo to regular exponent */ >> static inline int hid_sensor_convert_exponent(int unit_expo) >> { >> if (unit_expo < 0x08) >> diff --git a/include/linux/hid-sensor-ids.h b/include/linux/hid-sensor-ids.h >> index 6f24446..4f945d3 100644 >> --- a/include/linux/hid-sensor-ids.h >> +++ b/include/linux/hid-sensor-ids.h >> @@ -37,7 +37,7 @@ >> #define HID_USAGE_SENSOR_ANGL_VELOCITY_Y_AXIS 0x200458 >> #define HID_USAGE_SENSOR_ANGL_VELOCITY_Z_AXIS 0x200459 >> >> -/*ORIENTATION: Compass 3D: (200083) */ >> +/* ORIENTATION: Compass 3D: (200083) */ >> #define HID_USAGE_SENSOR_COMPASS_3D 0x200083 >> #define HID_USAGE_SENSOR_ORIENT_MAGN_HEADING 0x200471 >> #define HID_USAGE_SENSOR_ORIENT_MAGN_HEADING_X 0x200472 Thanks, Srinivas -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 14 Aug 2013, Andy Shevchenko wrote: > This patch fixes the style of the comments to be like following > /* The commentary */ > > There is no functional change. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Applied. > --- > drivers/hid/hid-sensor-hub.c | 2 +- > include/linux/hid-sensor-hub.h | 2 +- > include/linux/hid-sensor-ids.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c > index ca749810..ffc80cf 100644 > --- a/drivers/hid/hid-sensor-hub.c > +++ b/drivers/hid/hid-sensor-hub.c > @@ -416,7 +416,7 @@ static int sensor_hub_raw_event(struct hid_device *hdev, > return 1; > > ptr = raw_data; > - ptr++; /*Skip report id*/ > + ptr++; /* Skip report id */ > > spin_lock_irqsave(&pdata->lock, flags); > > diff --git a/include/linux/hid-sensor-hub.h b/include/linux/hid-sensor-hub.h > index ecefb73..32ba451 100644 > --- a/include/linux/hid-sensor-hub.h > +++ b/include/linux/hid-sensor-hub.h > @@ -172,7 +172,7 @@ struct hid_sensor_common { > struct hid_sensor_hub_attribute_info sensitivity; > }; > > -/*Convert from hid unit expo to regular exponent*/ > +/* Convert from hid unit expo to regular exponent */ > static inline int hid_sensor_convert_exponent(int unit_expo) > { > if (unit_expo < 0x08) > diff --git a/include/linux/hid-sensor-ids.h b/include/linux/hid-sensor-ids.h > index 6f24446..4f945d3 100644 > --- a/include/linux/hid-sensor-ids.h > +++ b/include/linux/hid-sensor-ids.h > @@ -37,7 +37,7 @@ > #define HID_USAGE_SENSOR_ANGL_VELOCITY_Y_AXIS 0x200458 > #define HID_USAGE_SENSOR_ANGL_VELOCITY_Z_AXIS 0x200459 > > -/*ORIENTATION: Compass 3D: (200083) */ > +/* ORIENTATION: Compass 3D: (200083) */ > #define HID_USAGE_SENSOR_COMPASS_3D 0x200083 > #define HID_USAGE_SENSOR_ORIENT_MAGN_HEADING 0x200471 > #define HID_USAGE_SENSOR_ORIENT_MAGN_HEADING_X 0x200472 > -- > 1.8.4.rc2 >
diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c index ca749810..ffc80cf 100644 --- a/drivers/hid/hid-sensor-hub.c +++ b/drivers/hid/hid-sensor-hub.c @@ -416,7 +416,7 @@ static int sensor_hub_raw_event(struct hid_device *hdev, return 1; ptr = raw_data; - ptr++; /*Skip report id*/ + ptr++; /* Skip report id */ spin_lock_irqsave(&pdata->lock, flags); diff --git a/include/linux/hid-sensor-hub.h b/include/linux/hid-sensor-hub.h index ecefb73..32ba451 100644 --- a/include/linux/hid-sensor-hub.h +++ b/include/linux/hid-sensor-hub.h @@ -172,7 +172,7 @@ struct hid_sensor_common { struct hid_sensor_hub_attribute_info sensitivity; }; -/*Convert from hid unit expo to regular exponent*/ +/* Convert from hid unit expo to regular exponent */ static inline int hid_sensor_convert_exponent(int unit_expo) { if (unit_expo < 0x08) diff --git a/include/linux/hid-sensor-ids.h b/include/linux/hid-sensor-ids.h index 6f24446..4f945d3 100644 --- a/include/linux/hid-sensor-ids.h +++ b/include/linux/hid-sensor-ids.h @@ -37,7 +37,7 @@ #define HID_USAGE_SENSOR_ANGL_VELOCITY_Y_AXIS 0x200458 #define HID_USAGE_SENSOR_ANGL_VELOCITY_Z_AXIS 0x200459 -/*ORIENTATION: Compass 3D: (200083) */ +/* ORIENTATION: Compass 3D: (200083) */ #define HID_USAGE_SENSOR_COMPASS_3D 0x200083 #define HID_USAGE_SENSOR_ORIENT_MAGN_HEADING 0x200471 #define HID_USAGE_SENSOR_ORIENT_MAGN_HEADING_X 0x200472
This patch fixes the style of the comments to be like following /* The commentary */ There is no functional change. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/hid/hid-sensor-hub.c | 2 +- include/linux/hid-sensor-hub.h | 2 +- include/linux/hid-sensor-ids.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)