diff mbox

[v2,10/13] ARM: OMAP2+: hwmod: AM43x operations

Message ID 838ab5ad788f64cef1e8859409490aa2b495d1ee.1375443858.git.afzal@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Afzal Mohammed Aug. 2, 2013, 1:38 p.m. UTC
Reuse OMAP4 operations on AM43x.

Signed-off-by: Ambresh K <ambresh@ti.com>
Signed-off-by: Afzal Mohammed <afzal@ti.com>
---
 arch/arm/mach-omap2/omap_hwmod.c |    8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Rajendra Nayak Aug. 21, 2013, 11:30 a.m. UTC | #1
On Friday 02 August 2013 07:08 PM, Afzal Mohammed wrote:
> Reuse OMAP4 operations on AM43x.
> 
> Signed-off-by: Ambresh K <ambresh@ti.com>
> Signed-off-by: Afzal Mohammed <afzal@ti.com>
> ---
>  arch/arm/mach-omap2/omap_hwmod.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
> index 7f4db12..a1b7e20 100644
> --- a/arch/arm/mach-omap2/omap_hwmod.c
> +++ b/arch/arm/mach-omap2/omap_hwmod.c
> @@ -4123,6 +4123,14 @@ void __init omap_hwmod_init(void)
>  		soc_ops.init_clkdm = _init_clkdm;
>  		soc_ops.update_context_lost = _omap4_update_context_lost;
>  		soc_ops.get_context_lost = _omap4_get_context_lost;
> +	} else if (soc_is_am43xx()) {
> +		soc_ops.enable_module = _omap4_enable_module;
> +		soc_ops.disable_module = _omap4_disable_module;
> +		soc_ops.wait_target_ready = _omap4_wait_target_ready;
> +		soc_ops.assert_hardreset = _omap4_assert_hardreset;
> +		soc_ops.deassert_hardreset = _omap4_deassert_hardreset;
> +		soc_ops.is_hardreset_asserted = _omap4_is_hardreset_asserted;
> +		soc_ops.init_clkdm = _init_clkdm;

Did you leave out soc_ops.update_context_lost and soc_ops.get_context_lost on
purpose?

>  	} else if (soc_is_am33xx()) {
>  		soc_ops.enable_module = _am33xx_enable_module;
>  		soc_ops.disable_module = _am33xx_disable_module;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Afzal Mohammed Aug. 28, 2013, 12:29 p.m. UTC | #2
Hi Rajendra,

On Wednesday 21 August 2013 05:00 PM, Rajendra Nayak wrote:
> On Friday 02 August 2013 07:08 PM, Afzal Mohammed wrote:

>> Reuse OMAP4 operations on AM43x.
>>
>> Signed-off-by: Ambresh K <ambresh@ti.com>
>> Signed-off-by: Afzal Mohammed <afzal@ti.com>
>> ---
>>  arch/arm/mach-omap2/omap_hwmod.c |    8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
>> index 7f4db12..a1b7e20 100644
>> --- a/arch/arm/mach-omap2/omap_hwmod.c
>> +++ b/arch/arm/mach-omap2/omap_hwmod.c
>> @@ -4123,6 +4123,14 @@ void __init omap_hwmod_init(void)
>>  		soc_ops.init_clkdm = _init_clkdm;
>>  		soc_ops.update_context_lost = _omap4_update_context_lost;
>>  		soc_ops.get_context_lost = _omap4_get_context_lost;
>> +	} else if (soc_is_am43xx()) {
>> +		soc_ops.enable_module = _omap4_enable_module;
>> +		soc_ops.disable_module = _omap4_disable_module;
>> +		soc_ops.wait_target_ready = _omap4_wait_target_ready;
>> +		soc_ops.assert_hardreset = _omap4_assert_hardreset;
>> +		soc_ops.deassert_hardreset = _omap4_deassert_hardreset;
>> +		soc_ops.is_hardreset_asserted = _omap4_is_hardreset_asserted;
>> +		soc_ops.init_clkdm = _init_clkdm;
> 
> Did you leave out soc_ops.update_context_lost and soc_ops.get_context_lost on
> purpose?

As far as I understand, primarily driver make use of this with the help
of function pointers passed through platform data. And as am43x is a DT
only platform, it was left out.

Regards
Afzal

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
index 7f4db12..a1b7e20 100644
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -4123,6 +4123,14 @@  void __init omap_hwmod_init(void)
 		soc_ops.init_clkdm = _init_clkdm;
 		soc_ops.update_context_lost = _omap4_update_context_lost;
 		soc_ops.get_context_lost = _omap4_get_context_lost;
+	} else if (soc_is_am43xx()) {
+		soc_ops.enable_module = _omap4_enable_module;
+		soc_ops.disable_module = _omap4_disable_module;
+		soc_ops.wait_target_ready = _omap4_wait_target_ready;
+		soc_ops.assert_hardreset = _omap4_assert_hardreset;
+		soc_ops.deassert_hardreset = _omap4_deassert_hardreset;
+		soc_ops.is_hardreset_asserted = _omap4_is_hardreset_asserted;
+		soc_ops.init_clkdm = _init_clkdm;
 	} else if (soc_is_am33xx()) {
 		soc_ops.enable_module = _am33xx_enable_module;
 		soc_ops.disable_module = _am33xx_disable_module;