diff mbox

[V2,1/2] ARM: dts: remove dwmmc nodes from exynos5 common dts file.

Message ID 52146040.87c5440a.4207.5aff@mx.google.com (mailing list archive)
State New, archived
Headers show

Commit Message

Yuvaraj CD Aug. 21, 2013, 6:37 a.m. UTC 
From: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>

Exynos5 series SOC's 5250 and 5420 have different versions of
DWMMC controller.So there is a new compatible string to distinguish
between them.So these nodes should be moved out of Exynos5 series
common device tree source.

Changes since V1: none

Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
---
 arch/arm/boot/dts/exynos5.dtsi |   21 ---------------------
 1 file changed, 21 deletions(-)

Comments

Tomasz Figa Aug. 21, 2013, 10:34 a.m. UTC | #1 
Hi Yuvaraj,

On Wednesday 21 of August 2013 12:07:38 yuvaraj.cd@gmail.com wrote:
> From: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
> 
> Exynos5 series SOC's 5250 and 5420 have different versions of
> DWMMC controller.So there is a new compatible string to distinguish
> between them.So these nodes should be moved out of Exynos5 series
> common device tree source.

This series should be split in a different way, because patch 1/2 breaks 
dwmmc on Exynos5250 and only patch 2/2 fixes this, so bisection is broken.

Also patch 2/2 contains two logically separate changes - moving dwmmc nodes 
and making status disabled by default. Those should be in separate patches.

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Yuvaraj CD Aug. 21, 2013, 11:46 a.m. UTC | #2 
On Wed, Aug 21, 2013 at 4:04 PM, Tomasz Figa <t.figa@samsung.com> wrote:
> Hi Yuvaraj,
>
> On Wednesday 21 of August 2013 12:07:38 yuvaraj.cd@gmail.com wrote:
>> From: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
>>
>> Exynos5 series SOC's 5250 and 5420 have different versions of
>> DWMMC controller.So there is a new compatible string to distinguish
>> between them.So these nodes should be moved out of Exynos5 series
>> common device tree source.
>
> This series should be split in a different way, because patch 1/2 breaks
> dwmmc on Exynos5250 and only patch 2/2 fixes this, so bisection is broken.
 will make a single patch and resend.
>
> Also patch 2/2 contains two logically separate changes - moving dwmmc nodes
> and making status disabled by default. Those should be in separate patches.
 will separate patch2/2 and resend.
>
> Best regards,
> Tomasz
>
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi
index 6afa57d..24140f0 100644
--- a/arch/arm/boot/dts/exynos5.dtsi
+++ b/arch/arm/boot/dts/exynos5.dtsi
@@ -50,27 +50,6 @@ 
 		interrupts = <1 9 0xf04>;
 	};
 
-	dwmmc_0: dwmmc0@12200000 {
-		compatible = "samsung,exynos5250-dw-mshc";
-		interrupts = <0 75 0>;
-		#address-cells = <1>;
-		#size-cells = <0>;
-	};
-
-	dwmmc_1: dwmmc1@12210000 {
-		compatible = "samsung,exynos5250-dw-mshc";
-		interrupts = <0 76 0>;
-		#address-cells = <1>;
-		#size-cells = <0>;
-	};
-
-	dwmmc_2: dwmmc2@12220000 {
-		compatible = "samsung,exynos5250-dw-mshc";
-		interrupts = <0 77 0>;
-		#address-cells = <1>;
-		#size-cells = <0>;
-	};
-
 	serial@12C00000 {
 		compatible = "samsung,exynos4210-uart";
 		reg = <0x12C00000 0x100>;