| Message ID | 1377284808-32412-1-git-send-email-bigeasy@linutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello. On 08/23/2013 11:06 PM, Sebastian Andrzej Siewior wrote: > From: Matt Porter <mdp@ti.com> > Adds AM33XX EDMA support to the am33xx.dtsi as documented in > Documentation/devicetree/bindings/dma/ti-edma.txt > Joel: Drop DT entries that are non-hardware-description for now as discussed in [1] > [1] https://patchwork.kernel.org/patch/2226761/ > Signed-off-by: Matt Porter <mporter@ti.com> > Signed-off-by: Joel A Fernandes <joelagnel@ti.com> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > --- > Could someone please pick this up? > arch/arm/boot/dts/am33xx.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index 38b446b..784f774 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -96,6 +96,18 @@ > reg = <0x48200000 0x1000>; > }; > > + edma: edma@49000000 { The node should be named "dma-controller", not "edma",according to ePAPR section 2.2.2: http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf WBR, Sergei
Updating CC with Matt's current email address. On 08/24/2013 01:02 PM, Sergei Shtylyov wrote: > Hello. > > On 08/23/2013 11:06 PM, Sebastian Andrzej Siewior wrote: > >> From: Matt Porter <mdp@ti.com> > >> Adds AM33XX EDMA support to the am33xx.dtsi as documented in >> Documentation/devicetree/bindings/dma/ti-edma.txt > >> Joel: Drop DT entries that are non-hardware-description for now as discussed >> in [1] > >> [1] https://patchwork.kernel.org/patch/2226761/ > >> Signed-off-by: Matt Porter <mporter@ti.com> >> Signed-off-by: Joel A Fernandes <joelagnel@ti.com> >> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> >> --- >> Could someone please pick this up? > >> arch/arm/boot/dts/am33xx.dtsi | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) > >> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi >> index 38b446b..784f774 100644 >> --- a/arch/arm/boot/dts/am33xx.dtsi >> +++ b/arch/arm/boot/dts/am33xx.dtsi >> @@ -96,6 +96,18 @@ >> reg = <0x48200000 0x1000>; >> }; >> >> + edma: edma@49000000 { > > The node should be named "dma-controller", not "edma",according to ePAPR > section 2.2.2: > > http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf So you mean something like the following? edma: dma-controller@49000000 { ... } Thanks, -Joel
Hello. On 08/24/2013 10:33 PM, Joel Fernandes wrote: > Updating CC with Matt's current email address. >>> From: Matt Porter <mdp@ti.com> >>> Adds AM33XX EDMA support to the am33xx.dtsi as documented in >>> Documentation/devicetree/bindings/dma/ti-edma.txt >>> Joel: Drop DT entries that are non-hardware-description for now as discussed >>> in [1] >>> [1] https://patchwork.kernel.org/patch/2226761/ >>> Signed-off-by: Matt Porter <mporter@ti.com> >>> Signed-off-by: Joel A Fernandes <joelagnel@ti.com> >>> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> >>> --- >>> Could someone please pick this up? >>> arch/arm/boot/dts/am33xx.dtsi | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi >>> index 38b446b..784f774 100644 >>> --- a/arch/arm/boot/dts/am33xx.dtsi >>> +++ b/arch/arm/boot/dts/am33xx.dtsi >>> @@ -96,6 +96,18 @@ >>> reg = <0x48200000 0x1000>; >>> }; >>> >>> + edma: edma@49000000 { >> The node should be named "dma-controller", not "edma",according to ePAPR >> section 2.2.2: >> http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf > So you mean something like the following? > edma: dma-controller@49000000 { > ... > } Yes, exactly. > Thanks, > -Joel WBR, Sergei
Hi Sebastian, Is this patch different from that one: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg92176.html Lokesh just pointed me this patch because it was missing for the SHAM/AES series from Mark Greer. Bottom-line, I've just applied the original one along with a second one that was adding EDMA in SPI. Regards, Benoit On 23/08/2013 21:06, Sebastian Andrzej Siewior wrote: > From: Matt Porter <mdp@ti.com> > > Adds AM33XX EDMA support to the am33xx.dtsi as documented in > Documentation/devicetree/bindings/dma/ti-edma.txt > > Joel: Drop DT entries that are non-hardware-description for now as discussed in [1] > > [1] https://patchwork.kernel.org/patch/2226761/ > > Signed-off-by: Matt Porter <mporter@ti.com> > Signed-off-by: Joel A Fernandes <joelagnel@ti.com> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > --- > Could someone please pick this up? > > arch/arm/boot/dts/am33xx.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index 38b446b..784f774 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -96,6 +96,18 @@ > reg = <0x48200000 0x1000>; > }; > > + edma: edma@49000000 { > + compatible = "ti,edma3"; > + ti,hwmods = "tpcc", "tptc0", "tptc1", "tptc2"; > + reg = <0x49000000 0x10000>, > + <0x44e10f90 0x10>; > + interrupts = <12 13 14>; > + #dma-cells = <1>; > + dma-channels = <64>; > + ti,edma-regions = <4>; > + ti,edma-slots = <256>; > + }; > + > gpio0: gpio@44e07000 { > compatible = "ti,omap4-gpio"; > ti,hwmods = "gpio1"; >
Hi Benoit, On 08/26/2013 03:33 AM, Benoit Cousson wrote: > Hi Sebastian, > > Is this patch different from that one: > http://www.mail-archive.com/linux-omap@vger.kernel.org/msg92176.html > > Lokesh just pointed me this patch because it was missing for the SHAM/AES series > from Mark Greer. > > Bottom-line, I've just applied the original one along with a second one that was > adding EDMA in SPI. Sebastian just submitted another version of the patch [1]. This is the latest version of the EDMA DT patch. If its ok, could you use this patch? You could ignore all earlier versions. [1] http://www.spinics.net/lists/arm-kernel/msg269712.html Thanks, -Joel > Regards, > Benoit > > > On 23/08/2013 21:06, Sebastian Andrzej Siewior wrote: >> From: Matt Porter <mdp@ti.com> >> >> Adds AM33XX EDMA support to the am33xx.dtsi as documented in >> Documentation/devicetree/bindings/dma/ti-edma.txt >> >> Joel: Drop DT entries that are non-hardware-description for now as discussed >> in [1] >> >> [1] https://patchwork.kernel.org/patch/2226761/ >> >> Signed-off-by: Matt Porter <mporter@ti.com> >> Signed-off-by: Joel A Fernandes <joelagnel@ti.com> >> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> >> --- >> Could someone please pick this up? >> >> arch/arm/boot/dts/am33xx.dtsi | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi >> index 38b446b..784f774 100644 >> --- a/arch/arm/boot/dts/am33xx.dtsi >> +++ b/arch/arm/boot/dts/am33xx.dtsi >> @@ -96,6 +96,18 @@ >> reg = <0x48200000 0x1000>; >> }; >> >> + edma: edma@49000000 { >> + compatible = "ti,edma3"; >> + ti,hwmods = "tpcc", "tptc0", "tptc1", "tptc2"; >> + reg = <0x49000000 0x10000>, >> + <0x44e10f90 0x10>; >> + interrupts = <12 13 14>; >> + #dma-cells = <1>; >> + dma-channels = <64>; >> + ti,edma-regions = <4>; >> + ti,edma-slots = <256>; >> + }; >> + >> gpio0: gpio@44e07000 { >> compatible = "ti,omap4-gpio"; >> ti,hwmods = "gpio1"; >> >
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index 38b446b..784f774 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -96,6 +96,18 @@ reg = <0x48200000 0x1000>; }; + edma: edma@49000000 { + compatible = "ti,edma3"; + ti,hwmods = "tpcc", "tptc0", "tptc1", "tptc2"; + reg = <0x49000000 0x10000>, + <0x44e10f90 0x10>; + interrupts = <12 13 14>; + #dma-cells = <1>; + dma-channels = <64>; + ti,edma-regions = <4>; + ti,edma-slots = <256>; + }; + gpio0: gpio@44e07000 { compatible = "ti,omap4-gpio"; ti,hwmods = "gpio1";