| Message ID | 4A1C58A5.1030700@web.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Jan Kiszka wrote: > Reposted as joint patch as there is no MSR_K7 in your next queue. > > Applied, thanks. Don't know why I though I had HWCR in there.
Hello Jan, On Tue, 2009-05-26 at 23:01 +0200, Jan Kiszka wrote: > Reposted as joint patch as there is no MSR_K7 in your next queue. > > --------> > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> > --- > > x86/external-module-compat.h | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/x86/external-module-compat.h b/x86/external-module-compat.h > index 445c7a1..0e26743 100644 > --- a/x86/external-module-compat.h > +++ b/x86/external-module-compat.h > @@ -496,6 +496,14 @@ struct kvm_desc_ptr { > #define MSR_IA32_TSC 0x00000010 > #endif > > +#ifndef MSR_K7_HWCR > +#define MSR_K7_HWCR 0xc0010015 > +#endif > + > +#ifndef MSR_K8_SYSCFG > +#define MSR_K8_SYSCFG 0xc0010010 > +#endif > + It will look more beautiful if we arrange MSR addresses in some order (say increasing order) : +#ifndef MSR_K8_SYSCFG +#define MSR_K8_SYSCFG 0xc0010010 +#endif + +#ifndef MSR_K7_HWCR +#define MSR_K7_HWCR 0xc0010015 +#endif + Thanks, -- JSR -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Jaswinder Singh Rajput wrote: > Hello Jan, > > On Tue, 2009-05-26 at 23:01 +0200, Jan Kiszka wrote: >> Reposted as joint patch as there is no MSR_K7 in your next queue. >> >> --------> >> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> >> --- >> >> x86/external-module-compat.h | 8 ++++++++ >> 1 files changed, 8 insertions(+), 0 deletions(-) >> >> diff --git a/x86/external-module-compat.h b/x86/external-module-compat.h >> index 445c7a1..0e26743 100644 >> --- a/x86/external-module-compat.h >> +++ b/x86/external-module-compat.h >> @@ -496,6 +496,14 @@ struct kvm_desc_ptr { >> #define MSR_IA32_TSC 0x00000010 >> #endif >> >> +#ifndef MSR_K7_HWCR >> +#define MSR_K7_HWCR 0xc0010015 >> +#endif >> + >> +#ifndef MSR_K8_SYSCFG >> +#define MSR_K8_SYSCFG 0xc0010010 >> +#endif >> + > > It will look more beautiful if we arrange MSR addresses in some order > (say increasing order) : > > +#ifndef MSR_K8_SYSCFG > +#define MSR_K8_SYSCFG 0xc0010010 > +#endif > + > +#ifndef MSR_K7_HWCR > +#define MSR_K7_HWCR 0xc0010015 > +#endif > + Well, I just used a different sorting key: K7 vs. K8... Jan
On Wed, 2009-05-27 at 12:05 +0200, Jan Kiszka wrote: > Jaswinder Singh Rajput wrote: > > It will look more beautiful if we arrange MSR addresses in some order > > (say increasing order) : > > > > +#ifndef MSR_K8_SYSCFG > > +#define MSR_K8_SYSCFG 0xc0010010 > > +#endif > > + > > +#ifndef MSR_K7_HWCR > > +#define MSR_K7_HWCR 0xc0010015 > > +#endif > > + > > Well, I just used a different sorting key: K7 vs. K8... > sorting with K7, K8 are not very helpful, on the other hand if we sort with MSR address it will be helpful in : 1. searching of MSR 2. adding new MSR 3. avoid duplicate MSR 4. of course looks beautiful ;-) Thanks, -- JSR -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Jaswinder Singh Rajput wrote: > On Wed, 2009-05-27 at 12:05 +0200, Jan Kiszka wrote: > >> Jaswinder Singh Rajput wrote: >> >>> It will look more beautiful if we arrange MSR addresses in some order >>> (say increasing order) : >>> >>> +#ifndef MSR_K8_SYSCFG >>> +#define MSR_K8_SYSCFG 0xc0010010 >>> +#endif >>> + >>> +#ifndef MSR_K7_HWCR >>> +#define MSR_K7_HWCR 0xc0010015 >>> +#endif >>> + >>> >> Well, I just used a different sorting key: K7 vs. K8... >> >> > > sorting with K7, K8 are not very helpful, on the other hand if we sort > with MSR address it will be helpful in : > 1. searching of MSR > 2. adding new MSR > 3. avoid duplicate MSR > 4. of course looks beautiful ;-) > Let's not get carried away.
diff --git a/x86/external-module-compat.h b/x86/external-module-compat.h index 445c7a1..0e26743 100644 --- a/x86/external-module-compat.h +++ b/x86/external-module-compat.h @@ -496,6 +496,14 @@ struct kvm_desc_ptr { #define MSR_IA32_TSC 0x00000010 #endif +#ifndef MSR_K7_HWCR +#define MSR_K7_HWCR 0xc0010015 +#endif + +#ifndef MSR_K8_SYSCFG +#define MSR_K8_SYSCFG 0xc0010010 +#endif + #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,25) && defined(__x86_64__) #undef set_debugreg
Reposted as joint patch as there is no MSR_K7 in your next queue. --------> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> --- x86/external-module-compat.h | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)