| Message ID | 1379946998-23041-2-git-send-email-jbe@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 09/23/2013 11:36 AM, Juergen Beisert wrote: > + lradc->clk = devm_clk_get(&pdev->dev, NULL); > + clk_prepare_enable(lradc->clk); clk_prepare_enable() may fail, so better check its return value. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, Juergen Beisert writes: > diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c > index a08c173..00b61ac 100644 > --- a/drivers/staging/iio/adc/mxs-lradc.c > +++ b/drivers/staging/iio/adc/mxs-lradc.c > @@ -35,6 +35,7 @@ > #include <linux/completion.h> > #include <linux/delay.h> > #include <linux/input.h> > +#include <linux/clk.h> > > #include <linux/iio/iio.h> > #include <linux/iio/buffer.h> > @@ -134,6 +135,8 @@ struct mxs_lradc { > void __iomem *base; > int irq[13]; > > + struct clk *clk; > + > uint32_t *buffer; > struct iio_trigger *trig; > > @@ -928,6 +931,9 @@ static int mxs_lradc_probe(struct platform_device *pdev) > if (IS_ERR(lradc->base)) > return PTR_ERR(lradc->base); > > + lradc->clk = devm_clk_get(&pdev->dev, NULL); > + clk_prepare_enable(lradc->clk); > + Wouldn't it make sense to enable the clock only when the device is opened to save power while not actually in use? Lothar Waßmann
Hi Lothar, On Monday 23 September 2013 17:30:18 Lothar Waßmann wrote: > > [...] > > @@ -928,6 +931,9 @@ static int mxs_lradc_probe(struct platform_device > > *pdev) if (IS_ERR(lradc->base)) > > return PTR_ERR(lradc->base); > > > > + lradc->clk = devm_clk_get(&pdev->dev, NULL); > > + clk_prepare_enable(lradc->clk); > > + > > Wouldn't it make sense to enable the clock only when the device is > opened to save power while not actually in use? Sure. But I haven't analyzed yet if the IIO part of the driver also uses the delay units and - more important - when it use them. @Marek: can you tell us, where the clock should be enabled in your part of the driver (if required)? BTW: do we also need to get and enable the 24 MHz clock (used by the ADC itself)? I'm not sure if this clock is the "CLK_ANA24M" shown in their "Logical Diagram of Clock Domains". The datasheets also mention the "clk_xtal24m" clock for "analog 24 MHz clock domains". But does "Fixed clock domains" mean they are not switchable and thus always enabled? Regards, Juergen
diff --git a/arch/arm/boot/dts/imx23.dtsi b/arch/arm/boot/dts/imx23.dtsi index 28b5ce2..07caf76 100644 --- a/arch/arm/boot/dts/imx23.dtsi +++ b/arch/arm/boot/dts/imx23.dtsi @@ -430,6 +430,7 @@ reg = <0x80050000 0x2000>; interrupts = <36 37 38 39 40 41 42 43 44>; status = "disabled"; + clocks = <&clks 26>; }; spdif@80054000 { diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi index 7363fde..175deef 100644 --- a/arch/arm/boot/dts/imx28.dtsi +++ b/arch/arm/boot/dts/imx28.dtsi @@ -902,6 +902,7 @@ interrupts = <10 14 15 16 17 18 19 20 21 22 23 24 25>; status = "disabled"; + clocks = <&clks 41>; }; spdif: spdif@80054000 { diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c index a08c173..00b61ac 100644 --- a/drivers/staging/iio/adc/mxs-lradc.c +++ b/drivers/staging/iio/adc/mxs-lradc.c @@ -35,6 +35,7 @@ #include <linux/completion.h> #include <linux/delay.h> #include <linux/input.h> +#include <linux/clk.h> #include <linux/iio/iio.h> #include <linux/iio/buffer.h> @@ -134,6 +135,8 @@ struct mxs_lradc { void __iomem *base; int irq[13]; + struct clk *clk; + uint32_t *buffer; struct iio_trigger *trig; @@ -928,6 +931,9 @@ static int mxs_lradc_probe(struct platform_device *pdev) if (IS_ERR(lradc->base)) return PTR_ERR(lradc->base); + lradc->clk = devm_clk_get(&pdev->dev, NULL); + clk_prepare_enable(lradc->clk); + INIT_WORK(&lradc->ts_work, mxs_lradc_ts_work); /* Check if touchscreen is enabled in DT. */ @@ -1020,6 +1026,7 @@ static int mxs_lradc_remove(struct platform_device *pdev) iio_triggered_buffer_cleanup(iio); mxs_lradc_trigger_remove(iio); + clk_disable_unprepare(lradc->clk); return 0; }
The delay units inside the LRADC depend on the presence of a 2 kHz clock. This change enables the clock to be able to use the delay unit for the touchscreen part of the driver. Signed-off-by: Juergen Beisert <jbe@pengutronix.de> --- arch/arm/boot/dts/imx23.dtsi | 1 + arch/arm/boot/dts/imx28.dtsi | 1 + drivers/staging/iio/adc/mxs-lradc.c | 7 +++++++ 3 files changed, 9 insertions(+)