x86 platform: oqo: select INPUT_POLLDEV

Commit Message

Randy Dunlap May 20, 2009, 1:22 a.m. UTC

From: Randy Dunlap <[e-mail]>

OQO_WMI uses INPUT_POLLDEV, but it can select that instead of
depending on it, since it represents library code.

Signed-off-by: Randy Dunlap <[e-mail]>
Cc: Dmitry Torokhov <[e-mail]>
Cc: Len Brown <[e-mail]>
---
 drivers/platform/x86/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Dmitry Torokhov May 20, 2009, 2:28 a.m. UTC | #1

On Tue, May 19, 2009 at 06:22:10PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <[e-mail]>
> 
> OQO_WMI uses INPUT_POLLDEV, but it can select that instead of
> depending on it, since it represents library code.
> 
> Signed-off-by: Randy Dunlap <[e-mail]>
> Cc: Dmitry Torokhov <[e-mail]>
> Cc: Len Brown <[e-mail]>

Thanks Randy.

Acked-by: Dmitry Torokhov <[e-mail]>

Len Brown May 27, 2009, 8:34 p.m. UTC | #2

applied to oqo-wmi-EXPECT-REFRESH branch in acpi test tree.

mjg -- shall I send you the stuff collected on that branch
branch so that you can refresh it for 2.6.31?


thanks,
Len Brown, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Matthew Garrett May 27, 2009, 11:03 p.m. UTC | #3

On Wed, May 27, 2009 at 04:34:35PM -0400, Len Brown wrote:
> applied to oqo-wmi-EXPECT-REFRESH branch in acpi test tree.
> 
> mjg -- shall I send you the stuff collected on that branch
> branch so that you can refresh it for 2.6.31?

Is it public? I can pull it myself easily enough.

Len Brown May 30, 2009, 12:52 a.m. UTC | #4

> Is it public? I can pull it myself easily enough.

yes, commit id's below.

thanks,
Len Brown, Intel Open Source Technology Center


commit 261a37014c353eb392334f31f6bc2166253d12c2
Author: Randy Dunlap <[e-mail]>
Date:   Tue May 26 23:59:27 2009 -0700

    oqo: select INPUT_POLLDEV
    From: Randy Dunlap <[e-mail]>
    
    OQO_WMI uses INPUT_POLLDEV, but it can select that instead of 
depending on
    it, since it represents library code.
    
    Signed-off-by: Randy Dunlap <[e-mail]>
    Acked-by: Dmitry Torokhov <[e-mail]>
    Signed-off-by: Andrew Morton <[e-mail]>
    Signed-off-by: Len Brown <[e-mail]>

commit 0eba5e81e02f5f239e3691c9e9f9afef3050b387
Author: Randy Dunlap <[e-mail]>
Date:   Wed Mar 4 11:55:24 2009 -0800

    x86: oqo: depends on INPUT_POLLDEV
    
    oqo driver uses polled input functions, so make it depend
    on INPUT_POLLDEV.
    
    ERROR: "input_register_polled_device" 
[drivers/platform/x86/oqo-wmi.ko] undefined!
    ERROR: "input_allocate_polled_device" 
[drivers/platform/x86/oqo-wmi.ko] undefined!
    ERROR: "input_free_polled_device" [drivers/platform/x86/oqo-wmi.ko] 
undefined!
    ERROR: "input_unregister_polled_device" 
[drivers/platform/x86/oqo-wmi.ko] undefined!
    
    Signed-off-by: Randy Dunlap <[e-mail]>
    Acked-by: Matthew Garrett <[e-mail]>
    Cc: Ingo Molnar <[e-mail]>
    Cc: Thomas Gleixner <[e-mail]>
    Cc: "H. Peter Anvin" <[e-mail]>
    Cc: Len Brown <[e-mail]>
    Signed-off-by: Andrew Morton <[e-mail]>
    Signed-off-by: Len Brown <[e-mail]>

commit 94c4b5977f33894cc316edf07c5cb72b5d193628
Author: Len Brown <[e-mail]>
Date:   Fri Feb 6 23:06:38 2009 -0500

    oqo: dev_set_name()
    
    Signed-off-by: Len Brown <[e-mail]>

commit 9c82cd255907ad639bed4ffc8fcaf1bd59badb50
Author: Matthew Garrett <[e-mail]>
Date:   Wed Dec 3 19:55:37 2008 +0000

    platform/x86: Add oqo-wmi driver for model 2 OQO backlight and rfkill 
control
    
    oqo-wmi provides a WMI-based interface to backlight and rfkill control 
on
    model 2 OQO devices. It was originally written by Brian Julin
    (<[e-mail]>) - I've ported it to the rfkill layer and tidied it 
up a
    little.
    
    Signed-off-by: Matthew Garrett <[e-mail]>
    Signed-off-by: Len Brown <[e-mail]>


--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- linux-next-20090519.orig/drivers/platform/x86/Kconfig
+++ linux-next-20090519/drivers/platform/x86/Kconfig
@@ -146,9 +146,10 @@  config MSI_LAPTOP
 config OQO_WMI
        tristate "OQO WMI extras"
        depends on ACPI_WMI
-       depends on INPUT && INPUT_POLLDEV
+       depends on INPUT
        depends on RFKILL
        depends on BACKLIGHT_CLASS_DEVICE
+	select INPUT_POLLDEV
        help
          Say Y here if you want to support rfkill and backlight control on
          series 2 OQO handheld devices.