| Message ID | 1380575010-8573-3-git-send-email-ezequiel.garcia@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Sep 30, 2013 at 06:03:28PM -0300, Ezequiel Garcia wrote: > Since the PCIe devices is properly initialized from the DT, the clocks > are now referenced in the device tree nodes, and it's not needed > to have this hack to add them explicitly. > > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> > --- > arch/arm/mach-kirkwood/board-dt.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/arch/arm/mach-kirkwood/board-dt.c b/arch/arm/mach-kirkwood/board-dt.c > index ee6297e..1bbced8 100644 > --- a/arch/arm/mach-kirkwood/board-dt.c > +++ b/arch/arm/mach-kirkwood/board-dt.c > @@ -44,14 +44,6 @@ static void __init kirkwood_legacy_clk_init(void) > clkspec.np = np; > clkspec.args_count = 1; > > - clkspec.args[0] = CGC_BIT_PEX0; > - orion_clkdev_add("0", "pcie", > - of_clk_get_from_provider(&clkspec)); > - > - clkspec.args[0] = CGC_BIT_PEX1; > - orion_clkdev_add("1", "pcie", > - of_clk_get_from_provider(&clkspec)); > - > /* > * The ethernet interfaces forget the MAC address assigned by > * u-boot if the clocks are turned off. Until proper DT support > -- > 1.8.1.5 > If anyone with a PCIe Kirkwood board can give this patch a try it would be great to have some Tested-by's.
On Tue, Oct 01, 2013 at 01:01:36PM -0300, Ezequiel Garcia wrote: > If anyone with a PCIe Kirkwood board can give this patch a try > it would be great to have some Tested-by's. Worked here.. Tested-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> Jason
Hi Ezequiel, Ezequiel Garcia <ezequiel.garcia@free-electrons.com> writes: > If anyone with a PCIe Kirkwood board can give this patch a try > it would be great to have some Tested-by's. Works on my ReadyNAS Duo v2 (88F6282), i.e. I can see and use the USB3.0 controller attached to the PCIe bus so ... Tested-by: Arnaud Ebalard <arno@natisbad.org> Cheers, a+
On Mon, Sep 30, 2013 at 06:03:28PM -0300, Ezequiel Garcia wrote: > Since the PCIe devices is properly initialized from the DT, the clocks > are now referenced in the device tree nodes, and it's not needed > to have this hack to add them explicitly. > > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> > --- > arch/arm/mach-kirkwood/board-dt.c | 8 -------- > 1 file changed, 8 deletions(-) Applied to mvebu/soc thx, Jason.
diff --git a/arch/arm/mach-kirkwood/board-dt.c b/arch/arm/mach-kirkwood/board-dt.c index ee6297e..1bbced8 100644 --- a/arch/arm/mach-kirkwood/board-dt.c +++ b/arch/arm/mach-kirkwood/board-dt.c @@ -44,14 +44,6 @@ static void __init kirkwood_legacy_clk_init(void) clkspec.np = np; clkspec.args_count = 1; - clkspec.args[0] = CGC_BIT_PEX0; - orion_clkdev_add("0", "pcie", - of_clk_get_from_provider(&clkspec)); - - clkspec.args[0] = CGC_BIT_PEX1; - orion_clkdev_add("1", "pcie", - of_clk_get_from_provider(&clkspec)); - /* * The ethernet interfaces forget the MAC address assigned by * u-boot if the clocks are turned off. Until proper DT support
Since the PCIe devices is properly initialized from the DT, the clocks are now referenced in the device tree nodes, and it's not needed to have this hack to add them explicitly. Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> --- arch/arm/mach-kirkwood/board-dt.c | 8 -------- 1 file changed, 8 deletions(-)