| Message ID | 1381209030-351-15-git-send-email-msalter@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Mark Salter <msalter@redhat.com> wrote: > Remove messy dependencies from PARPORT_PC by having it depend on one > Kconfig symbol (ARCH_MAY_HAVE_PC_PARPORT) and having architectures > which need it, select ARCH_MAY_HAVE_PC_PARPORT in arch/*/Kconfig. > New architectures are unlikely to need PARPORT_PC, so this avoids > having an ever growing list of architectures to exclude. Those > architectures which do select ARCH_MAY_HAVE_PC_PARPORT in this > patch are the ones which have an asm/parport.h (or use the generic > version). > > Signed-off-by: Mark Salter <msalter@redhat.com> > CC: Richard Henderson <rth@twiddle.net> > CC: linux-alpha@vger.kernel.org > CC: Vineet Gupta <vgupta@synopsys.com> > CC: Russell King <linux@arm.linux.org.uk> > CC: linux-arm-kernel@lists.infradead.org > CC: Tony Luck <tony.luck@intel.com> > CC: Fenghua Yu <fenghua.yu@intel.com> > CC: linux-ia64@vger.kernel.org > CC: Geert Uytterhoeven <geert@linux-m68k.org> > CC: linux-m68k@lists.linux-m68k.org > CC: Michal Simek <monstr@monstr.eu> > CC: microblaze-uclinux@itee.uq.edu.au > CC: Ralf Baechle <ralf@linux-mips.org> > CC: linux-mips@linux-mips.org > CC: "James E.J. Bottomley" <jejb@parisc-linux.org> > CC: Helge Deller <deller@gmx.de> > CC: linux-parisc@vger.kernel.org > CC: Benjamin Herrenschmidt <benh@kernel.crashing.org> > CC: Paul Mackerras <paulus@samba.org> > CC: linuxppc-dev@lists.ozlabs.org > CC: Paul Mundt <lethal@linux-sh.org> > CC: linux-sh@vger.kernel.org > CC: "David S. Miller" <davem@davemloft.net> > CC: sparclinux@vger.kernel.org > CC: Guan Xuetao <gxt@mprc.pku.edu.cn> > CC: Thomas Gleixner <tglx@linutronix.de> > CC: Ingo Molnar <mingo@redhat.com> > CC: "H. Peter Anvin" <hpa@zytor.com> > CC: x86@kernel.org > --- > drivers/parport/Kconfig | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/parport/Kconfig b/drivers/parport/Kconfig > index 70694ce..a079b18 100644 > --- a/drivers/parport/Kconfig > +++ b/drivers/parport/Kconfig > @@ -31,13 +31,17 @@ menuconfig PARPORT > > If unsure, say Y. > > +config ARCH_MAY_HAVE_PC_PARPORT > + bool > + help > + Select this config option from the architecture Kconfig if > + the architecture may have PC parallel port hardware. > + > if PARPORT > > config PARPORT_PC > tristate "PC-style hardware" > - depends on (!SPARC64 || PCI) && !SPARC32 && !M32R && !FRV && !S390 && \ > - (!M68K || ISA) && !MN10300 && !AVR32 && !BLACKFIN && \ > - !XTENSA && !CRIS && !H8300 > + depends on ARCH_MAY_HAVE_PC_PARPORT > > ---help--- > You should say Y here if you have a PC-style parallel port. All Since it's not a permission to have a parallel port but a possibility, I suspect the whole series needs a: s/MAY_HAVE/MIGHT_HAVE s/may have/might have Otherwise: Acked-by: Ingo Molnar <mingo@kernel.org> Thanks, Ingo
On Tue, Oct 08, 2013 at 01:10:30AM -0400, Mark Salter wrote: > Remove messy dependencies from PARPORT_PC by having it depend on one > Kconfig symbol (ARCH_MAY_HAVE_PC_PARPORT) and having architectures > which need it, select ARCH_MAY_HAVE_PC_PARPORT in arch/*/Kconfig. > New architectures are unlikely to need PARPORT_PC, so this avoids > having an ever growing list of architectures to exclude. Those > architectures which do select ARCH_MAY_HAVE_PC_PARPORT in this > patch are the ones which have an asm/parport.h (or use the generic > version). Acked-by: Ralf Baechle <ralf@linux-mips.org> Ralf
diff --git a/drivers/parport/Kconfig b/drivers/parport/Kconfig index 70694ce..a079b18 100644 --- a/drivers/parport/Kconfig +++ b/drivers/parport/Kconfig @@ -31,13 +31,17 @@ menuconfig PARPORT If unsure, say Y. +config ARCH_MAY_HAVE_PC_PARPORT + bool + help + Select this config option from the architecture Kconfig if + the architecture may have PC parallel port hardware. + if PARPORT config PARPORT_PC tristate "PC-style hardware" - depends on (!SPARC64 || PCI) && !SPARC32 && !M32R && !FRV && !S390 && \ - (!M68K || ISA) && !MN10300 && !AVR32 && !BLACKFIN && \ - !XTENSA && !CRIS && !H8300 + depends on ARCH_MAY_HAVE_PC_PARPORT ---help--- You should say Y here if you have a PC-style parallel port. All
Remove messy dependencies from PARPORT_PC by having it depend on one Kconfig symbol (ARCH_MAY_HAVE_PC_PARPORT) and having architectures which need it, select ARCH_MAY_HAVE_PC_PARPORT in arch/*/Kconfig. New architectures are unlikely to need PARPORT_PC, so this avoids having an ever growing list of architectures to exclude. Those architectures which do select ARCH_MAY_HAVE_PC_PARPORT in this patch are the ones which have an asm/parport.h (or use the generic version). Signed-off-by: Mark Salter <msalter@redhat.com> CC: Richard Henderson <rth@twiddle.net> CC: linux-alpha@vger.kernel.org CC: Vineet Gupta <vgupta@synopsys.com> CC: Russell King <linux@arm.linux.org.uk> CC: linux-arm-kernel@lists.infradead.org CC: Tony Luck <tony.luck@intel.com> CC: Fenghua Yu <fenghua.yu@intel.com> CC: linux-ia64@vger.kernel.org CC: Geert Uytterhoeven <geert@linux-m68k.org> CC: linux-m68k@lists.linux-m68k.org CC: Michal Simek <monstr@monstr.eu> CC: microblaze-uclinux@itee.uq.edu.au CC: Ralf Baechle <ralf@linux-mips.org> CC: linux-mips@linux-mips.org CC: "James E.J. Bottomley" <jejb@parisc-linux.org> CC: Helge Deller <deller@gmx.de> CC: linux-parisc@vger.kernel.org CC: Benjamin Herrenschmidt <benh@kernel.crashing.org> CC: Paul Mackerras <paulus@samba.org> CC: linuxppc-dev@lists.ozlabs.org CC: Paul Mundt <lethal@linux-sh.org> CC: linux-sh@vger.kernel.org CC: "David S. Miller" <davem@davemloft.net> CC: sparclinux@vger.kernel.org CC: Guan Xuetao <gxt@mprc.pku.edu.cn> CC: Thomas Gleixner <tglx@linutronix.de> CC: Ingo Molnar <mingo@redhat.com> CC: "H. Peter Anvin" <hpa@zytor.com> CC: x86@kernel.org --- drivers/parport/Kconfig | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)