| Message ID | 1380195398-4402-4-git-send-email-jean.pihet@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Sep 26, 2013 at 01:36:37PM +0200, Jean Pihet wrote: > The newly added dwarf unwinding feature [1] requires: > . a recent version (>= 1.1) of libunwind, > . libunwind to be configured with --enable-debug-frame. > > [1] http://www.spinics.net/lists/kernel/msg1598951.html > > Add the corresponding API tests in the feature check list. Acked-by: Jiri Olsa <jolsa@redhat.com> thanks, jirka
Hi, On 26 September 2013 14:48, Jiri Olsa <jolsa@redhat.com> wrote: > On Thu, Sep 26, 2013 at 01:36:37PM +0200, Jean Pihet wrote: >> The newly added dwarf unwinding feature [1] requires: >> . a recent version (>= 1.1) of libunwind, >> . libunwind to be configured with --enable-debug-frame. >> >> [1] http://www.spinics.net/lists/kernel/msg1598951.html >> >> Add the corresponding API tests in the feature check list. > > Acked-by: Jiri Olsa <jolsa@redhat.com> > > thanks, > jirka Thanks for the ack! Is it possible to get an ack from the perf core maintainers? Also, is the patch going in Will's tree? Regards, Jean
On Tue, Oct 08, 2013 at 12:44:32PM +0200, Jean Pihet wrote: > Hi, > > On 26 September 2013 14:48, Jiri Olsa <jolsa@redhat.com> wrote: > > On Thu, Sep 26, 2013 at 01:36:37PM +0200, Jean Pihet wrote: > >> The newly added dwarf unwinding feature [1] requires: > >> . a recent version (>= 1.1) of libunwind, > >> . libunwind to be configured with --enable-debug-frame. > >> > >> [1] http://www.spinics.net/lists/kernel/msg1598951.html > >> > >> Add the corresponding API tests in the feature check list. > > > > Acked-by: Jiri Olsa <jolsa@redhat.com> > > > > thanks, > > jirka > > Thanks for the ack! > > Is it possible to get an ack from the perf core maintainers? > Also, is the patch going in Will's tree? This being a tools patch you'd have to ask acme; also I know next to nothing about all this unwind business except that its stupid expensive ;-)
Hi, On 8 October 2013 12:47, Peter Zijlstra <peterz@infradead.org> wrote: > On Tue, Oct 08, 2013 at 12:44:32PM +0200, Jean Pihet wrote: >> Hi, >> >> On 26 September 2013 14:48, Jiri Olsa <jolsa@redhat.com> wrote: >> > On Thu, Sep 26, 2013 at 01:36:37PM +0200, Jean Pihet wrote: >> >> The newly added dwarf unwinding feature [1] requires: >> >> . a recent version (>= 1.1) of libunwind, >> >> . libunwind to be configured with --enable-debug-frame. >> >> >> >> [1] http://www.spinics.net/lists/kernel/msg1598951.html >> >> >> >> Add the corresponding API tests in the feature check list. >> > >> > Acked-by: Jiri Olsa <jolsa@redhat.com> >> > >> > thanks, >> > jirka >> >> Thanks for the ack! >> >> Is it possible to get an ack from the perf core maintainers? >> Also, is the patch going in Will's tree? > > This being a tools patch you'd have to ask acme; also I know next to > nothing about all this unwind business except that its stupid expensive > ;-) You are right! It brings some more info on the trace though. -- adding Arnaldo in the loop -- Arnaldo, are you OK with the changes [1]? Jiri acked the patches already; Will is willing (no pun intended) to take the ARM specific patches [2] in his tree. [1] http://www.spinics.net/lists/kernel/msg1608921.html and http://www.spinics.net/lists/kernel/msg1608922.html [2] http://www.spinics.net/lists/kernel/msg1608920.html and http://www.spinics.net/lists/kernel/msg1608923.html Regards, Jean
Em Tue, Oct 08, 2013 at 04:15:40PM +0200, Jean Pihet escreveu: > On 8 October 2013 12:47, Peter Zijlstra <peterz@infradead.org> wrote: > > On Tue, Oct 08, 2013 at 12:44:32PM +0200, Jean Pihet wrote: > >> On 26 September 2013 14:48, Jiri Olsa <jolsa@redhat.com> wrote: > >> > On Thu, Sep 26, 2013 at 01:36:37PM +0200, Jean Pihet wrote: > >> >> The newly added dwarf unwinding feature [1] requires: > >> >> . a recent version (>= 1.1) of libunwind, > >> >> . libunwind to be configured with --enable-debug-frame. > >> >> [1] http://www.spinics.net/lists/kernel/msg1598951.html > >> >> Add the corresponding API tests in the feature check list. > >> > Acked-by: Jiri Olsa <jolsa@redhat.com> > >> Thanks for the ack! > >> Is it possible to get an ack from the perf core maintainers? > >> Also, is the patch going in Will's tree? > > This being a tools patch you'd have to ask acme; also I know next to > > nothing about all this unwind business except that its stupid expensive > > ;-) > You are right! It brings some more info on the trace though. > -- adding Arnaldo in the loop -- > Arnaldo, are you OK with the changes [1]? Jiri acked the patches > already; Will is willing (no pun intended) to take the ARM specific > patches [2] in his tree. As Jiri acked, go ahead and pick as much as you can via Will's tree, I'd say. :-) - Arnaldo > [1] http://www.spinics.net/lists/kernel/msg1608921.html and > http://www.spinics.net/lists/kernel/msg1608922.html > [2] http://www.spinics.net/lists/kernel/msg1608920.html and > http://www.spinics.net/lists/kernel/msg1608923.html > > Regards, > Jean
On Tue, Oct 08, 2013 at 03:28:30PM +0100, Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 08, 2013 at 04:15:40PM +0200, Jean Pihet escreveu: > > >> On 26 September 2013 14:48, Jiri Olsa <jolsa@redhat.com> wrote: > > > >> > Acked-by: Jiri Olsa <jolsa@redhat.com> > > > -- adding Arnaldo in the loop -- > > Arnaldo, are you OK with the changes [1]? Jiri acked the patches > > already; Will is willing (no pun intended) to take the ARM specific > > patches [2] in his tree. > > As Jiri acked, go ahead and pick as much as you can via Will's tree, I'd > say. :-) Cheers guys, that suits me! Will
diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile index 4b65710..bbaeb04 100644 --- a/tools/perf/config/Makefile +++ b/tools/perf/config/Makefile @@ -223,9 +223,13 @@ endif FLAGS_UNWIND=$(LIBUNWIND_CFLAGS) $(CFLAGS) $(LIBUNWIND_LDFLAGS) $(LDFLAGS) $(EXTLIBS) $(LIBUNWIND_LIBS) ifneq ($(call try-cc,$(SOURCE_LIBUNWIND),$(FLAGS_UNWIND),libunwind),y) - msg := $(warning No libunwind found, disabling post unwind support. Please install libunwind-dev[el] >= 0.99); + msg := $(warning No libunwind found, disabling post unwind support. Please install libunwind-dev[el] >= 1.1); NO_LIBUNWIND := 1 endif # Libunwind support +ifneq ($(call try-cc,$(SOURCE_LIBUNWIND_DEBUG_FRAME),$(FLAGS_UNWIND),libunwind debug_frame),y) + msg := $(warning No debug_frame support found in libunwind); +CFLAGS += -DNO_LIBUNWIND_DEBUG_FRAME +endif # debug_frame support in libunwind endif # NO_LIBUNWIND ifndef NO_LIBUNWIND diff --git a/tools/perf/config/feature-tests.mak b/tools/perf/config/feature-tests.mak index 708fb8e..cde75f5 100644 --- a/tools/perf/config/feature-tests.mak +++ b/tools/perf/config/feature-tests.mak @@ -176,7 +176,6 @@ extern int UNW_OBJ(dwarf_search_unwind_table) (unw_addr_space_t as, unw_proc_info_t *pi, int need_unwind_info, void *arg); - #define dwarf_search_unwind_table UNW_OBJ(dwarf_search_unwind_table) int main(void) @@ -188,6 +187,26 @@ int main(void) return 0; } endef + +define SOURCE_LIBUNWIND_DEBUG_FRAME +#include <libunwind.h> +#include <stdlib.h> + +extern int +UNW_OBJ(dwarf_find_debug_frame) (int found, unw_dyn_info_t *di_debug, + unw_word_t ip, unw_word_t segbase, + const char *obj_name, unw_word_t start, + unw_word_t end); + +#define dwarf_find_debug_frame UNW_OBJ(dwarf_find_debug_frame) + +int main(void) +{ + dwarf_find_debug_frame(0, NULL, 0, 0, NULL, 0, 0); + return 0; +} +endef + endif ifndef NO_BACKTRACE
The newly added dwarf unwinding feature [1] requires: . a recent version (>= 1.1) of libunwind, . libunwind to be configured with --enable-debug-frame. [1] http://www.spinics.net/lists/kernel/msg1598951.html Add the corresponding API tests in the feature check list. Signed-off-by: Jean Pihet <jean.pihet@linaro.org> --- tools/perf/config/Makefile | 6 +++++- tools/perf/config/feature-tests.mak | 21 ++++++++++++++++++++- 2 files changed, 25 insertions(+), 2 deletions(-)