diff mbox

cpufreq: sa11x0: Fix build

Message ID 1381056329-3382-1-git-send-email-broonie@kernel.org (mailing list archive)
State New, archived
Headers show

Commit Message

Mark Brown Oct. 6, 2013, 10:45 a.m. UTC 
From: Mark Brown <broonie@linaro.org>

Commit 22c8b4f140 (cpufreq: sa11x0: Expose frequency table) added use of
struct cpufreq_frequency_table to mach-sa1100/generic.h but did not ensure
that the struct was declared, causing build failures on machines using that
header. Fix this.

Reported-by: Olof's autobuilder <build@lixom.net>
Signed-off-by: Mark Brown <broonie@linaro.org>
---

The relevant commit is in the cpufreq tree in -next.

 arch/arm/mach-sa1100/generic.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Viresh Kumar Oct. 7, 2013, 2:54 a.m. UTC | #1 
On 06/10/2013, Mark Brown <broonie@kernel.org> wrote:
> From: Mark Brown <broonie@linaro.org>
>
> Commit 22c8b4f140 (cpufreq: sa11x0: Expose frequency table) added use of
> struct cpufreq_frequency_table to mach-sa1100/generic.h but did not ensure
> that the struct was declared, causing build failures on machines using that
> header. Fix this.
>
> Reported-by: Olof's autobuilder <build@lixom.net>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
>
> The relevant commit is in the cpufreq tree in -next.

I have already sent relevant fix to Rafael for this, which
looks similar to this.. And I am waiting for Rafael to merge
it with offending commit...
Olof Johansson Oct. 12, 2013, 6:19 p.m. UTC | #2 
On Sun, Oct 6, 2013 at 7:54 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 06/10/2013, Mark Brown <broonie@kernel.org> wrote:
>> From: Mark Brown <broonie@linaro.org>
>>
>> Commit 22c8b4f140 (cpufreq: sa11x0: Expose frequency table) added use of
>> struct cpufreq_frequency_table to mach-sa1100/generic.h but did not ensure
>> that the struct was declared, causing build failures on machines using that
>> header. Fix this.
>>
>> Reported-by: Olof's autobuilder <build@lixom.net>
>> Signed-off-by: Mark Brown <broonie@linaro.org>
>> ---
>>
>> The relevant commit is in the cpufreq tree in -next.
>
> I have already sent relevant fix to Rafael for this, which
> looks similar to this.. And I am waiting for Rafael to merge
> it with offending commit...

Things are still broken (or broken again). Can we please see this
patch show up in next soon?


-Olof
Viresh Kumar Oct. 13, 2013, 12:39 a.m. UTC | #3 
On 12/10/2013, Olof Johansson <olof@lixom.net> wrote:
> Things are still broken (or broken again). Can we please see this
> patch show up in next soon?

Its just applied today by rafael..
b37e4d1 cpufreq: sa11x0: Fix build breakage after "Expose frequency table"
diff mbox

Patch

diff --git a/arch/arm/mach-sa1100/generic.h b/arch/arm/mach-sa1100/generic.h
index f5214ce..eff1469 100644
--- a/arch/arm/mach-sa1100/generic.h
+++ b/arch/arm/mach-sa1100/generic.h
@@ -4,6 +4,7 @@ 
  * Author: Nicolas Pitre
  */
 #include <linux/reboot.h>
+#include <linux/cpufreq.h>
 
 extern void sa1100_timer_init(void);
 extern void __init sa1100_map_io(void);