diff mbox

[v2,4/5] ARM: dts: exynos4x12: Device tree node definition for TMU on Exynos4x12

Message ID 1381300194-13134-5-git-send-email-l.majewski@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Lukasz Majewski Oct. 9, 2013, 6:29 a.m. UTC
The TMU device tree node definition for Exynos4x12 family of SoCs.

Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>

---
Changes for v2:
- None

 arch/arm/boot/dts/exynos4x12.dtsi |   10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Lukasz Majewski Oct. 15, 2013, 6:27 a.m. UTC | #1
Hi Kukjin,

> The TMU device tree node definition for Exynos4x12 family of SoCs.
> 
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> 
> ---
> Changes for v2:
> - None
> 
>  arch/arm/boot/dts/exynos4x12.dtsi |   10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi
> b/arch/arm/boot/dts/exynos4x12.dtsi index ad531fe..64c0ece 100644
> --- a/arch/arm/boot/dts/exynos4x12.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> @@ -176,4 +176,14 @@
>  			};
>  		};
>  	};
> +
> +	tmu@100C0000 {
> +		compatible = "samsung,exynos4412-tmu";
> +		interrupt-parent = <&combiner>;
> +		interrupts = <2 4>;
> +		reg = <0x100C0000 0x100>;
> +		clocks = <&clock 383>;
> +		clock-names = "tmu_apbif";
> +		status = "disabled";
> +	};
>  };

Can you pull this DT node definition for TMU (as a fix to v3.12)?

It is crucial for Exynos4412.
Eduardo Valentin Oct. 15, 2013, 1:37 p.m. UTC | #2
On 15-10-2013 02:27, Lukasz Majewski wrote:
> Hi Kukjin,
> 
>> The TMU device tree node definition for Exynos4x12 family of SoCs.
>>
>> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
>> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>> Reviewed-by: Tomasz Figa <t.figa@samsung.com>

BTW, you can add my

Reviewed-by: Eduardo Valentin <eduardo.valentin@ti.com>

on patch 4 and 5 of this series.

>>
>> ---
>> Changes for v2:
>> - None
>>
>>  arch/arm/boot/dts/exynos4x12.dtsi |   10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi
>> b/arch/arm/boot/dts/exynos4x12.dtsi index ad531fe..64c0ece 100644
>> --- a/arch/arm/boot/dts/exynos4x12.dtsi
>> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
>> @@ -176,4 +176,14 @@
>>  			};
>>  		};
>>  	};
>> +
>> +	tmu@100C0000 {
>> +		compatible = "samsung,exynos4412-tmu";
>> +		interrupt-parent = <&combiner>;
>> +		interrupts = <2 4>;
>> +		reg = <0x100C0000 0x100>;
>> +		clocks = <&clock 383>;
>> +		clock-names = "tmu_apbif";
>> +		status = "disabled";
>> +	};
>>  };
> 
> Can you pull this DT node definition for TMU (as a fix to v3.12)?
> 
> It is crucial for Exynos4412.
>
Lukasz Majewski Nov. 27, 2013, 7:11 a.m. UTC | #3
Hi Kukjin,

> Hi Kukjin,
> 
> > The TMU device tree node definition for Exynos4x12 family of SoCs.
> > 
> > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> > 
> > ---
> > Changes for v2:
> > - None
> > 
> >  arch/arm/boot/dts/exynos4x12.dtsi |   10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/exynos4x12.dtsi
> > b/arch/arm/boot/dts/exynos4x12.dtsi index ad531fe..64c0ece 100644
> > --- a/arch/arm/boot/dts/exynos4x12.dtsi
> > +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> > @@ -176,4 +176,14 @@
> >  			};
> >  		};
> >  	};
> > +
> > +	tmu@100C0000 {
> > +		compatible = "samsung,exynos4412-tmu";
> > +		interrupt-parent = <&combiner>;
> > +		interrupts = <2 4>;
> > +		reg = <0x100C0000 0x100>;
> > +		clocks = <&clock 383>;
> > +		clock-names = "tmu_apbif";
> > +		status = "disabled";
> > +	};
> >  };
> 
> Can you pull this DT node definition for TMU (as a fix to v3.12)?
> 
> It is crucial for Exynos4412.
> 

Kukjin, could you pull this patch?
kgene@kernel.org Nov. 27, 2013, 11:34 a.m. UTC | #4
Lukasz Majewski wrote:
> 
> Hi Kukjin,
> 
Hi,

> > Hi Kukjin,
> >
> > > The TMU device tree node definition for Exynos4x12 family of SoCs.
> > >
> > > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > > Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > > Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> > >
> > > ---
> > > Changes for v2:
> > > - None
> > >
> > >  arch/arm/boot/dts/exynos4x12.dtsi |   10 ++++++++++
> > >  1 file changed, 10 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/exynos4x12.dtsi
> > > b/arch/arm/boot/dts/exynos4x12.dtsi index ad531fe..64c0ece 100644
> > > --- a/arch/arm/boot/dts/exynos4x12.dtsi
> > > +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> > > @@ -176,4 +176,14 @@
> > >  			};
> > >  		};
> > >  	};
> > > +
> > > +	tmu@100C0000 {
> > > +		compatible = "samsung,exynos4412-tmu";
> > > +		interrupt-parent = <&combiner>;
> > > +		interrupts = <2 4>;
> > > +		reg = <0x100C0000 0x100>;
> > > +		clocks = <&clock 383>;
> > > +		clock-names = "tmu_apbif";
> > > +		status = "disabled";
> > > +	};
> > >  };
> >
> > Can you pull this DT node definition for TMU (as a fix to v3.12)?
> >
> > It is crucial for Exynos4412.
> >
> 
> Kukjin, could you pull this patch?
> 
Yes, but I'm not sure this is _really_ critical bug fix so maybe this will
be queued for 3.14.

If any problem, please kindly let me know.

Thanks,
Kukjin

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Lukasz Majewski Nov. 27, 2013, 12:39 p.m. UTC | #5
Hi kgene@kernel.org,

> Lukasz Majewski wrote:
> > 
> > Hi Kukjin,
> > 
> Hi,
> 
> > > Hi Kukjin,
> > >
> > > > The TMU device tree node definition for Exynos4x12 family of
> > > > SoCs.
> > > >
> > > > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > > > Reviewed-by: Bartlomiej Zolnierkiewicz
> > > > <b.zolnierkie@samsung.com> Reviewed-by: Tomasz Figa
> > > > <t.figa@samsung.com>
> > > >
> > > > ---
> > > > Changes for v2:
> > > > - None
> > > >
> > > >  arch/arm/boot/dts/exynos4x12.dtsi |   10 ++++++++++
> > > >  1 file changed, 10 insertions(+)
> > > >
> > > > diff --git a/arch/arm/boot/dts/exynos4x12.dtsi
> > > > b/arch/arm/boot/dts/exynos4x12.dtsi index ad531fe..64c0ece
> > > > 100644 --- a/arch/arm/boot/dts/exynos4x12.dtsi
> > > > +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> > > > @@ -176,4 +176,14 @@
> > > >  			};
> > > >  		};
> > > >  	};
> > > > +
> > > > +	tmu@100C0000 {
> > > > +		compatible = "samsung,exynos4412-tmu";
> > > > +		interrupt-parent = <&combiner>;
> > > > +		interrupts = <2 4>;
> > > > +		reg = <0x100C0000 0x100>;
> > > > +		clocks = <&clock 383>;
> > > > +		clock-names = "tmu_apbif";
> > > > +		status = "disabled";
> > > > +	};
> > > >  };
> > >
> > > Can you pull this DT node definition for TMU (as a fix to v3.12)?
> > >
> > > It is crucial for Exynos4412.
> > >
> > 
> > Kukjin, could you pull this patch?
> > 
> Yes, but I'm not sure this is _really_ critical bug fix so maybe this
> will be queued for 3.14.

The thermal fixes were taken by Eduardo for 3.12-rcX cycle. Those were
critical.

The code, which expects those definitions is already in ML, so we can
try to upstream those ASAP.

> 
> If any problem, please kindly let me know.
> 
> Thanks,
> Kukjin
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Lukasz Majewski Dec. 9, 2013, 8:33 a.m. UTC | #6
Hi Kukjin,

> Lukasz Majewski wrote:
> > 
> > Hi Kukjin,
> > 
> Hi,
> 
> > > Hi Kukjin,
> > >
> > > > The TMU device tree node definition for Exynos4x12 family of
> > > > SoCs.
> > > >
> > > > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > > > Reviewed-by: Bartlomiej Zolnierkiewicz
> > > > <b.zolnierkie@samsung.com> Reviewed-by: Tomasz Figa
> > > > <t.figa@samsung.com>
> > > >
> > > > ---
> > > > Changes for v2:
> > > > - None
> > > >
> > > >  arch/arm/boot/dts/exynos4x12.dtsi |   10 ++++++++++
> > > >  1 file changed, 10 insertions(+)
> > > >
> > > > diff --git a/arch/arm/boot/dts/exynos4x12.dtsi
> > > > b/arch/arm/boot/dts/exynos4x12.dtsi index ad531fe..64c0ece
> > > > 100644 --- a/arch/arm/boot/dts/exynos4x12.dtsi
> > > > +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> > > > @@ -176,4 +176,14 @@
> > > >  			};
> > > >  		};
> > > >  	};
> > > > +
> > > > +	tmu@100C0000 {
> > > > +		compatible = "samsung,exynos4412-tmu";
> > > > +		interrupt-parent = <&combiner>;
> > > > +		interrupts = <2 4>;
> > > > +		reg = <0x100C0000 0x100>;
> > > > +		clocks = <&clock 383>;
> > > > +		clock-names = "tmu_apbif";
> > > > +		status = "disabled";
> > > > +	};
> > > >  };
> > >
> > > Can you pull this DT node definition for TMU (as a fix to v3.12)?
> > >
> > > It is crucial for Exynos4412.
> > >
> > 
> > Kukjin, could you pull this patch?
> > 
> Yes, but I'm not sure this is _really_ critical bug fix so maybe this
> will be queued for 3.14.

Will you apply this patch to your Samsung tree? 

Thanks in advance.

> 
> If any problem, please kindly let me know.
> 
> Thanks,
> Kukjin
>
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
index ad531fe..64c0ece 100644
--- a/arch/arm/boot/dts/exynos4x12.dtsi
+++ b/arch/arm/boot/dts/exynos4x12.dtsi
@@ -176,4 +176,14 @@ 
 			};
 		};
 	};
+
+	tmu@100C0000 {
+		compatible = "samsung,exynos4412-tmu";
+		interrupt-parent = <&combiner>;
+		interrupts = <2 4>;
+		reg = <0x100C0000 0x100>;
+		clocks = <&clock 383>;
+		clock-names = "tmu_apbif";
+		status = "disabled";
+	};
 };