| Message ID | CAPgLHd-FgU-512ivq_eRPqefqb8-7qGY8aoOATiFNZYn-P_4rg@mail.gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 14:25 Sat 12 Oct , Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> Tomi can you take it as a fix Best Regards, J. > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > --- > drivers/video/metronomefb.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/video/metronomefb.c b/drivers/video/metronomefb.c > index f30150d..0b36160 100644 > --- a/drivers/video/metronomefb.c > +++ b/drivers/video/metronomefb.c > @@ -690,7 +690,8 @@ static int metronomefb_probe(struct platform_device *dev) > goto err_csum_table; > } > > - if (board->setup_irq(info)) > + retval = board->setup_irq(info); > + if (retval) > goto err_csum_table; > > retval = metronome_init_regs(par); > -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12/10/13 09:25, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > --- > drivers/video/metronomefb.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/video/metronomefb.c b/drivers/video/metronomefb.c > index f30150d..0b36160 100644 > --- a/drivers/video/metronomefb.c > +++ b/drivers/video/metronomefb.c > @@ -690,7 +690,8 @@ static int metronomefb_probe(struct platform_device *dev) > goto err_csum_table; > } > > - if (board->setup_irq(info)) > + retval = board->setup_irq(info); > + if (retval) > goto err_csum_table; > > retval = metronome_init_regs(par); > Thanks, queued for 3.13. Tomi
diff --git a/drivers/video/metronomefb.c b/drivers/video/metronomefb.c index f30150d..0b36160 100644 --- a/drivers/video/metronomefb.c +++ b/drivers/video/metronomefb.c @@ -690,7 +690,8 @@ static int metronomefb_probe(struct platform_device *dev) goto err_csum_table; } - if (board->setup_irq(info)) + retval = board->setup_irq(info); + if (retval) goto err_csum_table; retval = metronome_init_regs(par);