| Message ID | 1383632302-23535-2-git-send-email-sachin.kamat@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 05/11/13 07:18, Sachin Kamat wrote: > Added a binding example for reference and updated the > node name. While at it also removed the name description > as it is not necessary. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> I'm not sure we need an example in each and every binding, but anyway Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > Changes since v2: > * Removed node name description as suggested by Tomasz Figa. > --- > .../devicetree/bindings/arm/samsung/sysreg.txt | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/arm/samsung/sysreg.txt b/Documentation/devicetree/bindings/arm/samsung/sysreg.txt > index 5039c0a12f55..0ab3251a6ec2 100644 > --- a/Documentation/devicetree/bindings/arm/samsung/sysreg.txt > +++ b/Documentation/devicetree/bindings/arm/samsung/sysreg.txt > @@ -1,7 +1,12 @@ > SAMSUNG S5P/Exynos SoC series System Registers (SYSREG) > > Properties: > - - name : should be 'sysreg'; > - compatible : should contain "samsung,<chip name>-sysreg", "syscon"; > For Exynos4 SoC series it should be "samsung,exynos4-sysreg", "syscon"; > - reg : offset and length of the register set. > + > +Example: > + syscon@10010000 { > + compatible = "samsung,exynos4-sysreg", "syscon"; > + reg = <0x10010000 0x400>; > + }; -- Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Sachin Kamat wrote: > > Added a binding example for reference and updated the > node name. While at it also removed the name description > as it is not necessary. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > Changes since v2: > * Removed node name description as suggested by Tomasz Figa. > --- > .../devicetree/bindings/arm/samsung/sysreg.txt | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/arm/samsung/sysreg.txt > b/Documentation/devicetree/bindings/arm/samsung/sysreg.txt > index 5039c0a12f55..0ab3251a6ec2 100644 > --- a/Documentation/devicetree/bindings/arm/samsung/sysreg.txt > +++ b/Documentation/devicetree/bindings/arm/samsung/sysreg.txt > @@ -1,7 +1,12 @@ > SAMSUNG S5P/Exynos SoC series System Registers (SYSREG) > > Properties: > - - name : should be 'sysreg'; > - compatible : should contain "samsung,<chip name>-sysreg", "syscon"; > For Exynos4 SoC series it should be "samsung,exynos4-sysreg", "syscon"; > - reg : offset and length of the register set. > + > +Example: > + syscon@10010000 { > + compatible = "samsung,exynos4-sysreg", "syscon"; > + reg = <0x10010000 0x400>; > + }; > -- > 1.7.9.5 Looks OK to me. DT guys, shall I pick this into Samsung tree or not? Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/arm/samsung/sysreg.txt b/Documentation/devicetree/bindings/arm/samsung/sysreg.txt index 5039c0a12f55..0ab3251a6ec2 100644 --- a/Documentation/devicetree/bindings/arm/samsung/sysreg.txt +++ b/Documentation/devicetree/bindings/arm/samsung/sysreg.txt @@ -1,7 +1,12 @@ SAMSUNG S5P/Exynos SoC series System Registers (SYSREG) Properties: - - name : should be 'sysreg'; - compatible : should contain "samsung,<chip name>-sysreg", "syscon"; For Exynos4 SoC series it should be "samsung,exynos4-sysreg", "syscon"; - reg : offset and length of the register set. + +Example: + syscon@10010000 { + compatible = "samsung,exynos4-sysreg", "syscon"; + reg = <0x10010000 0x400>; + };
Added a binding example for reference and updated the node name. While at it also removed the name description as it is not necessary. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- Changes since v2: * Removed node name description as suggested by Tomasz Figa. --- .../devicetree/bindings/arm/samsung/sysreg.txt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)