| Message ID | 1383907129-7325-2-git-send-email-r.sricharan@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Nov 8, 2013 at 4:38 AM, Sricharan R <r.sricharan@ti.com> wrote: > The binding and support for system DMA module present in OMAP2+ Socs > and DRA7 with dma-engine is already present. So adding the missing > documentation for the same. > > Cc: Benoit Cousson <bcousson@baylibre.com> > Signed-off-by: Sricharan R <r.sricharan@ti.com> > --- > Documentation/devicetree/bindings/dma/ti-sdma.txt | 28 +++++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/ti-sdma.txt > > diff --git a/Documentation/devicetree/bindings/dma/ti-sdma.txt b/Documentation/devicetree/bindings/dma/ti-sdma.txt > new file mode 100644 > index 0000000..7fb2342 > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/ti-sdma.txt > @@ -0,0 +1,28 @@ > +TI SDMA > + > +Required Properties: > +- compatible : Should be "ti,omap2420-sdma", "ti,omap2430-sdma" for OMAP2 > + Should be "ti,omap3430-sdma", "ti,omap3630-sdma" for OMAP3 > + Should be "ti,omap4430-sdma" for OMAP4, OMAP5 and DRA7 > +- reg: Memory map for accessing module > +- interrupts: Interrupt request number from the dma controller to s/dma/DMA/ > + interrupt controller > +- dma-cells: Should be set to <1> > +- dma-channels: Total number of logical DMA channels supported by the > + controller > +- dma-requests: Total number of dma request signals supported by the s/dma/DMA/ > + controller These should have the # included. Rob
Hi Rob, On Saturday 09 November 2013 03:24 AM, Rob Herring wrote: > On Fri, Nov 8, 2013 at 4:38 AM, Sricharan R <r.sricharan@ti.com> wrote: >> The binding and support for system DMA module present in OMAP2+ Socs >> and DRA7 with dma-engine is already present. So adding the missing >> documentation for the same. >> >> Cc: Benoit Cousson <bcousson@baylibre.com> >> Signed-off-by: Sricharan R <r.sricharan@ti.com> >> --- >> Documentation/devicetree/bindings/dma/ti-sdma.txt | 28 +++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/dma/ti-sdma.txt >> >> diff --git a/Documentation/devicetree/bindings/dma/ti-sdma.txt b/Documentation/devicetree/bindings/dma/ti-sdma.txt >> new file mode 100644 >> index 0000000..7fb2342 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/dma/ti-sdma.txt >> @@ -0,0 +1,28 @@ >> +TI SDMA >> + >> +Required Properties: >> +- compatible : Should be "ti,omap2420-sdma", "ti,omap2430-sdma" for OMAP2 >> + Should be "ti,omap3430-sdma", "ti,omap3630-sdma" for OMAP3 >> + Should be "ti,omap4430-sdma" for OMAP4, OMAP5 and DRA7 >> +- reg: Memory map for accessing module >> +- interrupts: Interrupt request number from the dma controller to > s/dma/DMA/ > >> + interrupt controller >> +- dma-cells: Should be set to <1> >> +- dma-channels: Total number of logical DMA channels supported by the >> + controller >> +- dma-requests: Total number of dma request signals supported by the > s/dma/DMA/ Ok, will correct case. >> + controller > These should have the # included. Sorry, i do not follow this ? Regards, Sricharan
On Sat, Nov 9, 2013 at 5:53 AM, Sricharan R <r.sricharan@ti.com> wrote: > Hi Rob, > > On Saturday 09 November 2013 03:24 AM, Rob Herring wrote: >> On Fri, Nov 8, 2013 at 4:38 AM, Sricharan R <r.sricharan@ti.com> wrote: >>> The binding and support for system DMA module present in OMAP2+ Socs >>> and DRA7 with dma-engine is already present. So adding the missing >>> documentation for the same. >>> >>> Cc: Benoit Cousson <bcousson@baylibre.com> >>> Signed-off-by: Sricharan R <r.sricharan@ti.com> >>> --- >>> Documentation/devicetree/bindings/dma/ti-sdma.txt | 28 +++++++++++++++++++++ >>> 1 file changed, 28 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/dma/ti-sdma.txt >>> >>> diff --git a/Documentation/devicetree/bindings/dma/ti-sdma.txt b/Documentation/devicetree/bindings/dma/ti-sdma.txt >>> new file mode 100644 >>> index 0000000..7fb2342 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/dma/ti-sdma.txt >>> @@ -0,0 +1,28 @@ >>> +TI SDMA >>> + >>> +Required Properties: >>> +- compatible : Should be "ti,omap2420-sdma", "ti,omap2430-sdma" for OMAP2 >>> + Should be "ti,omap3430-sdma", "ti,omap3630-sdma" for OMAP3 >>> + Should be "ti,omap4430-sdma" for OMAP4, OMAP5 and DRA7 >>> +- reg: Memory map for accessing module >>> +- interrupts: Interrupt request number from the dma controller to >> s/dma/DMA/ >> >>> + interrupt controller >>> +- dma-cells: Should be set to <1> >>> +- dma-channels: Total number of logical DMA channels supported by the >>> + controller >>> +- dma-requests: Total number of dma request signals supported by the >> s/dma/DMA/ > Ok, will correct case. >>> + controller >> These should have the # included. > Sorry, i do not follow this ? You are missing the # in the property names as the example has: + #dma-cells = <1>; + #dma-channels = <32>; + #dma-requests = <64>; Rob
On Monday 11 November 2013 09:26 PM, Rob Herring wrote: > On Sat, Nov 9, 2013 at 5:53 AM, Sricharan R <r.sricharan@ti.com> wrote: >> Hi Rob, >> >> On Saturday 09 November 2013 03:24 AM, Rob Herring wrote: >>> On Fri, Nov 8, 2013 at 4:38 AM, Sricharan R <r.sricharan@ti.com> wrote: >>>> The binding and support for system DMA module present in OMAP2+ Socs >>>> and DRA7 with dma-engine is already present. So adding the missing >>>> documentation for the same. >>>> >>>> Cc: Benoit Cousson <bcousson@baylibre.com> >>>> Signed-off-by: Sricharan R <r.sricharan@ti.com> >>>> --- >>>> Documentation/devicetree/bindings/dma/ti-sdma.txt | 28 +++++++++++++++++++++ >>>> 1 file changed, 28 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/dma/ti-sdma.txt >>>> >>>> diff --git a/Documentation/devicetree/bindings/dma/ti-sdma.txt b/Documentation/devicetree/bindings/dma/ti-sdma.txt >>>> new file mode 100644 >>>> index 0000000..7fb2342 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/dma/ti-sdma.txt >>>> @@ -0,0 +1,28 @@ >>>> +TI SDMA >>>> + >>>> +Required Properties: >>>> +- compatible : Should be "ti,omap2420-sdma", "ti,omap2430-sdma" for OMAP2 >>>> + Should be "ti,omap3430-sdma", "ti,omap3630-sdma" for OMAP3 >>>> + Should be "ti,omap4430-sdma" for OMAP4, OMAP5 and DRA7 >>>> +- reg: Memory map for accessing module >>>> +- interrupts: Interrupt request number from the dma controller to >>> s/dma/DMA/ >>> >>>> + interrupt controller >>>> +- dma-cells: Should be set to <1> >>>> +- dma-channels: Total number of logical DMA channels supported by the >>>> + controller >>>> +- dma-requests: Total number of dma request signals supported by the >>> s/dma/DMA/ >> Ok, will correct case. >>>> + controller >>> These should have the # included. >> Sorry, i do not follow this ? > You are missing the # in the property names as the example has: > > + #dma-cells = <1>; > + #dma-channels = <32>; > + #dma-requests = <64>; > > Rob Oh, ok, Will add this. Regards, Sricharan
diff --git a/Documentation/devicetree/bindings/dma/ti-sdma.txt b/Documentation/devicetree/bindings/dma/ti-sdma.txt new file mode 100644 index 0000000..7fb2342 --- /dev/null +++ b/Documentation/devicetree/bindings/dma/ti-sdma.txt @@ -0,0 +1,28 @@ +TI SDMA + +Required Properties: +- compatible : Should be "ti,omap2420-sdma", "ti,omap2430-sdma" for OMAP2 + Should be "ti,omap3430-sdma", "ti,omap3630-sdma" for OMAP3 + Should be "ti,omap4430-sdma" for OMAP4, OMAP5 and DRA7 +- reg: Memory map for accessing module +- interrupts: Interrupt request number from the dma controller to + interrupt controller +- dma-cells: Should be set to <1> +- dma-channels: Total number of logical DMA channels supported by the + controller +- dma-requests: Total number of dma request signals supported by the + controller + +Example: + +sdma: dma-controller@48056000 { + compatible = "ti,omap4430-sdma"; + reg = <0x48056000 0x1000>; + interrupts = <12>, + <13>, + <14>, + <15>; + #dma-cells = <1>; + #dma-channels = <32>; + #dma-requests = <64>; +};
The binding and support for system DMA module present in OMAP2+ Socs and DRA7 with dma-engine is already present. So adding the missing documentation for the same. Cc: Benoit Cousson <bcousson@baylibre.com> Signed-off-by: Sricharan R <r.sricharan@ti.com> --- Documentation/devicetree/bindings/dma/ti-sdma.txt | 28 +++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 Documentation/devicetree/bindings/dma/ti-sdma.txt