| Message ID | 1384788541-16338-1-git-send-email-balbi@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Nov 18, 2013 at 03:29:01PM +0000, Felipe Balbi wrote: > In the hopes that people run new kernels on > their devices, let's add a warning message > asking users to have their DTS file fixed. > > The goal is that by Linux 4.0 we will be > able to remove support for the bogus version > of our touchscreen's DTS. > > Suggested-by: Mark Rutland <mark.rutland@arm.com> > Signed-off-by: Felipe Balbi <balbi@ti.com> > --- > > Here you go, I've added your Suggested-by Mark, > if you wish I can remove or change to something > else. > > cheers Looks fine to me, feel free to add my Ack. Thanks, Mark. > > drivers/input/touchscreen/ti_am335x_tsc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c > index b61df9d..91302cd 100644 > --- a/drivers/input/touchscreen/ti_am335x_tsc.c > +++ b/drivers/input/touchscreen/ti_am335x_tsc.c > @@ -354,9 +354,12 @@ static int titsc_parse_dt(struct platform_device *pdev, > */ > err = of_property_read_u32(node, "ti,coordinate-readouts", > &ts_dev->coordinate_readouts); > - if (err < 0) > + if (err < 0) { > + dev_warn(&pdev->dev, "please use 'ti,coordinate-readouts' instead\n"); > err = of_property_read_u32(node, "ti,coordiante-readouts", > &ts_dev->coordinate_readouts); > + } > + > if (err < 0) > return err; > > -- > 1.8.4.GIT > > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, Here's another patch which has been pending for months. On Mon, Nov 18, 2013 at 09:29:01AM -0600, Felipe Balbi wrote: > In the hopes that people run new kernels on > their devices, let's add a warning message > asking users to have their DTS file fixed. > > The goal is that by Linux 4.0 we will be > able to remove support for the bogus version > of our touchscreen's DTS. > > Suggested-by: Mark Rutland <mark.rutland@arm.com> > Signed-off-by: Felipe Balbi <balbi@ti.com> > --- > > Here you go, I've added your Suggested-by Mark, > if you wish I can remove or change to something > else. > > cheers > > drivers/input/touchscreen/ti_am335x_tsc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c > index b61df9d..91302cd 100644 > --- a/drivers/input/touchscreen/ti_am335x_tsc.c > +++ b/drivers/input/touchscreen/ti_am335x_tsc.c > @@ -354,9 +354,12 @@ static int titsc_parse_dt(struct platform_device *pdev, > */ > err = of_property_read_u32(node, "ti,coordinate-readouts", > &ts_dev->coordinate_readouts); > - if (err < 0) > + if (err < 0) { > + dev_warn(&pdev->dev, "please use 'ti,coordinate-readouts' instead\n"); > err = of_property_read_u32(node, "ti,coordiante-readouts", > &ts_dev->coordinate_readouts); > + } > + > if (err < 0) > return err; > > -- > 1.8.4.GIT >
On Fri, Jun 13, 2014 at 07:23:55PM -0500, Felipe Balbi wrote: > Hi, > > Here's another patch which has been pending for months. Sorry, lost track of this one, applied. > > On Mon, Nov 18, 2013 at 09:29:01AM -0600, Felipe Balbi wrote: > > In the hopes that people run new kernels on > > their devices, let's add a warning message > > asking users to have their DTS file fixed. > > > > The goal is that by Linux 4.0 we will be > > able to remove support for the bogus version > > of our touchscreen's DTS. > > > > Suggested-by: Mark Rutland <mark.rutland@arm.com> > > Signed-off-by: Felipe Balbi <balbi@ti.com> > > --- > > > > Here you go, I've added your Suggested-by Mark, > > if you wish I can remove or change to something > > else. > > > > cheers > > > > drivers/input/touchscreen/ti_am335x_tsc.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c > > index b61df9d..91302cd 100644 > > --- a/drivers/input/touchscreen/ti_am335x_tsc.c > > +++ b/drivers/input/touchscreen/ti_am335x_tsc.c > > @@ -354,9 +354,12 @@ static int titsc_parse_dt(struct platform_device *pdev, > > */ > > err = of_property_read_u32(node, "ti,coordinate-readouts", > > &ts_dev->coordinate_readouts); > > - if (err < 0) > > + if (err < 0) { > > + dev_warn(&pdev->dev, "please use 'ti,coordinate-readouts' instead\n"); > > err = of_property_read_u32(node, "ti,coordiante-readouts", > > &ts_dev->coordinate_readouts); > > + } > > + > > if (err < 0) > > return err; > > > > -- > > 1.8.4.GIT > > > > -- > balbi
On Sun, Jun 15, 2014 at 12:16:36AM -0700, Dmitry Torokhov wrote: > On Fri, Jun 13, 2014 at 07:23:55PM -0500, Felipe Balbi wrote: > > Hi, > > > > Here's another patch which has been pending for months. > > Sorry, lost track of this one, applied. Thank you
diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c index b61df9d..91302cd 100644 --- a/drivers/input/touchscreen/ti_am335x_tsc.c +++ b/drivers/input/touchscreen/ti_am335x_tsc.c @@ -354,9 +354,12 @@ static int titsc_parse_dt(struct platform_device *pdev, */ err = of_property_read_u32(node, "ti,coordinate-readouts", &ts_dev->coordinate_readouts); - if (err < 0) + if (err < 0) { + dev_warn(&pdev->dev, "please use 'ti,coordinate-readouts' instead\n"); err = of_property_read_u32(node, "ti,coordiante-readouts", &ts_dev->coordinate_readouts); + } + if (err < 0) return err;
In the hopes that people run new kernels on their devices, let's add a warning message asking users to have their DTS file fixed. The goal is that by Linux 4.0 we will be able to remove support for the bogus version of our touchscreen's DTS. Suggested-by: Mark Rutland <mark.rutland@arm.com> Signed-off-by: Felipe Balbi <balbi@ti.com> --- Here you go, I've added your Suggested-by Mark, if you wish I can remove or change to something else. cheers drivers/input/touchscreen/ti_am335x_tsc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)