| Message ID | 1384835019-3251-1-git-send-email-sachin.kamat@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 19 November 2013 09:53, Sachin Kamat <sachin.kamat@linaro.org> wrote: > Commit a403797bbd81 ("cpufreq: exynos: Convert exynos-cpufreq > to platform driver") forgot to change the function prototype. I can't find this commit anywhere.. And I can see that you had already given comments for the patch and so this should be fixed right there.. > Change it now to fix the following compilation warnings: > > drivers/cpufreq/exynos-cpufreq.c:292:18: warning: incorrect type in initializer > (different argument counts) > drivers/cpufreq/exynos-cpufreq.c:292:18: expected int ( *probe )( ... ) > drivers/cpufreq/exynos-cpufreq.c:292:18: got int ( static [toplevel] > *<noident> )( ... ) > CC drivers/cpufreq/exynos-cpufreq.o > drivers/cpufreq/exynos-cpufreq.c:292:2: warning: initialization from > incompatible pointer type [enabled by default] > .probe = exynos_cpufreq_init, > ^ > drivers/cpufreq/exynos-cpufreq.c:292:2: warning: (near initialization for > ‘exynos_cpufreq_platdrv.probe’) [enabled by default] > LD drivers/cpufreq/built-in.o > > WARNING: drivers/cpufreq/built-in.o(.data+0x644): Section mismatch in reference > from the variable exynos_cpufreq_platdrv to the function > .init.text:exynos_cpufreq_init() > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > Cc: Lukasz Majewski <l.majewski@samsung.com> > --- > drivers/cpufreq/exynos-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Viresh Kumar <viresh.kumar@linaro.org> -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Viresh, On 19 November 2013 10:29, Viresh Kumar <viresh.kumar@linaro.org> wrote: > On 19 November 2013 09:53, Sachin Kamat <sachin.kamat@linaro.org> wrote: >> Commit a403797bbd81 ("cpufreq: exynos: Convert exynos-cpufreq >> to platform driver") forgot to change the function prototype. > > I can't find this commit anywhere.. > And I can see that you had already given comments for the patch and > so this should be fixed right there.. Sorry, please discard this patch. Looks like I had applied this patch locally in my tree when I was reviewing it. I did give my comments about this warning then. Somehow I thought this patch got applied without my comment getting addressed, hence I fixed this myself. Sorry for the noise. Lukasz, do you plan to send the updated the patch?
Hi Sachin, > Hi Viresh, > > On 19 November 2013 10:29, Viresh Kumar <viresh.kumar@linaro.org> > wrote: > > On 19 November 2013 09:53, Sachin Kamat <sachin.kamat@linaro.org> > > wrote: > >> Commit a403797bbd81 ("cpufreq: exynos: Convert exynos-cpufreq > >> to platform driver") forgot to change the function prototype. > > > > I can't find this commit anywhere.. > > > And I can see that you had already given comments for the patch and > > so this should be fixed right there.. > > Sorry, please discard this patch. Looks like I had applied this patch > locally in my tree > when I was reviewing it. I did give my comments about this warning > then. Somehow I thought this patch got applied without my comment > getting addressed, hence I > fixed this myself. Sorry for the noise. > > Lukasz, do you plan to send the updated the patch? > Yes. I will sent the update.
diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c index a2f57d4101fc..e238c46efaac 100644 --- a/drivers/cpufreq/exynos-cpufreq.c +++ b/drivers/cpufreq/exynos-cpufreq.c @@ -233,7 +233,7 @@ static struct cpufreq_driver exynos_driver = { #endif }; -static int __init exynos_cpufreq_init(void) +static int exynos_cpufreq_init(struct platform_device *pdev) { int ret = -EINVAL;
Commit a403797bbd81 ("cpufreq: exynos: Convert exynos-cpufreq to platform driver") forgot to change the function prototype. Change it now to fix the following compilation warnings: drivers/cpufreq/exynos-cpufreq.c:292:18: warning: incorrect type in initializer (different argument counts) drivers/cpufreq/exynos-cpufreq.c:292:18: expected int ( *probe )( ... ) drivers/cpufreq/exynos-cpufreq.c:292:18: got int ( static [toplevel] *<noident> )( ... ) CC drivers/cpufreq/exynos-cpufreq.o drivers/cpufreq/exynos-cpufreq.c:292:2: warning: initialization from incompatible pointer type [enabled by default] .probe = exynos_cpufreq_init, ^ drivers/cpufreq/exynos-cpufreq.c:292:2: warning: (near initialization for ‘exynos_cpufreq_platdrv.probe’) [enabled by default] LD drivers/cpufreq/built-in.o WARNING: drivers/cpufreq/built-in.o(.data+0x644): Section mismatch in reference from the variable exynos_cpufreq_platdrv to the function .init.text:exynos_cpufreq_init() Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Cc: Lukasz Majewski <l.majewski@samsung.com> --- drivers/cpufreq/exynos-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)